Invalid cursor error in procedure

Question

i am writing a procedure in which i have make use of cursor........it is giving me error INVALID CURSOR
on running
i have used this cursor with WITH CLAUSE....
when i am executing or running this procedure this giving me invalid cursor error
create or replace
procedure USP_UPDATEDRUGORDERDTL
v_pServiceid IN NUMBER DEFAULT NULL ,
v_pServRendered IN NUMBER DEFAULT NULL ,
v_pSchDateTime IN DATE DEFAULT NULL ,
v_pOrdQty IN FLOAT DEFAULT NULL ,
v_billingclassid IN NUMBER DEFAULT NULL ,
v_pOrdID IN NUMBER DEFAULT NULL ,
v_UpdatedBy IN NUMBER DEFAULT NULL ,
v_prender IN NUMBER DEFAULT 0 ,
v_pInsertedByUserID IN VARCHAR2 DEFAULT NULL ,
v_pInsertedON IN DATE DEFAULT NULL ,
v_pDrugID IN NUMBER DEFAULT 0 ,
v_pRate IN FLOAT DEFAULT 0 ,
v_pBatchId IN NUMBER DEFAULT 0 ,
v_OrderSource IN VARCHAR2 DEFAULT NULL ,
v_pInsertedMacID IN VARCHAR2 DEFAULT NULL ,
v_pInsertedIPAddress IN VARCHAR2 DEFAULT NULL ,
v_pOldOrdID IN NUMBER DEFAULT NULL,
v_plocid in char DEFAULT NULL
AS
vr_pConsumptionID NUMBER(10,0);
vr_pSavedQty NUMBER(10,3);
vr_pReturnQty NUMBER(10,3);
vr_Qty NUMBER(10,3);
begin
vr_pSavedQty := 0;
vr_pReturnQty := v_pOrdQty;
declare
cursor ordDtl_cur is -----cursor declaration
with --- with clause used with cursor
Q1 AS
Select NVL(ConsumptionID,0) As ConsumptionID,Sum(OrdQty) As OrdQty,
OrdID,DrugID,BatchID, locid from Orderdtl
Where OrdID = v_pOldOrdID and DrugID = v_pDrugID And BatchID = v_pBatchID and NVL(Cancelled,0) = 0
Group By OrdID,DrugID,BatchID,ConsumptionID
Order By ConsumptionID asc
Q2 AS
SELECT NVL(OrderDtl.ConsumptionID,0) As ConsumptionID,(SUM(OrderDtl.OrdQty)) As OrdQty,
IvPatientIssueReturnDtl.OrderID as OrdID,OrderDtl.DrugID,OrderDtl.BatchID,OrderDtl.locid
FROM OrderDtl INNER JOIN
IvPatientIssueReturnDtl ON OrderDtl.OrdID = IvPatientIssueReturnDtl.NewOrderId AND
OrderDtl.DrugId = IvPatientIssueReturnDtl.ItemId AND OrderDtl.BatchId = IvPatientIssueReturnDtl.BatchId
WHERE (OrderDtl.BatchId = v_pBatchID) AND (IvPatientIssueReturnDtl.OrderId = v_pOldOrdID)
AND (OrderDtl.DrugID = v_pDrugID) and NVL(OrderDtl.Cancelled,0) = 0
Group By IvPatientIssueReturnDtl.OrderID,OrderDtl.DrugID,OrderDtl.BatchID,OrderDtl.ConsumptionID
Order By OrderDtl.ConsumptionID asc
Select
Q1.ConsumptionID,(Sum(NVL(Q1.OrdQty,0)) + Sum(NVL(Q2.OrdQty,0))) As OrdQty,
Q1.OrdID,Q1.DrugID,Q1.BatchID,Q1.locid
from
Q1 ,Q2
where
Q1.OrdID =Q2.OrdID(+)
and
Q1.BatchID =Q2.BatchID(+)
and
Q1.DrugID =Q2.DrugID(+)
and
Q1.ConsumptionID =Q2.ConsumptionID(+)
Group By Q1.OrdID,Q1.BatchID,Q1.DrugID,Q1.ConsumptionID;
TYPE ordDtl_trec is TABLE of ordDtl_cur%ROWTYPE index by PLS_INTEGER;
l_ordDtl ordDtl_trec; ---- cursor syntax
begin
if ordDtl_cur%ISOPEN then
open ordDtl_cur; --------------opening cursor
end if;
loop
-- fetch data into cursor---
fetch ordDtl_cur
bulk collect into
l_ordDtl;
-----perform logic--------------------
for indx IN 1..l_ordDtl.COUNT loop
if vr_pSavedQty <> vr_pReturnQty then
If v_pOrdQty <= (vr_pReturnQty - vr_pSavedQty) then
vr_pSavedQty := vr_pSavedQty + v_pOrdQty;
vr_Qty := v_pOrdQty;
else
vr_Qty := (vr_pReturnQty - vr_pSavedQty);
vr_pSavedQty := vr_pSavedQty + (vr_pReturnQty - vr_pSavedQty);
end if;
end if;
end loop;
exit when ordDtl_cur%NOTFOUND;
end loop;
CLOSE ordDtl_cur; ---- closing cursor
end;
end;

Answer 1

Hello.
Very simple.
You are using cursor name before opening it.
Here is the problem.
  if ordDtl_cur%ISOPEN then
   open ordDtl_cur; --------------opening cursor
  end if;
end if;Please change your code like this
comment IF statement use only OPEN  ordDtl_cur;
  ---- if ordDtl_cur%ISOPEN then
     open ordDtl_cur; --------------opening cursor
  --- end if;Thanks,
Suri