Issue in comparing 2 instances of VO with LOV/VL

Question

Experts,
I have 2 instances of a VO in my AppModule. I am doing a column by column comparison of the 2 instances as per the below code. Everything is good if i don't have a LOV or VL defined for any attribute in the VO.
For eg if i have 1 lov defined in the VO then i have to do -1 in the loop. Is there any better way to achieve the result. The issue is the moment you define a LOV or VL, an entry is created in the VOEOViewRowImpl as part of AttributesEnum.
    public Map compareTo(Row rowToCompare){
        HashMap returnMap = new HashMap();
        if(rowToCompare!=null && rowToCompare instanceof CustomerMasterEOViewRowImpl){
            String[] name = this.getAttributeNames();
            Object[] value = this.getAttributeValues();
            String[] rowToCompareAttributeNames = rowToCompare.getAttributeNames();
            Object[] rowToCompareAttributeValues = rowToCompare.getAttributeValues();
            for (int i=0; i< this.getAttributeCount();i++) //subtract here the nos of lovs or VL defined :(
                logger.debug("name[i] : " + name);
logger.debug("value[i] : " + value[i]);
logger.debug("rowToCompareAttributeNames[i] : " + rowToCompareAttributeNames[i]);
//logger.debug("Column name is " + getEntityAttrForAttribute(rowToCompareAttributeNames[i]).getColumnName());
logger.debug("rowToCompareAttributeValues[i] : " + rowToCompareAttributeValues[i]);
if (rowToCompareAttributeValues[i] != null && value[i]!=null)
if(!rowToCompareAttributeValues[i].toString().equals(value[i].toString())){
returnMap.put(getEntityAttrForAttribute(rowToCompareAttributeNames[i]).getColumnName(), rowToCompare.getAttribute(name[i]).toString());
logger.debug("Addded " + getEntityAttrForAttribute(rowToCompareAttributeNames[i]).getColumnName() + " with value " + rowToCompare.getAttribute(name[i]).toString() + "in the map");
if (rowToCompareAttributeValues[i] != null && value[i]==null){
returnMap.put(getEntityAttrForAttribute(rowToCompareAttributeNames[i]).getColumnName(), rowToCompare.getAttribute(name[i]).toString());
logger.debug("Addded " + getEntityAttrForAttribute(rowToCompareAttributeNames[i]).getColumnName() + " with value " + rowToCompare.getAttribute(name[i]).toString() + "in the map");
return returnMap;
return returnMap;
thnks
Jdev 11.1.2.1

Answer 1

I don't agree with you here. Once this in your code you never get it out (I simply forget to do such things). Then later on you change something in the VO and start wondering why the app don't run as expected. If you are lucky you'll find the error within a day, Murphy law however predict a longer search :)
Now the question for the base class for VL: put a break point on your for loop and check which class you get back (or log a debug message, and please don't use SOP). My guess is you get 'Row' and 'RowSetIterator' ...
Timo