JAVA Help, what am I doing wrong?

Question

HI, I have this class and method
It runs properly when called upon, but there is an error at the end and the program ceases - not running running back to my program menu,
anything you can see I'm doing wrong?
Or is there a better/easier way to do this?
import java.io.File;
import java.util.Scanner;
public class Program{
     public Program(){
          super();
     public void printProgramList() throws Exception{
          PL1[] allstudentObjArray = new PL1[9];
               Scanner pl2 = new Scanner(new File("test.txt"));
               int i=0;
          //     boolean found = false;
               while(pl2.hasNextLine())
               //Delimit this line with scanner
               Scanner sa1 = new Scanner(pl2.nextLine());
               sa1.useDelimiter(":");
               allstudentObjArray[i] = new PL1(sa1.next(),sa1.next(),sa1.next(),sa1.next(),sa1.next(),sa1.next(),sa1.next(),sa1.next(),sa1.next());
               i++;
               }//while
               for(int i1 = 0;i1 < allstudentObjArray.length;i1++)
               System.out.println(allstudentObjArray[i1].CourseCode);
               System.out.println(allstudentObjArray[i1].CrsSub1);
               System.out.println(allstudentObjArray[i1].CrsSub2);
               System.out.println(allstudentObjArray[i1].CrsSub3);
               System.out.println(allstudentObjArray[i1].CrsSub4);
               System.out.println(allstudentObjArray[i1].CrsSub5);
               System.out.println(allstudentObjArray[i1].CrsSub6);
               System.out.println(allstudentObjArray[i1].CrsSub7);
               System.out.println(allstudentObjArray[i1].CrsSub8);
               System.out.println("-----------------");     
     }//NEED FOR CLASS
class PL1
String CourseCode = null;
String CrsSub1 = null;
String CrsSub2 = null;
String CrsSub3 = null;
String CrsSub4 = null;
String CrsSub5 = null;
String CrsSub6 = null;
String CrsSub7 = null;
String CrsSub8 = null;
PL1()
PL1(String CourseCode,String CrsSub1, String CrsSub2, String CrsSub3, String CrsSub4, String CrsSub5, String CrsSub6, String CrsSub7, String CrsSub8)
this.CourseCode = CourseCode;
this.CrsSub1 = CrsSub1;
this.CrsSub2 = CrsSub2;
this.CrsSub3 = CrsSub3;
this.CrsSub4 = CrsSub4;
this.CrsSub5 = CrsSub5;
this.CrsSub6 = CrsSub6;
this.CrsSub7 = CrsSub7;
this.CrsSub8 = CrsSub8;
     The text file has data like this
Test123:ABCD1213:ABCD1896:ABCD1890:ABCD1913:ABCD5513:ABCD1673:ABCD8913:ABCD1278

Answer 1

My 2c.
1. Use a list (or other dynamin datastructure) when you do don't know before-hand how-big the list-of-stuff is going to be.
2. "subjects" is obviously a list-of-stuff... so use some sort of "collection" datastructure to represent it, NOT nine distinct variables (puke!)... in this case we do know how big the list-of-stuff is, because we've just read it from file... so an array will do nicely.
3. Oh FFS, use meaningful variable and especially class names! Putz!
package forums;
import java.io.File;
import java.io.FileNotFoundException;
import java.io.IOException;
import java.util.Scanner;
import java.util.Arrays;
import java.util.List;
import java.util.ArrayList;
class Course
  private final String id;
  private final String[] subjects;
  public Course(String courseCode, String[] subjects) {
    this.id = courseCode;
    this.subjects = subjects;
  @Override
  public String toString() {
    return id+": "+Arrays.toString(subjects);
public class CourseManager
  private List<Course> courses = null;
  public static void main(String[] args) {
    try {
      new CourseManager("CourseManager.txt").print();
    } catch (Exception e) {
      e.printStackTrace();
  public CourseManager(){
  public CourseManager(String filename) throws FileNotFoundException, IOException {
    read(filename);
  public void read(String filename) throws FileNotFoundException, IOException {
    this.courses = new ArrayList<Course>();
    Scanner scanner = null;
    try {
      scanner = new Scanner(new File(filename));
      while( scanner.hasNextLine() ) {
        String[] fields = scanner.nextLine().split(":");
        courses.add(new Course(fields[0], Arrays.copyOfRange(fields, 1, fields.length)));
    } finally {
      if(scanner!=null)scanner.close();
  public void print() {
    for ( Course course : courses ) {
      System.out.println(course);
      System.out.println("-----------------");
}Cheers. Keith.
Edited by: corlettk on 9/05/2009 14:40 ~~ More succinct.