Java OutOfMemoryError on File Upload in ADF

Question

Hi All,
I am using JDeveloper 11.1.1.5.0.
I am uploading a file in ADF. i should be able to upload files upto 10MB. below is the method I am calling when user puts the filename.
    public void setUploadedFile(ValueChangeEvent valueChangeEvent) {
        UploadedFile file = (UploadedFile)valueChangeEvent.getNewValue();
        if (file != null && file.getLength() > 0l) {
            filename = file.getFilename();
            filetype = file.getContentType();
            try {
                InputStream is = file.getInputStream();
                long length = file.getLength();
                if (length > Integer.MAX_VALUE) {
                    // File is too large
                byte[] bytes = new byte[(int)length];
                int offset = 0;
                int numRead = 0;
                while (offset < bytes.length &&
                       (numRead = is.read(bytes, offset,
                                          bytes.length - offset)) >= 0) {
                    offset += numRead;
                if (offset < bytes.length) {
                    try {
                        throw new IOException("Could not read complete file");
                    } catch (IOException e) {
                        e.printStackTrace();
                is.close();
                byte[] encoded = Base64.encode(bytes);
                filecontents = new String(encoded);  //getting java.lang.OutOfMemoryError: Java heap space error here
            } catch (IOException e) {
                e.printStackTrace();
        }else{
    }I am getting a java.lang.OutOfMemoryError: Java heap space error at the mentioned point. This is happening for files larger than 5MB.
My web.xml have below entries.
<context-param>
      <param-name>org.apache.myfaces.trinidad.UPLOAD_MAX_DISK_SPACE</param-name>
      <param-value>512000000</param-value>
   </context-param>
   <context-param>
      <param-name>org.apache.myfaces.trinidad.UPLOAD_MAX_MEMORY</param-name>
      <param-value>51200000</param-value>
   </context-param>
   <context-param>
    <!-- directory to store temporary files -->
    <param-name>oracle.adf.view.faces.UPLOAD_TEMP_DIR</param-name>
    <!-- Use an ADFUploads subdirectory of /tmp -->
    <param-value>/tmp/ADFUploads/</param-value>
  </context-param>how can i resolve this issue?
regards,
Rajan

Answer 1

byte[] bytes = new byte[(int)length];means that you try to load the whole file into memory (regardless of the parameters in web.xml). And after the file is loaded you need the same amount on memory for
filecontents = new String(encoded); You should upload the data from the stream into a file and then process the file when you need to do it. For this you can use http://projects.apache.org/projects/commons_io.html
Timo