JDBC-ODBC Bridge seems to slow down after a while

Question

Hi,
I've got a weird problem going on with an application I'm writing. I hope someone can tell me what I'm doing wrong.
The problem I'm encountering is in he code shown below. The function getAllGamesForATeam is creating a list of items in an ArrayList and passing it back to an Event handler so that I can put it in the session of a servlet. The first time I run this code, it is fast. Fast enough to use on a servlet. The second time it runs, it is MUCH slower...too slow to use on a servlet. The third time it runs, it gets even worse.
I am using the JDBC-ODBC bridge to access my database which is in Access 97. I do have connection pooling enabled on the database. Still it is slow.
If you have any ideas, I would appreciate it. Here's the code:
// GameBean.java
// A class to represent a Game in my College Hockey Program
// Based on Team and League tables.
package MyBeans;
import java.io.*;
import java.sql.*;
import java.util.*;
import javax.servlet.http.*;
* <p>This is the Java bean used to get and display information about
* items for sale in our web based store.
* @version 1.0.0 08/13/2001
* @author Kevin Yetman
* @see DBBeanBase
public class GameBean extends DBBeanBase
* <p>Default constructor, creates an empty {@link GameBean}.
public GameBean()
super();
* <p>Copy constructor. This constructor creates a {@link GameBean} object
* that is initially populated with a copy of the {@link java.util.Map} specified
* as a parameter to this constructor. All {@link java.util.Map} Maps should
* implement a copy constructor.
* @param copyThisMap the {@link Map} used to initialize this {@link GameBean} object.
public GameBean(Map copyThisMap)
super(copyThisMap);
* <p>This constructor creates an {@link GameBean} object and
* populates it with the fields in a {@link java.sql.ResultSet}.
* @param rs The {@link java.sql.ResultSet} object used to populate
* this class with information about an item.
* @throws java.sql.SQLException if there is an error iterating the
* {@link java.sql.ResultSet}.
protected GameBean(ResultSet rs) throws SQLException
super(rs);
* <p>This constructor creates an {@link GameBean} object associated with the
* specified item id. If there is no record in the data source with the
* specified item id, an exception is thrown.
* @param conneciton The {@link java.sql.Connection} object used to execute
* the select statement that will retrieve the item information.
* @param iLeagueId specifies the league id used to populate this object.
* @throws java.sql.SQLException if there is an error selecting the item
* information.
* @throws java.lang.Exception if the item id is invalid.
public GameBean(Connection connection, int iGameId) throws SQLException, Exception
super();
String strSQL="SELECT GameIndex, Month, Day, Year, HomeTeamIndex, VisitorTeamIndex, HomeTeamScoredFirst, LeagueGame, NeutralSiteGame, PlayoffGame, HomeTeamGoals, VisitorTeamGoals FROM Game WHERE GameIndex=" + iGameId;
Statement statement = connection.createStatement();
ResultSet rs = statement.executeQuery(strSQL);
if (rs.next())
populateFromResultSet(rs);
else
throw new Exception("Invalid game Id: " + iGameId);
putInTeamNames(connection);
* <p>This method returns the league's index.
* @return the league's index.
public void putInTeamNames(Connection connection)
throws SQLException
String strSQL="SELECT TeamName FROM Team WHERE TeamIndex=" + getHomeTeamIndex();
Statement statement = connection.createStatement();
ResultSet rs = statement.executeQuery(strSQL);
if( rs.next() )
put("HOMETEAMNAME", rs.getString("TeamName"));
strSQL="SELECT TeamName FROM Team WHERE TeamIndex=" + getVisitorTeamIndex();
rs=statement.executeQuery(strSQL);
if( rs.next() )
put("VISITORTEAMNAME", rs.getString("TeamName"));
* <p>This method returns the league's index.
* @return the league's index.
public String getGameIndex()
return get("GAMEINDEX").toString();
* <p>This method returns the name of the league.
* @return the name of the league.
public String getMonth()
return get("MONTH").toString();
* <p>This method returns the name of the league.
* @return the name of the league.
public String getDay()
return get("DAY").toString();
* <p>This method returns the name of the league.
* @return the name of the league.
public String getYear()
return get("YEAR").toString();
* <p>This method returns the name of the league.
* @return the name of the league.
public String getHomeTeamName()
return get("HOMETEAMNAME").toString();
* <p>This method returns the league's nickname.
* @return the league's nickname.
public String getVisitorTeamName()
return get("VISITORTEAMNAME").toString();
* <p>This method returns the name of the league.
* @return the name of the league.
public String getHomeTeamIndex()
return get("HOMETEAMINDEX").toString();
* <p>This method returns the league's nickname.
* @return the league's nickname.
public String getVisitorTeamIndex()
return get("VISITORTEAMINDEX").toString();
* <p>This method returns the league's nickname.
* @return the league's nickname.
public String getLeagueGame()
return get("LEAGUEGAME").toString();
* <p>This method returns the league's nickname.
* @return the league's nickname.
public String getNeutralSiteGame()
return get("NEUTRALSITEGAME").toString();
* <p>This method returns the league's nickname.
* @return the league's nickname.
public String getPlayoffGame()
return get("PLAYOFFGAME").toString();
* <p>This method returns the league's nickname.
* @return the league's nickname.
public String getHomeTeamScoredFirst()
return get("HOMETEAMSCOREDFIRST").toString();
* <p>This method returns the league's nickname.
* @return the league's nickname.
public String getHomeTeamGoals()
return get("HOMETEAMGOALS").toString();
* <p>This method returns the league's automatic bids.
* @return the league's automatic bids.
public String getVisitorTeamGoals()
return get("VISITORTEAMGOALS").toString();
* <p>This method returns a textual representation of this {@link ItemBean}.
* @return a textual representation of this {@link ItemBean}.
public String toString()
StringBuffer sb=new StringBuffer();
sb.append("GameIndex: " + getGameIndex() + "\n");
sb.append("HomeTeamScoredFirst: " + getHomeTeamScoredFirst() + "\n");
sb.append("PlayoffGame: " + getPlayoffGame() + "\n");
sb.append("LeagueGame: " + getLeagueGame() + "\n");
sb.append("NeutralSiteGame: " + getNeutralSiteGame() + "\n");
sb.append("HomeTeamIndex: " + getHomeTeamIndex() + "\n");
sb.append("VisitorTeamIndex: " + getVisitorTeamIndex() + "\n");
sb.append("HomeTeamName: " + getHomeTeamName() + "\n");
sb.append("VisitorTeamName: " + getVisitorTeamName() + "\n");
sb.append("Month: " + getMonth() + "\n");
sb.append("Day: " + getDay() + "\n");
sb.append("Year: " + getYear() + "\n");
return sb.toString();
* <p>This method returns a {@link java.util.Collection} of all of the teams
* in the data source.
* @param connection The {@link java.sql.Connection} object used to execute
* the select statement that will retrieve the teams.
* @return a {@link java.util.Collection} of all of the teams in the data source.
* @throws java.sql.SQLException if there is an error selecting the items.
public static Collection getAllGames(Connection connection) throws SQLException
Collection col=new ArrayList(1100);
String strSQL = "SELECT GameIndex, Month, Day, Year, HomeTeamIndex, VisitorTeamIndex, HomeTeamScoredFirst, LeagueGame, NeutralSiteGame, PlayoffGame, HomeTeamGoals, VisitorTeamGoals FROM Game";
Statement statement = connection.createStatement();
ResultSet rs = statement.executeQuery(strSQL);
while(rs.next())
GameBean currentGame=new GameBean(rs);
currentGame.putInTeamNames(connection);
col.add(currentGame);
return col;
* <p>This method returns a {@link java.util.Collection} of all of the teams
* in the data source.
* @param connection The {@link java.sql.Connection} object used to execute
* the select statement that will retrieve the teams.
* @return a {@link java.util.Collection} of all of the teams in the data source.
* @throws java.sql.SQLException if there is an error selecting the items.
public static Collection getAllGamesForALeague(Connection connection, String leagueNickName) throws SQLException
Collection col=new ArrayList(500);
String strSQL = "SELECT LeagueIndex FROM League WHERE LeagueNickName='" + leagueNickName + "'";
Statement statement = connection.createStatement();
ResultSet rs = statement.executeQuery(strSQL);
int leagueIndex=-1;
if( rs.next() )
leagueIndex=rs.getInt("LeagueIndex");
strSQL = "SELECT GameIndex, Month, Day, Year, HomeTeamIndex, VisitorTeamIndex, HomeTeamScoredFirst, LeagueGame, NeutralSiteGame, PlayoffGame, HomeTeamGoals, VisitorTeamGoals FROM Game";
strSQL+=" WHERE (HomeTeamIndex IN (SELECT TeamIndex FROM Team WHERE LeagueIndex=" + leagueIndex + ")) OR";
strSQL+=" (VisitorTeamIndex IN (SELECT TeamIndex FROM Team WHERE LeagueIndex=" + leagueIndex + "))";
strSQL+=" ORDER BY Year, Month, Day";
statement = connection.createStatement();
rs = statement.executeQuery(strSQL);
while(rs.next())
GameBean currentGame=new GameBean(rs);
currentGame.putInTeamNames(connection);
System.out.println(currentGame.getGameIndex());
col.add(currentGame);
return col;
* <p>This method returns a {@link java.util.Collection} of all of the teams
* in the data source.
* @param connection The {@link java.sql.Connection} object used to execute
* the select statement that will retrieve the teams.
* @return a {@link java.util.Collection} of all of the teams in the data source.
* @throws java.sql.SQLException if there is an error selecting the items.
public static Collection getAllGamesForATeam(Connection connection, String teamName)
throws SQLException
Collection col=new ArrayList(50);
String strSQL = "SELECT TeamIndex FROM Team WHERE TeamName='" + teamName + "'";
Statement statement = connection.createStatement();
ResultSet rs = statement.executeQuery(strSQL);
int teamIndex=-1;
if( rs.next() )
teamIndex=rs.getInt("TeamIndex");
strSQL = "SELECT GameIndex, Month, Day, Year, HomeTeamIndex, VisitorTeamIndex, HomeTeamScoredFirst, LeagueGame, NeutralSiteGame, PlayoffGame, HomeTeamGoals, VisitorTeamGoals FROM Game";
strSQL+=" WHERE (HomeTeamIndex=" + teamIndex + ") OR";
strSQL+=" (VisitorTeamIndex=" + teamIndex + ")";
strSQL+=" ORDER BY Year, Month, Day";
statement = connection.createStatement();
rs = statement.executeQuery(strSQL);
while(rs.next())
GameBean currentGame=new GameBean(rs);
currentGame.putInTeamNames(connection);
col.add(currentGame);
return col;
// The unit test method public static void main(String[] args)
// has been moved to ..\TestPrograms\TestItemBean.java so that this
// class can be used in the package MyBeans.
/////////////////////////////////// END OF FILE //////////////////////////////

Answer 1

Where do you close the ResultSet?
Where do you close the Statement?
Presumably you only create one connection for all users or you close it somewhere.