JSF RI 1.0 File Uploads mit Multipart Filter

Question

Hi there,
I already posted my problem - I need support for a basic file upload. My requirement is, that I want to access teh file data in a Managed Bean method and then decice what to to with it.
I decided to use Jason Hunters Multipart Filter, that comes with the oreilly servlet jar file. My problem with the following code is, that the upload() method is never called. I think the filter is not invoked, but I don't know why. Could anyone please see, if I am on the right track?
First, here is my web.xml with the filter:
     <!-- OReilly MultiPart Filter - by Jason Hunter -->
     <!-- JSF RI 1.0 cannot handle MutliPart Requests -->
<filter>
<filter-name>multipartFilter</filter-name>
<filter-class>com.oreilly.servlet.MultipartFilter</filter-class>
<!-- we do not specify a special directory, the servlet containers tmp directory is used
<init-param>
<param-name>uploadDir</param-name>
<param-value>/tmp</param-value>
</init-param>
-->
</filter>
<filter-mapping>
<filter-name>multipartFilter</filter-name>
<url-pattern>/*</url-pattern>
</filter-mapping>
--> this code comes at the end of my web.xml, so after the jsf cotnroller servlet is configured, etc.
in my jsp page, I got this form:
<h:form enctype="multipart/form-data">
<table width="100%" border="1" cellspacing="2" cellpadding="2">
<tr>
<td width="25%" align="right">Bild</td>
<td width="75%"><input type="file" name="file"></td>
</tr>
<tr>
<td> </td>
<td><h:commandButton id="upload" action="#{uploadBean.upload}" value="#{messages.uploadFile}"/>
     </td>
</tr>
</table>
</h:form>
--> the file upload is done with a normal html tag, because there is no jsf tag for it.
then, here us may upload() method in the managed bean:
(the upload method is never called... why???? )
     public String upload()
          log.debug("entering upload()...");
          // Files can be read if the request class is MultipartWrapper
          // Init params to MultipartWrapper control the upload handling
          HttpServletRequest request = (HttpServletRequest)FacesContext.getCurrentInstance().getExternalContext().getRequest();
          if (request instanceof MultipartWrapper)
               log.debug("The MultiPart Filter recognized the mulitpart request.");
                    // Cast the request to a MultipartWrapper
                    MultipartWrapper multi = (MultipartWrapper) request;
                    // Show which files we received
                    Enumeration files = multi.getFileNames();
                    while (files.hasMoreElements())
                         String name = (String) files.nextElement();
                         String filename = multi.getFilesystemName(name);
                         String type = multi.getContentType(name);
                         File f = multi.getFile(name);
                         log.debug("name: " + name);
                         log.debug("filename: " + filename);
                         log.debug("type: " + type);
                         if (f != null)
                              log.debug("length: " + f.length());
          return "upload";
THANX! it would be great to get this sample running!

Answer 1

Hello!
I have a photo which I store in MSSQL db as a BLOB so it looks like:
| |
| Photo |
| |
-----------------------+
| c:\my.jpg | choose |
-----------------------+
where
<f:verbatim>
<input name="photo" id="photo" type="file">
</f:verbatim>
is rendered into standard choose file dialog (unfortunately I can't change it).
So when user click "choose" it's able to select local file (a picture).
Then in textbox (input) appear the path (of course it can write it directly).
A click to the picture
a) launch javascript:
onclick="document.getElementById('photo').name='#{DatosPersonalesForm.foto}';"
that change image value (file name) so I could know which file to look for later:
<h:graphicImage value="#{DatosPersonalesForm.foto}" ...
b) after this id calls the actionListener:
<h:commandLink actionListener="#{DatosPersonalesForm.uploadPhoto}" ...
In DatosPersonalesForm I have foto property (with get/set) which store foto
public String getFoto()
public void setFoto()
The problem is how to return foto: I put an image in a session and get it from another servlet (registred in web.xml) which intercepts /images/* and return ones from the session.
I tried use Base64 encoding to embedd images directly, but it works only in Mozilla (even it's html 4.01).
here is my full DatosPersonalesForm.class (with some additional crap):
public class DatosPersonalesForm implements Observer, Serializable
private int idCentro = 1;
private CurrentClient client;
private String foto;
//private String data;
private Abonado abonado;
private Persona persona;
private DireccionTableModel direcciones;
public DatosPersonalesForm()
abonado = new Abonado();
persona = new Persona();
direcciones = new DireccionTableModel();
public void setClient(CurrentClient client)
this.client = client;
client.addObserver(this);
public void setIdCentro(int idCentro)
this.idCentro = idCentro;
direcciones.setIdCentro(idCentro);
public void setIdAbonado(int idAbonado)
if (idAbonado > 0)
try
abonado = AbonadoDAO.load(idAbonado, idCentro);
persona = PersonaDAO.load(idAbonado, idCentro);
catch (Exception ex)
FacesContext.getCurrentInstance().getExternalContext().log(ex.toString());
else
abonado = new Abonado();
persona = new Persona();
direcciones.setIdPersona(idAbonado);
public Abonado getAbonado() { return abonado; }
public void setAbonado(Abonado abonado) { this.abonado = abonado; }
public Persona getPersona() { return persona;}
public void setPersona(Persona persona) { this.persona = persona; }
public DireccionTableModel getDirecciones() { return direcciones; }
public void setDirecciones(DireccionTableModel direcciones) { this.direcciones = direcciones; }
//public String getData() { return data; }
public String getFoto()
if (persona != null)
try
Imagenes imagenes = ImagenesDAO.load(persona.getIdImagen(), idCentro);
if (imagenes != null)
foto = "/images/" + putImage(imagenes.getImagen());
//data = Base64Encoder.encode(imagenes.getImagen());
catch (Exception ex)
foto = "/img/photo_unavailable.jpg";
FacesContext.getCurrentInstance().getExternalContext().log(ex.toString());
return foto;
public void setFoto(String foto) { this.foto = foto; }
public void uploadPhoto(ActionEvent e)
// for which person to upload???
if (persona != null)
HttpServletRequest r = (HttpServletRequest)FacesContext.getCurrentInstance().getExternalContext().getRequest();
if (r instanceof ServletRequestWrapper)
ServletRequest req = ((ServletRequestWrapper)r).getRequest();
if (req instanceof MultipartRequestWrapper)
MultipartRequestWrapper request = (MultipartRequestWrapper)req;
byte[] photo = (byte[])request.getFiles().get(foto);
if (photo != null)
try
BufferedImage original = ImageIO.read(new ByteArrayInputStream(photo));
if (original == null) // not an image?
return;
BufferedImage scaled = new BufferedImage(128, 160, BufferedImage.TYPE_INT_RGB);
Graphics g = (Graphics2D)scaled.getGraphics();
g.drawImage(original,0,0,128,160,null);
g.dispose();
ByteArrayOutputStream out = new ByteArrayOutputStream(4096);
ImageIO.write(scaled, "jpg", out);
photo = out.toByteArray();
catch (IOException ex)
FacesContext.getCurrentInstance().getExternalContext().log(ex.toString());
return;
Imagenes imagenes = new Imagenes();
imagenes.setIdCentro(idCentro);
imagenes.setIdImagenes(persona.getIdImagen());
imagenes.setImagen(photo);
try
ImagenesDAO.save(imagenes);
catch (Exception ex)
FacesContext.getCurrentInstance().getExternalContext().log(ex.toString());
return;
putImage(imagenes.getImagen());
public String clear()
if (client != null)
client.setIdAbonado(0);
// must be mapped in faces-config.xml
return "clear";
public void save(ActionEvent e)
try
if (persona.getIdPersona() == 0)
abonado.setIdCentro(idCentro);
persona.setIdCentro(idCentro);
Connection con = DatasourceFactory.getConnection();
try
con.setAutoCommit(false);
PersonaDAO.create(con, persona);
abonado.setIdAbonado(persona.getIdPersona()); // idPersona == idAbonado is autoGenerated by database
AbonadoDAO.create(con, abonado);
con.commit();
catch(SQLException ex)
con.rollback();
persona.setIdPersona(0);
FacesContext.getCurrentInstance().getExternalContext().log(ex.toString());
finally { con.close(); }
// notify all about client change
if (client != null)
client.setIdAbonado(persona.getIdPersona());
else
Connection con = DatasourceFactory.getConnection();
try
con.setAutoCommit(false);
PersonaDAO.save(con, persona);
AbonadoDAO.save(con, abonado);
con.commit();
catch(SQLException ex)
con.rollback();
FacesContext.getCurrentInstance().getExternalContext().log(ex.toString());
finally { con.close(); }
catch (Exception ex)
FacesContext.getCurrentInstance().getExternalContext().log(ex.toString());
direcciones.save(e);
private String putImage(byte[] image)
String name;
HttpSession ses = (HttpSession)FacesContext.getCurrentInstance().getExternalContext().getSession(false);
if (ses != null)
name = "photo_" + String.valueOf(idCentro) + "_" + String.valueOf(persona.getIdPersona()) + ".jpg";
HashMap map = (HashMap)ses.getAttribute("ImageMap");
if (map == null)
map = new HashMap();
ses.setAttribute("ImageMap", map);
map.put(name, image);
else
name = null;
return name;
public void update(Observable o, Object arg)
if (o instanceof CurrentClient)
CurrentClient bean = (CurrentClient)o;
setIdAbonado(bean.getIdAbonado());
Cheers,
D.
P.S. I live in Spain so in Spanish it's foto :-) Sometimes I got crazy coz neither Spanish nor English are my native languages...
More... in MultipartRequestWrapper you can easy remove
public Object getAttribute(String name) method. It's my intention to map messages to request properties for easy access (like check if message exists to change style of some textfield in case of error). Do you know the better way???