Lame Concurrency Question

Question

I am seriously thread retarded. I can always get my threaded code to work without
any problems but that doesnt mean I have a clue about what is going on.
What is the best way to code the following common functionality:
class Runner implement Runnable{
public void run(){
while(run.booleanValue() == true){
do something();
Thread.sleep(some time);
public void stopRunning(){
run = new Boolean(false);
Boolean run = new Boolean(true);
}Do you just make stopRunning() synchronized?
Or do you lock on the "run" object?
If so, do you have to use a "synchronized(run)" block in both methods?
If you synchronize on an object should you use "synchronized(object)" every
place the object is used?
public void run(){
while(true){
synchronized(run){
if(run.booleanValue() == false){
break;
do something();
Thread.sleep(some time);
public void stopRunning(){
synchronized(run){
run = new Boolean(false);
}(By the way, ive never done the above. I usually just make stopRunning() synchronized.)

Answer 1

TuringPest wrote:
ignore my concurrency ignorance, lol, but i thought that whenever you had one
thread changing the values of something in another thread it had to be synchronized -
even if its a primitive?Yes. Or the variable has to be volatile. But, as already discussed, you don't need the running flag here.
while (!Thread.interrupted()) {
  doStuff();
  try {
    Thread.sleep(millis);
  catch (InterruptedException exc) {
    log it?
    Thread.currentThread().interrupt();
}