Logic Abap

Question

Please correct the logic on this
TABLES : RSREQICODS.
DATA: SUBRC LIKE SY-SUBRC,
      RETURNCODE(1) TYPE C,
      count.
Types: BEGIN OF WT_RSREQICODS,
        TABNAME LIKE RSREQICODS-TABNAME,
        RNR LIKE RSREQICODS-RNR,
      END OF WT_RSREQICODS.
DATA: IT_RSREQICODS TYPE TABLE OF WT_RSREQICODS,
      WA type table of WT_RSREQICODS.
SELECTION-SCREEN: BEGIN OF BLOCK B01 WITH FRAME TITLE TEXT-001.
SELECT-OPTIONS: S_TAB FOR RSREQICODS-TABNAME.
PARAMETERS: P_NBDAY(3) TYPE N DEFAULT 8.
SELECTION-SCREEN: END OF BLOCK B01,
                  SKIP,
                  BEGIN OF BLOCK B02 WITH FRAME TITLE TEXT-002.
PARAMETERS: P_TEST RADIOBUTTON GROUP G1,
P_REEL RADIOBUTTON GROUP G1.
SELECTION-SCREEN: END OF BLOCK B02.
START-OF-SELECTION.
CLEAR IT_RSREQICODS.
REFRESH IT_RSREQICODS.
SELECT TABNAME INTO  TABLE IT_RSREQICODS FROM RSREQICODS
                       WHERE TYP = 'O'
                         AND TABNAME IN S_TAB
                    ORDER BY TABNAME.
LOOP AT IT_RSREQICODS into Wa .
   If count(WA-RNR) > 2.
   DELETE RSREQICODS from table WA  .
  ENDIF.
endloop.

Answer 1

HI Tamkris
FIrst change ur line of code to the following
DATA: IT_RSREQICODS TYPE <b>STANDARD</b> TABLE OF WT_RSREQICODS,
WA type WT_RSREQICODS.
<b>then ur select statement doesnot conform on the number of field declared in IT_RSREQICODS because it contains two fields</b>
<b>TABNAME LIKE RSREQICODS-TABNAME,
RNR LIKE RSREQICODS-RNR,</b>
<b>You only fetch TABNAME from RSREQICODS, TIP used indention to make ur code readable</b>
SELECT TABNAME
       <b>RNR      'ADD THIS Field</b>
      INTO TABLE IT_RSREQICODS
   FROM RSREQICODS
      WHERE TYP = 'O'
      AND TABNAME IN S_TAB
ORDER BY TABNAME.
<b>ADD the code to check if the select statement is successful</b>
IF SY-SUBRC = 0.
' place code here
ENDIF.
<b>'ADD DELETE DUPLICATE RECORDS HERE BEFORE PROCESSING THE LOOP</b>
LOOP AT IT_RSREQICODS into Wa .
If count(WA-RNR) > 2.
DELETE RSREQICODS from table WA .
ENDIF.
endloop.
<b>ADD REFRESH, CLEAR AND FREE to tabels for optimizationand Performance</b>
REFRESH IT_RSREQICODS.
CLEAR Wa.
FREE: IT_RSREQICODS,
      Wa.
Hope it helps You
Regards,
Chris
Message was edited by: christopher bautista