Logical error in this procedure

Question

Hi,
I have creted this procedure when i execute it,
procedure created successfully, but when i run the procedute then it gives this error
*ERROR at line 1:
ORA-00933: SQL command not properly ended
ORA-06512: at "POI_RELEASE.SPECIAL_YPOL", line 13
ORA-06512: at line 1
CREATE or REPLACE PROCEDURE SPECIAL_YPOL
(tablename IN VARCHAR2,
     fieldname IN VARCHAR2)
AUTHID CURRENT_USER
IS
BEGIN
EXECUTE IMMEDIATE 'Update '      
                    ||tableName
                    || ' set '
                    ||fieldname
                    ||' =REPLACE('     
                    ||fieldname     
               ||',CHR(38) || ''QUOT,'',CHR(39)) WHERE'
                    ||FIELDNAME
                    ||'LIKE ''%'' || CHR(38) || ''QUOT,''';
OMMIT;
END;
/

Answer 1

If this was ancient times, and you wrote this code to run on any of my databases, I would have handed your over to the SQL Inquisition for showing you the error of your ways.
This is exactly how NOT to write code in Oracle. This is exactly how to cause performance problems in Oracle. This is exactly how to trash and fragment the Oracle Shared Pool. This is exactly how to design code and applications that are fragile and generate weirdly non-wonderful runtime errors.
On the performance side... this is what I posted not even a week ago to show just how stupid this approach you're using is:
SQL> create table footab( n number );
Table created.
SQL> set timing on
SQL>
SQL> -- doing a 100,000 inserts using a bind variable
SQL> declare
2 sqlInsert varchar2(1000);
3 begin
4 sqlInsert := 'insert into footab( n ) values( :0 )';
5 for i in 1..100000
6 loop
7 execute immediate sqlInsert using i;
8 end loop;
9 end;
10 /
PL/SQL procedure successfully completed.
Elapsed: 00:00:04.91
SQL>
SQL> -- doing a 100,000 inserts without using a bind variable
SQL> declare
2 sqlInsert varchar2(1000);
3 begin
4 -- need to built a unique SQL for each insert
5 for i in 1..100000
6 loop
7 sqlInsert := 'insert into footab( n ) values( '||i||' )';
8 execute immediate sqlInsert;
9 end loop;
10 end;
11 /
PL/SQL procedure successfully completed.
Elapsed: 00:05:21.47
SQL>So.. you want to turn something that should run in a few seconds, to something that takes several minutes to run.
Great stuff!! Pardon me, but I think I will need yet another cup of coffee to see me through this morning's browsing of Oracle Forums..