Help me in debugging this procedure

Question

PROCEDURE p_main_dpn (
m_post IN OUT VARCHAR2,
m_company VARCHAR2,
m_user_group VARCHAR2,
m_user_id VARCHAR2,
m_choice VARCHAR2,
m_year VARCHAR2,
m_period VARCHAR2,
m_tot_count NUMBER,
g_asset_code VARCHAR2
IS
CURSOR c1 (m_last_day_of_period DATE)
IS
SELECT company, asset_code, asset_dept, capital_cost, current_wdv,
dpn_type, status, residual_val, dpn_prd, dpn_year, nl_intf,
asset_life, updated_wdv, dpn_date, comm_date
FROM fa_asset_reg
WHERE status = 'C'
AND company = m_company
AND asset_code =
NVL (g_asset_code, asset_code)
-- dpn before sale
AND updated_wdv > residual_val
AND TO_NUMBER (TO_CHAR (NVL (dpn_date, comm_date), 'yyyymmdd')) <
TO_NUMBER (TO_CHAR (m_last_day_of_period, 'yyyymmdd'))
ORDER BY asset_dept;
rc1 c1%ROWTYPE;
sl_value NUMBER (15, 2);
-- Used in Sraight Line Method Calculation
sl_dpn NUMBER (15, 2); -- Straight Line depreciation amount
rb_value NUMBER (15, 2);
-- Used in Reducing Balance Method Calculation
rb_dpn NUMBER (15, 2);
-- Reducing Balance depreciation amount
m_doc_ref VARCHAR2 (16); -- For generating new Doc-Ref
m_updated_wdv NUMBER (15, 2); -- Latest book value of the Asset
m_tot_dpn NUMBER (15, 2); -- Department-wise total depreciation
m_loop_count NUMBER; -- To check for First Loop
m_prev_dept VARCHAR2 (12);
m_next_dept VARCHAR2 (12);
period_last_day DATE; --*
m_period_days NUMBER; --*
m_dpn_days NUMBER; --* used for datewise DPN calculation
dpn_for_a_day NUMBER; --*
m_last_day DATE; --*
m_start_day DATE; --*
m_from_day DATE; --*
     Chk Number;
BEGIN
/* First Delete any Trial Depreciations Calculated */
DELETE FROM fa_temp_dpn
WHERE company = m_company;
Chk :=1;
BEGIN
/* This check is done to calculate dpn before sale for a particular asset*/
IF g_asset_code IS NULL
THEN
SELECT LAST_DAY (fdp), LAST_DAY (fdp) - fdp + 1, fdp
INTO m_last_day, m_period_days, m_start_day
FROM sm_calendar
WHERE company = m_company AND YEAR = m_year AND prd = m_period;
               DBMS_OUTPUT.PUT_LINE('m_last_day, m_period_days, m_start_day'||m_last_day||','|| m_period_days||','|| m_start_day);
ELSE
SELECT SYSDATE, LAST_DAY (fdp) - fdp + 1,
TRUNC (SYSDATE - fdp) + 1, fdp
INTO m_last_day, m_period_days,
m_dpn_days, m_start_day
FROM sm_calendar
WHERE company = m_company AND YEAR = m_year AND prd = m_period;
END IF;
EXCEPTION
WHEN NO_DATA_FOUND
THEN
m_post := 'System calendar not defined properly';
END;
--OPEN c1 (m_last_day);
FOR RC1 IN C1(m_last_day)
LOOP
     cHK := 0;
/*FETCH c1
INTO rc1;*/
          cHK := 0.1;
dbms_OUTPUT.PUT_LINE('ENtered the loop'||c1%rowcount||m_last_day);
EXIT WHEN c1%NOTFOUND or c1%rOWCOUNT = 0;ADDED BY ALOK
          cHK := 0.2;
m_loop_count := NVL (m_loop_count, 0) + 1;
          cHK := 0.3;
          DBMS_OUTPUT.PUT_LINE('m_loop_count '||m_loop_count );
-- No more depreciation for the Asset which has depreciated
-- upto the Residual Value!!
rb_dpn := NULL;
sl_dpn := NULL;
-- SLL or SL% METHOD
IF rc1.dpn_type = 'S' OR rc1.dpn_type = 'P'
THEN
-- Provision is given for adding already depreciated assets into the register.****
sl_value := NVL (rc1.current_wdv, NVL (rc1.capital_cost, 0));
DBMS_OUTPUT.put_line ('SL Value ' || sl_value);
IF rc1.dpn_type = 'S'
THEN -- SLL METHOD
sl_dpn := (sl_value - rc1.residual_val) / rc1.asset_life;
DBMS_OUTPUT.put_line
( 'sl_dpn := (SL_VALUE - rc1.residual_val)/rc1.asset_life'
|| sl_dpn
ELSIF rc1.dpn_type = 'P'
THEN -- SL% METHOD
sl_dpn :=
((sl_value - rc1.residual_val) * rc1.asset_life) / 100;
DBMS_OUTPUT.put_line
( 'sl_dpn := ((SL_VALUE - rc1.residual_val)*rc1.asset_life)/100'
|| sl_dpn
END IF;
-- Dpn Calculation for no. of days in the period.
dpn_for_a_day := sl_dpn / m_period_days;
               DBMS_OUTPUT.put_line('dpn_for_a_day '||dpn_for_a_day );
IF g_asset_code IS NULL
THEN
-- Get the no. of days from rc1.dpn_date to last_day of current period.
IF rc1.dpn_date = rc1.comm_date
THEN
-- Dpn calculation for the first time.
m_start_day := rc1.dpn_date;
                    DBMS_OUTPUT.put_line('m_start_day '||m_start_day);
END IF;
ELSE
IF TO_CHAR (m_start_day, 'MMYYYY') =
TO_CHAR (rc1.comm_date, 'MMYYYY')
               THEN
m_start_day := rc1.comm_date;
                    DBMS_OUTPUT.put_line('TO_CHAR (m_start_day, ''MMYYYY'')'||TO_CHAR (m_start_day, 'MMYYYY'));
ELSE
m_start_day := rc1.dpn_date + 1;
END IF;
END IF;
m_dpn_days := TRUNC (m_last_day - m_start_day) + 1;
DBMS_OUTPUT.put_line('m_dpn_days '||m_dpn_days);
-- Compare the days for which depreciation has to be calculated with the
-- no. of days in the period.
IF m_dpn_days > m_period_days
THEN
m_post :=
'Depreciation has not been done for a previous period.';
EXIT;
ELSE
-- Restore the DPN into same variable
sl_dpn := dpn_for_a_day * m_dpn_days;
               DBMS_OUTPUT.put_line('sl_dpn '||sl_dpn);
END IF;
Chk := 2;
-- Update the Current Value of this Asset(SL)
m_updated_wdv := rc1.updated_wdv - sl_dpn;
-- RBL OR RB% METHOD
ELSIF rc1.dpn_type = 'R' OR rc1.dpn_type = 'Q'
THEN
rb_value :=
NVL (rc1.updated_wdv,
NVL (rc1.current_wdv, NVL (rc1.capital_cost, 0))
Chk :=3;
IF rc1.dpn_type = 'R'
THEN
rb_dpn := (rb_value - rc1.residual_val) / rc1.asset_life;
ELSIF rc1.dpn_type = 'Q'
THEN
rb_dpn :=
((rb_value - rc1.residual_val) * rc1.asset_life) / 100;
END IF;
-- Dpn Calculation for no. of days in the period.
dpn_for_a_day := rb_dpn / m_period_days;
IF g_asset_code IS NULL
THEN
-- Get the no. of days from rc1.dpn_date to last_day of current period.
IF rc1.dpn_date = rc1.comm_date
THEN
-- Dpn calculation for the first time.
m_start_day := rc1.dpn_date;
END IF;
ELSE
IF TO_CHAR (m_start_day, 'MMYYYY') =
TO_CHAR (rc1.comm_date, 'MMYYYY')
THEN
m_start_day := rc1.comm_date;
ELSE
m_start_day := rc1.dpn_date + 1;
END IF;
END IF;
m_dpn_days := TRUNC (m_last_day - m_start_day) + 1;
-- Compare the days for which depreciation has to be calculated with the
-- no. of days in the period.
IF m_dpn_days > m_period_days
THEN
m_post :=
'Depreciation has not been done for previous a period.';
EXIT;
ELSE
-- Restore the DPN into same variable
rb_dpn := dpn_for_a_day * m_dpn_days;
END IF;
Chk := 4;
-- Update the Current Value of this Asset(RB)
m_updated_wdv :=
NVL (rc1.updated_wdv,
NVL (rc1.current_wdv, NVL (rc1.capital_cost, 0))
- rb_dpn;
END IF;
-- Check if the depreciation reduces the current book value
-- to make it lesser than Residual Value
IF m_updated_wdv < rc1.residual_val
THEN
IF rc1.dpn_type = 'S' OR rc1.dpn_type = 'P'
THEN
sl_dpn := sl_dpn - (rc1.residual_val - m_updated_wdv);
ELSIF rc1.dpn_type = 'R' OR rc1.dpn_type = 'Q'
THEN
rb_dpn := rb_dpn - (rc1.residual_val - m_updated_wdv);
END IF;
m_updated_wdv := rc1.residual_val;
END IF;
m_from_day := m_start_day;
Chk := 5;
-- Check whether Department-wise AJ consolidation required.
IF m_choice = 'Y'
THEN /* Department-wise AJ required */
INSERT INTO fa_stats
(company, asset_code, closing_wdv, YEAR,
prd, dpn_per_day, no_of_days, from_date,
TO_DATE, asset_dpn, usr_id, TIMESTAMP
VALUES (rc1.company, rc1.asset_code, m_updated_wdv, m_year,
m_period, dpn_for_a_day, m_dpn_days, m_from_day,
m_last_day, NVL (rb_dpn, sl_dpn), m_user_id, SYSDATE
               DBMS_OUTPUT.PUT_LINE('Inserted the value into Fa_Stats');
UPDATE fa_asset_reg
SET dpn_year = m_year,
dpn_prd = m_period,
dpn_date = m_last_day,
updated_wdv = m_updated_wdv
WHERE company = m_company AND asset_code = rc1.asset_code;
                         DBMS_OUTPUT.PUT_LINE(SQL%ROWCOUNT||'Rows Updated the value into Fa_Asset_Reg');
m_next_dept := rc1.asset_dept;
IF m_next_dept = NVL (m_prev_dept, m_next_dept)
THEN /* same department */
m_tot_dpn := NVL (m_tot_dpn, 0)
+ NVL (NVL (sl_dpn, rb_dpn), 0);
m_prev_dept := m_next_dept;
IF m_loop_count = m_tot_count
THEN /* last record */
p_create_dpn_jv (m_company,
m_user_group,
m_user_id,
m_post,
m_period,
m_year,
m_last_day,
'XXXXXX',
m_next_dept,
m_choice,
m_tot_dpn,
m_updated_wdv,
rc1.nl_intf,
NULL,
NULL,
NULL,
NULL
--m_updated_wdv & m_last_day not applicable if CHOICE = 'Y'
EXIT;
END IF;
END IF;
IF m_next_dept <> m_prev_dept
THEN
p_create_dpn_jv (m_company,
m_user_group,
m_user_id,
m_post,
m_period,
m_year,
m_last_day,
'XXXXXX',
m_prev_dept,
m_choice,
m_tot_dpn,
m_updated_wdv,
rc1.nl_intf,
NULL,
NULL,
NULL,
NULL
--m_updated_wdv & m_last_day not applicable if CHOICE = 'Y'
m_tot_dpn := NVL (NVL (sl_dpn, rb_dpn), 0);
m_prev_dept := m_next_dept;
IF m_loop_count = m_tot_count
THEN /* last record */
p_create_dpn_jv (m_company,
m_user_group,
m_user_id,
m_post,
m_period,
m_year,
m_last_day,
'XXXXXX',
m_next_dept,
m_choice,
m_tot_dpn,
m_updated_wdv,
rc1.nl_intf,
NULL,
NULL,
NULL,
NULL
--m_updated_wdv & m_last_day not applicable if CHOICE = 'Y'
EXIT;
END IF;
END IF;
ELSE
          Chk := 5.1; /* choice is N */
p_create_dpn_jv (rc1.company,
m_user_group,
m_user_id,
m_post,
m_period,
m_year,
m_last_day,
rc1.asset_code,
rc1.asset_dept,
m_choice,
NVL (sl_dpn, rb_dpn),
m_updated_wdv,
rc1.nl_intf,
dpn_for_a_day,
m_dpn_days,
m_from_day,
m_last_day
                                   Chk := 5.2;
END IF;
END LOOP;
-- CLOSE c1;
     cHK := 7;
EXCEPTION
WHEN NO_DATA_FOUND
THEN
m_post := 'Processing failed !! No data found ';
WHEN DUP_VAL_ON_INDEX
THEN
m_post :=
'Posting failed . Duplicate value exists for ' || rc1.asset_code;
ROLLBACK;
          wHEN otHERS THEN
          m_post := 'ERROR oCCURED'||SQLERRM||chk||' '||m_loop_count;
          rOLLBACK;
END;
Here when i'm executing this procedure, I'm getting a error ORA-01002- Fetch Out of Sequence.
Plz help me.
Thanks in advance.
Regards,ALok

Answer 1

Earlier it was having the simple loop.But i changed
it to the FOr loop cursor,
Cos, For loop is more efficient in fetching the
data.Only from 10g on and when you don't use BULK fetch
in your cursor loop.
As for your other question: I meant of course the ROLLBACK
in the procedure p_create_dpn_jv.
Again, if you can't remove that ROLLBACK there, you could
bulk fetch all the records of your main cursor and process them
afterwards in a FOR/FORALL loop, if the result fits into the available
memory of course.
C.