Login Hook stops working once I've changed the username

Question

Hello. I need to change the usernames for a number of local accounts on a 10.5.8 mac. The accounts were set up by someone else who is no longer working at this education insitution and hasn't left any documentation. Currently when each user logs on, a script runs that does the following
#!/usr/bin/env bash
# iMac logon script
# get our user
theUser=$1
# get the users home directory
#theUsersHome=$HOME
# Copy the dock plist file for the user
cp /Library/Scripts/GHS/Docks/${theUser}/com.apple.dock.plist /Users/${theUser}/Library/Preferences
# Create a ScreenCaptures folder on the desktop, give it permissions and redirect the screen captures
# Unlock the Desktop folder first in case it is locked
sudo chflags nouchg /Users/${theUser}/Desktop
mkdir /Users/${theUser}/Desktop/ScreenCaptures
sudo chown ${theUser}:staff /Users/${theUser}/Desktop/ScreenCaptures
defaults write com.apple.screencapture location /Users/${theUser}/Desktop/ScreenCaptures
# Create a VideoWork folder on the Desktop and give it permissions
# Unlock the Desktop folder first in case it is locked
sudo chflags nouchg /Users/${theUser}/Desktop
# Remove the old Video Work folder in case it exists
rmdir /Users/${theUser}/Desktop/Video\ Work
mkdir /Users/${theUser}/Desktop/VideoWork
sudo chown ${theUser}:staff /Users/${theUser}/Desktop/VideoWork
# Lock the Desktop, Documents, Movies, Music and Pictures folders
sudo chflags uchg /Users/${theUser}/Desktop
sudo chflags uchg /Users/${theUser}/Documents
sudo chflags uchg /Users/${theUser}/Movies
sudo chflags uchg /Users/${theUser}/Music
sudo chflags uchg /Users/${theUser}/Pictures
However, once I change the users account name, the script doesn't seem to run correctly as the screen captures fail due to not having write permission in the intended destination.
I rename the UserName the ShortName, the HomeDirectory and the folder here /Library/Scripts/GHS/Docks/UserName
The idea is, once I've updated this one mac with all the new accounts, I will then duplicate the image across all the others that we have
I'm very new to this and I'm not sure how much of this works
Thank you very much for any help and I apologise if I've missed out any essential information.

Answer 1

Hi John, not certain I can help here, but...
Add a user from the OS X command line, works with Leopard!
http://osxdaily.com/2007/10/29/how-to-add-a-user-from-the-os-x-command-line-work s-with-leopard/
More...
http://osxdaily.com/2011/05/20/change-short-name-user-mac-os-x/
http://www.macworld.com/article/132693/2008/03/changeshortusername.html