Memory leak in a function registered using set_restore_function()

Question

I experience a problem with memory leak caused by the following function:
void RestorePhonemesSet(PhonemesSetStructType &phonemesSet, const void *src) {
char p = (char ) src;
memcpy(&phonemesSet.len, p, sizeof (int));
p += sizeof (int);
memcpy(&phonemesSet.whichFile, p, sizeof (int));
p += sizeof (int);
memcpy(&phonemesSet.whichPosition, p, sizeof (int));
p += sizeof (int);
phonemesSet.phonemes = (int *)malloc(sizeof(int)*phonemesSet.len);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ here the problematic code
memcpy(phonemesSet.phonemes, p, sizeof (int) * phonemesSet.len);
This function is registered using a following call: DbstlElemTraits<PhonemesSetStructType>::instance()->set_restore_function(RestorePhonemesSet);
The culprit it the malloc memory allocation. If I leave out the malloc the program crashes. If I free the phonemeSet.phonemes memory segment at the end of the restore function I lost data, and if I use the malloc there is a large memory leak while reading every record from the database.
What should I do to prevent the memory leak?
Regards,
markur
Edited by: 904259 on 2011-12-24 05:42

Answer 1

the solution is using the memory allocated for p, no need to allocate new memory space for the variable: the problematic line should look like .phonemes = (int *)p;
the memcpy function in the following line is thus superfluous.
Edited by: 904259 on 2011-12-24 05:43