Merge for bulk data

Question

Hi all,
I want to insert bulk data from external table to database ..Program compiled successfully bt after executing the data doesn't insert to database..plz help me..
External table:-bck_hotel
HOTEL_CODE     NUMBER
HOTEL_NAME     VARCHAR2(100)
HOTEL_TYPE     VARCHAR2(100)
HOTEL_ADDRESS VARCHAR2(100)
HOTEL_NUMBER     NUMBER
HOTEL_FACILITY     VARCHAR2(100)
HOTEL1     VARCHAR2(100)
LATITUDE     NUMBER
LONGITUDE     NUMBER
Database table:-hotel
HOTEL_CODE     NUMBER
HOTEL_NAME     VARCHAR2(100)
HOTEL_TYPE     VARCHAR2(100)
HOTEL_ADDRESS     VARCHAR2(100)
HOTEL_NUMBER     NUMBER
HOTEL_FACILITY      VARCHAR2(100)
Code:
CURSOR cur_hotels IS
SELECT hotel_code, hotel_name, hotel_type, hotel_address, hotel_number,
hotel_facility
FROM bck_hotels;
BEGIN
OPEN cur_hotels;
LOOP
FETCH cur_hotels BULK COLLECT
INTO v_hotel_code, v_hotel_name, v_hotel_type, v_hotel_address, v_hotel_number, v_hotel_facility LIMIT 1000;
FORALL i IN 1 .. v_hotel_code.COUNT MERGE INTO hotels tgt USING (
SELECT v_hotel_code(i) AS hotel_code, v_hotel_name(i) AS hotel_name,
v_hotel_type(i) AS hotel_type,
v_hotel_address(i) AS hotel_address,
v_hotel_number(i) AS hotel_number,
v_hotel_facility(i) AS hotel_facility
FROM dual) src
ON (src.hotel_code = tgt.hotel_code)
WHEN MATCHED THEN UPDATE SET
tgt.hotel_name = src.hotel_name, tgt.hotel_type = src.hotel_type, tgt.hotel_address = src.hotel_address, tgt.hotel_number = src.hotel_number, tgt.hotel_facility = src.hotel_facility
WHEN NOT MATCHED THEN
INSERT(tgt.hotel_code, tgt.hotel_name, tgt.hotel_type, tgt.hotel_address, tgt.hotel_number, tgt.hotel_facility)
VALUES(src.hotel_code, src.hotel_name, src.hotel_type, src.hotel_address, src.hotel_number, src.hotel_facility);

Answer 1

Hello,
I wonder why are you using Bulk Collect, when the same can be accomplished by a simple Merge statement.
Below can help:
MERGE INTO hotels tgt USING
(SELECT hotel_code,
  hotel_name,
  hotel_type,
  hotel_address,
  hotel_number,
  hotel_facility
FROM bck_hotel
) src ON (src.hotel_code = tgt.hotel_code)
WHEN MATCHED THEN
  UPDATE
  SET tgt.hotel_name   = src.hotel_name,
    tgt.hotel_type     = src.hotel_type,
    tgt.hotel_address  = src.hotel_address,
    tgt.hotel_number   = src.hotel_number,
    tgt.hotel_facility = src.hotel_facility WHEN NOT MATCHED THEN
  INSERT
      tgt.hotel_code,
      tgt.hotel_name,
      tgt.hotel_type,
      tgt.hotel_address,
      tgt.hotel_number,
      tgt.hotel_facility
    VALUES
      src.hotel_code,
      src.hotel_name,
      src.hotel_type,
      src.hotel_address,
      src.hotel_number,
      src.hotel_facility
    );Is it not true?
Regards,
P.