Minimizing the code in trigger

Question

Hi All,
I've written the following code...as per the requirement... But my manager is said to minimize the code..
But i couldn't find where can i minimize it...
Could you give me suggestion on this...
Create or replace trigger G_TMO_QPP_SDY_FSDO_UAR
after update of QPP_CNTRY_ID
on TMO_QPP_SDY_T
referencing new as new old as old
for each row
WHEN (OLD.QPP_CNTRY_ID<>NEW.QPP_CNTRY_ID)
declare
voutdat varchar2(1);
vmodtp varchar2(1);
vsdy_id TMO_QPP_SDY_T.SDY_ID%type;
BEGIN
vsdy_id:=:new.SDY_ID;
INSERT into T_FSDO_D(
REPL_ID,       
DK_SDY,        
DK_DAT,        
DK_ADT,        
MOD_TMST,
MOD_TP)
SELECT
NULL,      
TMO_QPP_SDO_T.SDY_ID,        
TMO_QPP_SDO_T.DAT_ID,        
0,        
SYSDATE,
'I'
FROM TMO_QPP_SDO_T
WHERE TMO_QPP_SDO_T.SDY_ID=vsdy_id;
vsdy_id:=:OLD.SDY_ID;
INSERT into T_FSDO_D(
REPL_ID,       
DK_SDY,        
DK_DAT,        
DK_ADT,        
MOD_TMST,
MOD_TP)
SELECT
NULL,      
TMO_QPP_SDO_T.SDY_ID,        
TMO_QPP_SDO_T.DAT_ID,        
0,        
SYSDATE,
'D'
FROM TMO_QPP_SDO_T
WHERE TMO_QPP_SDO_T.SDY_ID=vsdy_id;
exception
when others then
dbms_output.put_line('error');
end;thanks

Answer 1

Jyothsna,
Very disappointed with your posting -> :(
Where is the indentation of your coding? Who will do it for you? You are not a novice here. You know how to post neatly in order to get quick response. :(
Hope you will maintain this from next time.
Now, Coming to your question ->
Trigger code can be reduced in two ways. Make modular approach and put al your code inside any function or procedure. That will be a secure approach, too.
And, speaking to your current coding - i think your boss might look like this ->
create or replace trigger G_TMO_QPP_SDY_FSDO_UAR
after update of QPP_CNTRY_ID on TMO_QPP_SDY_T
referencing new as new old as old
for each row WHEN (:OLD.QPP_CNTRY_ID {noformat}<{noformat}{noformat}>{noformat} :NEW.QPP_CNTRY_ID)
declare
  voutdat varchar2(1);
  vmodtp varchar2(1);
BEGIN
  INSERT into T_FSDO_D(
                        REPL_ID,
                        DK_SDY,
                        DK_DAT,
                        DK_ADT,
                        MOD_TMST,
                        MOD_TP
   SELECT REPL_ID,
          DK_SDY,
          DK_DAT,
          DK_ADT,
          MOD_TMST,
          MOD_TP
   FROM (
          SELECT NULL AS REPL_ID,
                  TMO_QPP_SDO_T.SDY_ID AS DK_SDY,
                  TMO_QPP_SDO_T.DAT_ID AS DK_DAT,
                  0 AS DK_ADT,
                  SYSDATE AS MOD_TMST,
                  'I' AS MOD_TP
          FROM TMO_QPP_SDO_T
          WHERE TMO_QPP_SDO_T.SDY_ID IN (:new.SDY_ID,:OLD.SDY_ID)
exception
  when others then
    dbms_output.put_line('error');
end;N.B.: Not Tested...
Regards.
Satyaki De.
As suggested by Williams
Edited by: Satyaki_De on Sep 28, 2008 1:15 AM