Need Help With a Stored Procedure

Question

Help With a Stored Procedure
Hi everyone.
I am quite new relative to creating stored procedures, so I anticipate that whatever help I could get here would be very much helpful.
Anyway, here is my case:
I have a table where I need to update some fields with values coming from other tables. The other tables, let us just name as tblRef1, tblRef2 and tblRef3. For clarity, let us name tblToUpdate as my table to update. tblToUpdate has the following fields.
PlanID
EmployeeIndicator
UpdatedBy
CreatedBy
tblRef1, tblRef2 and tblRef3 has the following fields:
UserName
EmpIndicator
UserID
In my stored procedure, I need to perform the following:
1. Check each row in the tblToUpdate table. Get the CreatedBy value and compare the same to the UserName and UserID field of tblRef1. If no value exists in tblRef1, I then proceed to check if the value exists in the same fields in tblRef2 and tblRef3.
2. If the value is found, then I would update the EmployeeIndicator field in tblToUpdate with the value found on either tblRef1, tblRef2 or tblRef3.
I am having some trouble writing the stored procedure to accomplish this. So far, I have written is the following:
CREATE OR REPLACE PROCEDURE Proc_Upd IS v_rec NUMBER;
v_plan_no tblToUpdate.PLANID%TYPE;
v_ref_ind tblToUpdate.EMPLOYEEINDICATOR%TYPE;
v_update_user tblToUpdate.UPDATEDBY%TYPE;
v_created_by tblToUpdate.CREATEDBY%TYPE;
v_correct_ref_ind tblToUpdate.EMPLOYEEIDICATOR%TYPE;
CURSOR cur_plan IS SELECT PlanID, EmployeeIndicator, UPPER(UpdatedBy), UPPER(CreatedBy) FROM tblToUpdate;
BEGIN
Open cur_plan;
     LOOP
     FETCH cur_plan INTO v_plan_no, v_ref_ind, v_update_user, v_created_by;
          EXIT WHEN cur_plan%NOTFOUND;
          BEGIN
          -- Check if v_created_by has value.
               IF v_created_by IS NOT NULL THEN
               -- Get the EmpIndicator from the tblRef1, tblRef2 or tblRef3 based on CreatedBy
               SELECT UPPER(EmpIndicator)
                    INTO v_correct_ref_ind
                    FROM tblRef1
                    WHERE UPPER(USERNAME) = v_created_by
                    OR UPPER(USERID) = v_created_by;
                    IF v_correct_ref_ind IS NOT NULL THEN
                    -- Update the Reference Indicator Field in the table TRP_BUSPLAN_HDR_T.
                         UPDATE TRP_BUSPLAN_HDR_T SET ref_ind = v_correct_ref_ind WHERE plan_no = v_plan_no;
                    ELSIF
                    -- Check the Other tables here????
                    END IF;
               ELSIF v_created_by IS NULL THEN
               -- Get the EmpIndicator based on the UpdatedBy
                    SELECT UPPER(EmpIndicator)
                    INTO v_correct_ref_ind
                    FROM tblRef1
                    WHERE UPPER(USERNAME) = v_update_user
                    OR UPPER(USERID) = v_created_by;
                    IF v_correct_ref_ind IS NOT NULL THEN
                    -- Update the Reference Indicator Field in the table TRP_BUSPLAN_HDR_T.
                         UPDATE TRP_BUSPLAN_HDR_T SET ref_ind = v_correct_ref_ind WHERE plan_no = v_plan_no;
                    ELSIF
                    -- Check the Other tables here????
                    END IF;
               END IF;
          END;
     END LOOP;
     CLOSE cur_plan;
     COMMIT;
END
Please take note that the values in the column tblToUpdate.UpdatedBy or tblToUpdate.CreatedBy could match either the UserName or the UserID of the table tblRef1, tblRef2, or tblRef3.
Kindly provide more insight. When I try to execute the procedure above, I get a DATA NOT FOUND ERROR.
Thanks.

Answer 1

Ah, ok; I got the updates the wrong way round then.
BluShadow's single update sounds like what you need then.
I also suggest you read this AskTom link to help you see why you should choose to write DML statements before choosing to write cursor + loops.
In general, when you're being asked to update / insert / delete rows into a table or several tables, your first reaction should be: "Can I do this in SQL?" If you can, then putting it into a stored procedure is usually just a case of putting the sql statement inside the procedure header/footers - can't really get much more simple than that! *{;-)