Need output format for trigger program

Question

Hello everyone ;
https://forums.oracle.com/message/11078921#11078921
Above link is reference . It's also my own thread related to   this discussion.
SQL> desc user_login
Name                                                              Null?    Type
USERNAME                                                                VARCHAR2(30)
ISDBA                                                                          VARCHAR2(20)
LOGIN_DATE                                                              DATE
LOGIN_TIME                                                               VARCHAR2(15)
LOGOUT_TIME                                                          VARCHAR2(15)
EXTERNAL_NAME                                                     VARCHAR2(30)
AUTHENTICATION_TYPE                                          VARCHAR2(30)
HOST                                                                          VARCHAR2(20)
Program for tracing user logon/logoff  details
SQL> create or replace  trigger  tri_logon
AFTER LOGON ON DATABASE
BEGIN
INSERT  INTO  user_login (username, isdba, external_name,
authentication_type, HOST,  login_date , login_time)
SELECT SYS_CONTEXT ('USERENV', 'SESSION_USER'),
SYS_CONTEXT ('USERENV', 'ISDBA'),
  SYS_CONTEXT ('USERENV', 'EXTERNAL_NAME'),
  SYS_CONTEXT ('USERENV', 'AUTHENTICATION_TYPE'),
  SYS_CONTEXT ('USERENV', 'host'),
  SYSDATE, TO_CHAR (SYSDATE, 'HH24:MI:SS') FROM DUAL;
   END;
Trigger  created.
SQL> create or replace trigger tri_audit1
2 BEFORE LOGOFf on database
3   BEGIN
4 insert into user_login (username, logout_time)
5 (select user, TO_CHAR(SYSDATE, 'HH24:MM:SS') from dual);
6 end;
6 /
Trigger  created.
I got following output . Here i cannot insert logout_time on logout_time column.
logout_time is dispalyed seperately please see last two output values  (CST01 ,  02:06:16)   and  user_name also displayed twice.  (don't  need )
USERNAME   ISDBA   LOGIN_DAT   LOGIN_TIME   LOGOUT_TIME   EXTERNAL_NAME AUTHENTICATION_TYPE  HOST
CST01           FALSE     21-JUN-13          02:06:11                                            oracle                            DATABASE                            linuxserver     CST01    02:06:16
I want output following  below  format
Expecting output  logout time  on  LOGOUT_TIME column  and   user_name  should be displayed once.
USERNAME ISDBA LOGIN_DAT LOGIN_TIME   LOGOUT_TIME   EXTERNAL_NAME  AUTHENTICATION_TYPE HOST
CST01      FALSE       20-JUN-13       13:06:34                                            oracle                       DATABASE                   LINUXSERVER
thanks in advance ..

Answer 1

8f953842-815b-4d8c-833d-f2a3dd51e602 wrote:
Hello everyone ;
https://forums.oracle.com/message/11078921#11078921
Above link is reference . It's also my own thread related to   this discussion.
SQL> desc user_login
Name                                                              Null?    Type
USERNAME                                                                VARCHAR2(30)
ISDBA                                                                          VARCHAR2(20)
LOGIN_DATE                                                              DATE
LOGIN_TIME                                                               VARCHAR2(15)
LOGOUT_TIME                                                          VARCHAR2(15)
EXTERNAL_NAME                                                     VARCHAR2(30)
AUTHENTICATION_TYPE                                          VARCHAR2(30)
HOST                                                                          VARCHAR2(20)
In addition to the myriad of other issues pointed out in this and your other -- essentially duplicate -- thread, why do you have separate columns for login_date and login_time?  A DATE datatype (which you have correctly defined for LOGIN_DATE carries both date and time elements.  You only need one column -- LOGIN_TIME -- populated with SYSDATE when the user logs in.  And LOGOUT_TIME should also be a DATE, populated with SYSDATE.  This alone points to several design flaws.
1) DATE and TIME are not seperate elements.  In this application, the concept of 'time' has no meaning apart from the date, and a DATE data type, by definition, stores both date and time.
2) keeping either date OR time in a varchar is asking for trouble.  Comparisons and math simply do not work as you expect.
3) You don't have a date for LOGOUT, but suppose the user logs on at 2330 on Tuesday, and logs out at 0030 on Wednesday..
Properly, you should only have two columns for this .. LOGON_TIME, defined as a DATE, and LOGOUT_TIME, defined as a date.
Or possibly separate rows, one for LOGON and one for LOGOUT, both with a sessid to join them.
Or better, and as I mentioned earlier, don't reinvent what AUDIT already does.  How much time have you spent on this (how much of your employers MONEY has been spent) when you could have solved the whole thing in 5 minutes with AUDIT?
Program for tracing user logon/logoff  details
SQL> create or replace  trigger  tri_logon
AFTER LOGON ON DATABASE
BEGIN
INSERT  INTO  user_login (username, isdba, external_name,
authentication_type, HOST,  login_date , login_time)
SELECT SYS_CONTEXT ('USERENV', 'SESSION_USER'),
SYS_CONTEXT ('USERENV', 'ISDBA'),
  SYS_CONTEXT ('USERENV', 'EXTERNAL_NAME'),
  SYS_CONTEXT ('USERENV', 'AUTHENTICATION_TYPE'),
  SYS_CONTEXT ('USERENV', 'host'),
  SYSDATE, TO_CHAR (SYSDATE, 'HH24:MI:SS') FROM DUAL;
   END;
Trigger  created.
SQL> create or replace trigger tri_audit1
2 BEFORE LOGOFf on database
3   BEGIN
4 insert into user_login (username, logout_time)
5 (select user, TO_CHAR(SYSDATE, 'HH24:MM:SS') from dual);
6 end;
6 /
Trigger  created.
I got following output . Here i cannot insert logout_time on logout_time column.
logout_time is dispalyed seperately please see last two output values  (CST01 ,  02:06:16)   and  user_name also displayed twice.  (don't  need )
USERNAME   ISDBA   LOGIN_DAT   LOGIN_TIME   LOGOUT_TIME   EXTERNAL_NAME AUTHENTICATION_TYPE  HOST
CST01           FALSE     21-JUN-13          02:06:11                                            oracle                            DATABASE                            linuxserver     CST01    02:06:16
I want output following  below  format
Expecting output  logout time  on  LOGOUT_TIME column  and   user_name  should be displayed once.
USERNAME ISDBA LOGIN_DAT LOGIN_TIME   LOGOUT_TIME   EXTERNAL_NAME  AUTHENTICATION_TYPE HOST
CST01      FALSE       20-JUN-13       13:06:34                                            oracle                       DATABASE                   LINUXSERVER
thanks in advance ..