Need to improve Performance of select...endselect query

Question

Hi experts,
I have a query in my program like below with inner join of 3 tables.
In my program used select....endselect   again inside this select...endselect statements used..
While executing in production taking lot of time to fetch records. Can anyone suggest to improve performance of below query urgently...
Greatly appreciated ur help...
SELECT MVKEDWERK MVKEMATNR MVKEVKORG MVKEVTWEG MARA~MATNR
       MARAMTART ZM012MTART ZM012ZLIND ZM012ZPRICEREF
INTO (MVKE-DWERK , MVKE-MATNR , MVKE-VKORG , MVKE-VTWEG , MARA-MATNR
     , MARA-MTART , ZM012-MTART , ZM012-ZLIND , ZM012-ZPRICEREF )
FROM ( MVKE
       INNER JOIN MARA
       ON MARAMATNR = MVKEMATNR
       INNER JOIN ZM012
       ON ZM012MTART = MARAMTART )
       WHERE MVKE~DWERK IN SP$00004
         AND MVKE~MATNR IN SP$00001
         AND MVKE~VKORG IN SP$00002
         AND MVKE~VTWEG IN SP$00003
         AND MARA~MTART IN SP$00005
         AND ZM012~ZLIND IN SP$00006
         AND ZM012~ZPRICEREF IN SP$00007.
  %DBACC = %DBACC - 1.
  IF %DBACC = 0.
    STOP.
  ENDIF.
  CHECK SP$00005.
  CHECK SP$00004.
  CHECK SP$00001.
  CHECK SP$00002.
  CHECK SP$00003.
  CHECK SP$00006.
  CHECK SP$00007.
  clear Check_PR00.
  select * from A004
  where kappl = 'V'
  and kschl = 'PR00'
  and vkorg = mvke-vkorg
  and vtweg = mvke-vtweg
  and matnr = mvke-matnr
  and DATAB le sy-datum
  and DATBI ge sy-datum.
  if sy-subrc = 0.
  select * from konp
  where knumh = a004-knumh.
  if sy-subrc = 0.
  Check_PR00 = konp-kbetr.
  endif.
  endselect.
  endif.
  endselect.
  CHECK SP$00008.
  clear Check_ZPR0.
  select * from A004
  where kappl = 'V'
  and kschl = 'ZPR0'
  and vkorg = mvke-vkorg
  and vtweg = mvke-vtweg
  and matnr = mvke-matnr
  and DATAB le sy-datum
  and DATBI ge sy-datum.
  if sy-subrc = 0.
  select * from konp
  where knumh = a004-knumh.
  if sy-subrc = 0.
  Check_ZPR0 = konp-kbetr.
  endif.
  endselect.
  endif.
  endselect.
  CHECK SP$00009.
  clear ZFMP.
  select * from A004
  where kappl = 'V'
  and kschl = 'ZFMP'
  and vkorg = mvke-vkorg
  and vtweg = mvke-vtweg
  and matnr = mvke-matnr
  and DATAB le sy-datum
  and DATBI ge sy-datum.
  if sy-subrc = 0.
  select * from konp
  where knumh = a004-knumh.
  if sy-subrc = 0.
  ZFMP = konp-kbetr.
  endif.
  endselect.
  endif.
  endselect.
  CHECK SP$00010.
  clear mastercost.
  clear ZDCF.
  select * from A004
  where kappl = 'V'
  and kschl = 'ZDCF'
  and vkorg = mvke-vkorg
  and vtweg = mvke-vtweg
  and matnr = mvke-matnr
  and DATAB le sy-datum
  and DATBI ge sy-datum.
  if sy-subrc = 0.
  select * from konp
  where knumh = a004-knumh.
  if sy-subrc = 0.
  ZDCF = konp-kbetr.
  endif.
  endselect.
  endif.
  endselect.
  CHECK SP$00011.
  clear masterprice.
  clear Standardcost.
  select * from mbew
  where matnr = mvke-matnr
  and bwkey = mvke-dwerk.
  Standardcost = mbew-stprs.
  mastercost = MBEW-BWPRH.
  masterprice = mBEW-BWPH1.
  endselect.
  ADD 1 TO %COUNT-MVKE.
  %LINR-MVKE = '01'.
  EXTRACT %FG01.
  %EXT-MVKE01 = 'X'.
    EXTRACT %FGWRMVKE01.
ENDSELECT.
best rgds..
hari..

Answer 1

Hi there.
Some advices:
- why going to MVKE first and MARA then? You will find n rows in MVKE for 1 matnr, and then go n times to the same record in MARA. Do the oposite, i.e, go first to MARA (1 time per matnr) and then to MVKE.
- avoid select *, you will save time.
- use trace or measure performance in tcodes ST05 and SM30.
-  replace:
select * from konp
where knumh = a004-knumh.
if sy-subrc = 0.
Check_ZPR0 = konp-kbetr.
endif.
endselect.
by
select * from konp
where knumh = a004-knumh.
Check_ZPR0 = konp-kbetr.
exit.
endselect.    
Here, if I understood, you only need to atribute kbetr value to Check_ZPR0 if selecting anything (don't need the IF because if enters in select, subrc always equal to 0, and also don't need to do it several times from same a004-knumh - reason for the EXIT.
Hope this helps.
Regards.
Valter Oliveira.
Edited by: Valter Oliveira on Jun 5, 2008 3:16 PM