Number of rows returned by the resultset is wrong

Question

Hi All,
I have pasted the code i used for JDBC. The problem is the number of rows returned by the resultset is 5 times that of the original data. Is something wrong with my code. Can anyone pls point out the mistake I have done if any.
    public ArrayList dataBreakup(String team, int monthNo, int year) {         String sqlDataBreakup = "";         Connection con1 = null;         Statement stmt = null;         ResultSet rs = null;         ArrayList data = new ArrayList();         int noRows = 0;         Calendar cal = Calendar.getInstance();         Calendar cal2 = new GregorianCalendar(cal.get(Calendar.YEAR), monthNo, 1);         int days = cal2.getActualMaximum(cal2.DAY_OF_MONTH);         String start_date = "01-Jan-" + year;         String end_date = days + "-" + monthName[cal2.get(Calendar.MONTH)] + "-" + cal2.get(cal2.YEAR);         System.out.println("START: " + start_date);         System.out.println("END: " + end_date);         databaseConnection dbObject = new databaseConnection();         try {             con1 = dbObject.GetConnection();             stmt = con1.createStatement(ResultSet.TYPE_SCROLL_INSENSITIVE,ResultSet.CONCUR_UPDATABLE);             sqlDataBreakup = "Select * from EXPENSE_STORE WHERE " +                     "team='" + team + "'AND category != 'Pending PO''s' AND ACCOUNTING_DATE " +                     "BETWEEN to_date('" + start_date + "') AND to_date('" + end_date + "')";             rs = stmt.executeQuery(sqlDataBreakup);                         ResultSetMetaData rsmd = rs.getMetaData();             int numColumns = rsmd.getColumnCount();             data.add(numColumns);             for (int i = 1; i < numColumns + 1; i++) {                 data.add(rsmd.getColumnName(i));             }                        while (rs.next()) {                                noRows++;                 for (int i = 1; i < numColumns + 1; i++) {                     switch (rsmd.getColumnType(i)) {                         case java.sql.Types.NUMERIC:                             data.add(rs.getFloat(i));                             break;                         case java.sql.Types.DATE:                             data.add(rs.getDate(i));                             break;                         default:                             data.add(rs.getString(i));                             break;                     }                                    }                     }             data.add(1, noRows);             rs.close();         } catch (SQLException SQLe) {             System.out.println("DumpData() : SQL Exception" + SQLe.getMessage());             SQLe.printStackTrace();         } catch (Exception e) {             System.out.println("DumpData() : Other Exception");             e.printStackTrace();         } finally {             dbObject.CloseConnection(con1);         }         return data;     }
Thanks
Cheers N...

Answer 1

Only thing i can say is
try the following
replace your function by this one and tell us the console output of the same
public ArrayList dataBreakup(String team, int monthNo, int year) {
        String sqlDataBreakup = "";
        Connection con = null;          
        ArrayList data = new ArrayList();
        int noRows = 0;
        Calendar cal = Calendar.getInstance();
        Calendar cal2 = new GregorianCalendar(cal.get(Calendar.YEAR), monthNo, 1);
        int days = cal2.getActualMaximum(cal2.DAY_OF_MONTH);
        String start_date = "01-Jan-" + year;
        String end_date = days + "-" + monthName[cal2.get(Calendar.MONTH)] + "-" + cal2.get(cal2.YEAR);
        System.out.println("START: " + start_date);
        System.out.println("END: " + end_date);
        System.out.println("START: " + start_date);
        System.out.println("END: " + end_date);
        databaseConnection dbObject = new databaseConnection();
        try {
            con = dbObject.GetConnection();          
            sqlDataBreakup = "Select * from EXPENSE_STORE WHERE " +
                    "team = '"+team+"' AND category != 'Pending PO''s' AND ACCOUNTING_DATE " +
                    "BETWEEN to_date('"+start_date+"') AND to_date('"+end_date+"')";
               System.out.println("-----------sql starts---------------");
               System.out.println(sqlDataBreakup);
               System.out.println("-----------sql ends---------------");
            PreparedStatement pstmt = con.prepareStatement(sqlDataBreakup);
               pstmt.setString(1, team);
            pstmt.setString(2, start_date);
            pstmt.setString(3, end_date);
            ResultSet rs = pstmt.executeQuery();
            ResultSetMetaData rsmd = rs.getMetaData();
            int numColumns = rsmd.getColumnCount();
            data.add(numColumns);
            for (int i = 1; i < numColumns + 1; i++) {
                data.add(rsmd.getColumnName(i));
            while (rs.next()) {
                noRows++;
                for (int i = 1; i < numColumns + 1; i++) {
                    switch (rsmd.getColumnType(i)) {
                        case java.sql.Types.NUMERIC:
                            data.add(rs.getFloat(i));
                            break;
                        case java.sql.Types.DATE:
                            data.add(rs.getDate(i));
                            break;
                        default:
                            data.add(rs.getString(i));
                            break;
            //data.add(1, noRows);
               System.out.println("no of Rows : " +noRows );
        } catch (SQLException SQLe) {
            System.out.println("DumpData() : SQL Exception" + SQLe.getMessage());
            SQLe.printStackTrace();
        } catch (Exception e) {
            System.out.println("DumpData() : Other Exception");
            e.printStackTrace();
        } finally {
            dbObject.CloseConnection(con);
        return data;
    }and try running the sql printed on the screen in your db and then let us know the result.
in this code i have removed some of your code in order to simplify the problem.