ODP problem Calling Stored proc..

Question

First here is the code (C#) Errror I am getting is
(Either wrong number of arguments or right at the execute command it just hangs..)
OracleConnection oOracleConn = new OracleConnection();
oOracleConn.ConnectionString = "Data Source=Config;USER ID=xyz;PASSWORD=xyz;";
oOracleConn.Open();
OracleCommand myCmd = new OracleCommand("Config.BillerVersionIns", oOracleConn);
myCmd.CommandType = CommandType.StoredProcedure;
OracleTimeStamp x = OracleTimeStamp.GetSysDate();
myCmd.BindByName = true;
myCmd.Parameters.Add("p_BillerID ", OracleDbType.Int32).Value = 409;
myCmd.Parameters.Add("p_BillerName", OracleDbType.Varchar2).Value = "TestBiller";
myCmd.Parameters.Add("p_BillerActiveInd", OracleDbType.Char).Value = "Y";
myCmd.Parameters.Add("p_ParentBillerID", OracleDbType.Int32);//( this can be null)
myCmd.Parameters.Add("p_PaymentAcceptanceInd", OracleDbType.Char).Value = "Y";
myCmd.Parameters.Add("p_VersionDesc", OracleDbType.Varchar2).Value = "Version Number 4";
myCmd.Parameters.Add("p_EffectiveDate", OracleDbType.TimeStamp).Value = x;
myCmd.Parameters.Add("o_BillerID", OracleDbType.Int32).Direction = ParameterDirection.Output;
myCmd.Parameters.Add("o_VersionID", OracleDbType.Int32).Direction = ParameterDirection.Output;
myCmd.Parameters.Add("o_VersionDesc", OracleDbType.Varchar2).Direction = ParameterDirection.Output;
myCmd.Parameters[3].Status = OracleParameterStatus.NullInsert;
OracleDataReader myreader = myCmd.ExecuteReader();
And now the Stored proc in Oracle 10g...( pls note I have tested this stored proc from Oracle client tool its getting executed perfectly only problem is when I try to call it from code above it throws error)..
Var v1 Number
Var v2 Number
Var v3 Varchar2(50)
Exec Config.BillerVersionIns (409,'Midwest Energy1', 'Y', NULL, 'Y', 'Version Number 1', SYSDATE, :v1, :v2, :v3)
Print v1
Print v2
Print v3
Oracle Procs
TEXT
Procedure BillerVersionIns
( p_BillerID In Number,
p_BillerName In Varchar2,
p_BillerActiveInd In Char,
p_ParentBillerID In Number,
p_PaymentAcceptanceInd In Char,
p_VersionDesc In Varchar2,
p_EffectiveDate In TimeStamp,
o_BillerID out NOCOPY Number,
o_VersionID out Number,
o_VersionDesc out NOCOPY Varchar2
) Is
v_BillerID Number;
v_VersionID Number;
v_EffectiveDate TimeStamp;
v_SysDate TimeStamp;
Begin
v_EffectiveDate := p_EffectiveDate;
v_EffectiveDate := SYSDATE;
v_SysDate := SYSDATE;
If (p_BillerID Is Null) Then
v_VersionID := 1;
Insert Into Config.Biller(BillerID, BillerName, BillerActiveInd, ParentBillerID, PaymentAcceptanceInd, CreatedDate, UpdatedDate)
Values (Config.Biller_Seq.NextVal, p_BillerName, p_BillerActiveInd, p_ParentBillerID, p_PaymentAcceptanceInd, v_SysDate, v_SysDate);
Select BillerID Into v_BillerID From Config.Biller Where BillerName = p_BillerName;
Insert Into Config.BillerVersion (BillerID, VersionID, BillerName, VersionDesc, BillerVersionActiveInd, EffectiveDate, RetireDate, ParentBillerID, PaymentAcceptanceInd, CreatedDate)
Values (v_BillerID, v_VersionID, p_BillerName, p_VersionDesc, 'Y', v_EffectiveDate, NULL, p_ParentBillerID, p_PaymentAcceptanceInd, v_SysDate);
o_BillerID := v_BillerID;
o_VersionID := v_VersionID;
Select VersionDesc Into o_VersionDesc From Config.BillerVersion Where BillerID = v_BillerID And VersionID = v_VersionID;
Else
Select Max(VersionID) Into v_VersionID From Config.BillerVersion Where BillerID = p_BillerID;
Update Config.BillerVersion
Set BillerVersionActiveInd = 'N',
RetireDate = v_SysDate
Where BillerID = p_BillerID
And VersionID = v_VersionID;
v_VersionID := v_VersionID + 1;
Update Config.Biller
Set BillerName = p_BillerName,
BillerActiveInd = p_BillerActiveInd,
ParentBillerID = p_ParentBillerID,
PaymentAcceptanceInd = p_PaymentAcceptanceInd,
UpdatedDate = v_SysDate
Where BillerID = p_BillerID;
Insert Into Config.BillerVersion (BillerID, VersionID, BillerName, VersionDesc, BillerVersionActiveInd, EffectiveDate, RetireDate, ParentBillerID, PaymentAcceptanceInd, CreatedDate)
Values (p_BillerID, v_VersionID, p_BillerName, p_VersionDesc, 'Y', v_EffectiveDate, NULL, p_ParentBillerID, p_PaymentAcceptanceInd, v_SysDate);
o_BillerID := p_BillerID;
o_VersionID := v_VersionID;
Select VersionDesc Into o_VersionDesc From Config.BillerVersion Where BillerID = p_BillerID And VersionID = v_VersionID;
End If;
End;
69 rows selected
TEXT
Message was edited by:
user588434

Answer 1

One additional point I would make on the Spring integration side is that you should probably cast to ClientSession below rather than SpringClientSession. Or, in this case, even to oracle.toplink.publicinterface.Session.
java.sql.Connection conn = ((ClientSession) session).getAccessor().getConnection();
Or probably even better would be to refactor the code so that you can execute a DatabaseQuery with a stored procedure Callable. Although I know you already said that you inherited this code from somewhere else, so maybe there's nothing you can do.
But in general, I try to do whatever I can to avoid having to extract the Connection from a TopLink Session.