Optimization of CURSORS/SQL inside PL/SQL

Question

Hi Friends
I have a query regarding optimization working with CURSOR FOR loops and embedded SQL stmts inside PL/SQL procedure.
I have a code where i am using a Cursor holding multiple rows and than LOOP over it to process individual rows. I am using nested Cursor FOR Loops too.
I want to know what optimizations are possible in this kind of scenario, where i ahve to process each row of a Cursor.
Kindly Guide....
Thanks and Regards

Answer 1

Hello Friends.....
Thanks so very much for your reply!!
I am attaching my code for your reference. Will also go through the links u have provided.
Kindly, suggest what can be done in this kind of scenario:
CREATE OR REPLACE procedure insert_sfdc_account
as
--DECLARE
CURSOR C1 IS
SELECT customer_code, name1, name2, name3, name4, phone_number, fax, web_address, industry_sector, customer_profile, customer_type,
address, city, postal_code, country_key, zzcust_type, vat_code
FROM load_cust_general
WHERE account_group = 'ZSIT';
v_cust_cur c1%ROWTYPE;
-- type sales_tab is table of load_cust_sales_area%rowtype;
v_sales_area load_cust_sales_area%ROWTYPE;
-- v_sales_area sales_tab;
     v_salesorg varchar2(10);
     v_sales_district varchar2(10);
     v_salesoff varchar2(10);
     v_custgrp varchar2(10);
     v_salesgrp varchar2(10);
v_type varchar2(20);
v_nature varchar2(10);
v_partner_code varchar2(10);
v_parent_cust varchar2(20);
v_credit_blk varchar2(20);
BEGIN
open c1;
loop
fetch c1 into v_cust_cur;
exit when c1%NOTFOUND;
for i in (SELECT customer_code, salesorg from load_cust_partner
where customer_code = v_cust_cur.customer_code ) LOOP
dbms_output.put_line(v_cust_cur.customer_code );
-- BEGIN
                    SELECT partner_code into v_partner_code from load_cust_partner
where customer_code = i.customer_code and salesorg = i.salesorg and partner_function = 'Z1';
dbms_output.put_line(v_partner_code||i.customer_code);
SELECT salesorg, sales_district, salesoff, salesgrp, custgrp INTO v_salesorg, v_sales_district, v_salesoff, v_salesgrp, v_custgrp FROM load_cust_sales_area
          WHERE customer_code = i.customer_code and salesorg = i.salesorg;
               dbms_output.put_line(v_salesorg||i.salesorg);
               dbms_output.put_line('Customer_Code : '|| i.customer_code);
               dbms_output.put_line('SalesOrg : '|| i.salesorg);
     /*     SELECT parent_customer INTO v_parent_cust
from load_cust_hierarchy
WHERE customer_code = '1234'
and salesorg = 'abc'
and hierarchy_type = 'G'; */
                    SELECT parent_customer
INTO v_parent_cust
FROM load_cust_hierarchy
WHERE lower(customer_code) = lower(trim(i.customer_code))
AND lower(salesorg) = lower(trim(i.salesorg))
AND hierarchy_type = 'G';
               /*     SELECT parent_customer INTO v_parent_cust from load_cust_hierarchy
WHERE customer_code = i.customer_code and salesorg = i.salesorg and hierarchy_type = 'G';
dbms_output.put_line(v_parent_cust);
                         dbms_output.put_line('Successfully Executed SQL st. Error is somewhere else');
exception
WHEN NO_DATA_FOUND THEN
v_parent_cust := 'ACHINSUMAN';*/
     --          END;
                    SELECT credit_block INTO v_credit_blk from load_cust_company_cod
          WHERE customer_code = i.customer_code;
dbms_output.put_line(v_credit_blk);
for j in (SELECT account_group, customer_type from load_cust_general
where customer_code IN (select customer_code from load_cust_partner
                              where partner_code = i.customer_code and salesorg = i.salesorg and partner_function = 'ZS'))
                                                  LOOP
-- exit when j%NOTFOUND;
     dbms_output.put_line(j.account_group);
if (j.account_group = 'ZDIS') THEN
v_type := 'DISAC';
          v_nature := '06';
     --     EXIT ;
else
v_type := 'SPACC';
v_nature := '01';
-- ********************* Part to be extended**************
END IF;
dbms_output.put_line(v_type||' '||v_nature);
END LOOP;
INSERT INTO sfdc_account
          (SAP_ACCOUNT_ID__C, NAME, TYPE, RECORDTYPEID, PARENTID, PHONE, FAX, WEBSITE, OWNERID, MARKETING_DOMAIN__C,
INDUSTRIAL_SECTOR__C, ABC_CLASSIFICATION__C, NAME_1__C, NAME_2__C, NAME_3__C, NAME_4__C, PAYMENT_STATUS__C,
CUSTOMER_GROUP__C, ADDRESS_STREET__C, CITY__C, POSTAL_CODE__C, COUNTRY__C, SALES_OFFICE__C, SALESORG__C,
SALESDISTRICT__C, SALESGROUP__C, NATURE__C, VATCODE__C)
VALUES((i.customer_code||i.salesorg), (v_cust_cur.Name1||' '||v_cust_cur.name2), ' ', v_type, v_parent_cust,
v_cust_cur.phone_number, v_cust_cur.fax, v_cust_cur.web_address, v_partner_code, SUBSTR(v_cust_cur.industry_sector,1,2),
v_cust_cur.industry_sector, v_cust_cur.customer_profile, v_cust_cur.name1, v_cust_cur.name2, v_cust_cur.name3,
v_cust_cur.name4, v_credit_blk, v_custgrp, v_cust_cur.address, v_cust_cur.city, v_cust_cur.postal_code,
v_cust_cur.country_key, v_salesoff, v_salesorg, v_sales_district,
v_salesgrp, v_nature, v_cust_cur.vat_code);
end loop;
end loop;
CLOSE c1;
-- Delete data from Load Table
-- EXECUTE IMMEDIATE 'TRUNCATE TABLE load_cust_general';
/* truncate table load_cust_partner;
truncate table load_cust_hierarhy;
truncate table load_cust_sales_area;
truncate table load_cust_company_cod;
commit;
exception
WHEN NO_DATA_FOUND THEN
raise_application_error( -20001, substr( sqlerrm, 1, 150 ) );
when others then
raise_application_error( -20001, substr( sqlerrm, 1, 150 ) );
END;
Thanks and Regards