Oracle insert speed (92k records)

Question

I am inserting 92,000 records into oracle (nightly job)
I am just trying to speed things up (is my first C#/Oracle app)
at the moment, I have 2 ways of inserting the records
using Oracle.DataAccess.Client;
using Oracle.DataAccess.Types;
1) command.CommandText = "INSERT into B2BE (ledger,sku,descr,Price,PriceT,PriceP,PricePS,PricePX,unitom,Brandname ) VALUES ('" + myLedger + "','" + mySku + "' ,'" + myDescrip + "', " + myRetail + "," + myTrade + " , " + myPP + " , " + myPPS + "," + myPPX + " ,'" + myUnitom + "' ,'" + myBrandname + "' )";
command.ExecuteNonQuery();
2) command.ArrayBindCount = maxArray;
command.CommandText = "INSERT into B2BE (ledger,sku,descr,Price,PriceT,PriceP,PricePS,PricePX,unitom,Brandname ) VALUES (:p_Ledger , :p_Sku , :p_Descrip , :p_Retail , :p_Trade , :p_PP , :p_PPS , :p_PPX , :p_Unitom , :p_Brandname )";
OracleParameter prm2 = new OracleParameter("p_Ledger", OracleDbType.Varchar2);
prm2.Direction = ParameterDirection.Input;
prm2.Value = a_myLedger;
prm2.Size = maxArray;
command.Parameters.Add(prm2);
etc etc...
Both ways work fine, but I was trying to work out a way of speeding up the process
at the moment, option 1) takes 10 mins to process 92k records doing an insert for each record, (in a loop) and option 2) takes 7 mins to process 2 blocks of 60k records then 32k records
are these speeds acceptable? or am I doing things totally wrong
(application attacks old foxpro tables using codebase, & process's them all to get ready to push into oracle that process takes all of 45 seconds)... yes codebase is insane.
Thanks
-Chris

Answer 1

Hi,
I'm not sure what, but I'd say "you're doing something wrong", unless you have Network issues or something perhaps.
Inserting 60,000 records, using the following code, takes 3 seconds on my system (the database is local however, so I have minimal network delay). How long does this code take on your system?
I'm using 10.2.0.2.20 ODP, 10.2.0.3 client/database for what it's worth.
Cheers
Greg
TABLE
======
create table bulkttab(col0 number,col1 varchar2(4000), col2 varchar2(4000), col3 varchar2(4000),
col4 varchar2(4000),col5 varchar2(4000),col6 varchar2(4000),col7 varchar2(4000),
col8 varchar2(4000),col9 varchar2(4000));
CODE
=========
private static void arraybind()
string connectStr = "User Id=scott;Password=tiger;Data Source=orcl";
int size = 60000;
int[] myArrayofNums = new int[size];
string[] myArrayofV2s = new string[size];
for (int i = 0; i < size; i++)
myArrayofNums[i] = i;
myArrayofV2s[i] = "abcdefghijklmnopqrstuvwxyz";
OracleConnection connection = new OracleConnection(connectStr);
OracleCommand command = new OracleCommand("insert into bulkttab values(:0,:1,:2,:3,:4,:5,:6,:7,:8,:9)", connection);
command.ArrayBindCount = size;
OracleParameter numParam = new OracleParameter("param2", OracleDbType.Int32);
numParam.Direction = ParameterDirection.Input;
numParam.Value = myArrayofNums;
command.Parameters.Add(numParam);
for (int i = 1; i < 10; i++)
OracleParameter v2param = new OracleParameter("", OracleDbType.Varchar2);
v2param.Direction = ParameterDirection.Input;
v2param.Value = myArrayofV2s;
command.Parameters.Add(v2param);
connection.Open();
DateTime start = DateTime.Now;
command.ExecuteNonQuery();
DateTime stop = DateTime.Now;
Console.WriteLine("{0} records inserted in {1} seconds", size,(stop - start));
connection.Close();
command.Dispose();
connection.Dispose();
OUTPUT
========
60000 records inserted in 00:00:02.2656250 seconds