Package for payroll what is the problem in this..

Question

Specification
CREATE OR REPLACE package PKG_PAYROLL as
type cur is ref cursor;
procedure pro_getstate(p_cid number,p_cur out cur);
procedure pro_getcountry(p_cur out cur);
procedure pro_getdesignation(p_cur out cur);
procedure pro_getdepartment(p_cur out cur);
procedure pro_getempid (empid out varchar);
procedure pro_saveregistrationinfo
empid varchar,
deptid number,
desigid number,
fname varchar,
mname varchar,
lname varchar,
gender varchar,
dob date,
dno varchar,
loc varchar,
area varchar,
country number,
state number,
district varchar,
city varchar,
zipcode number,
stdno number,
phno number,
ccode number,
mobileno number,
email varchar
end;
Body
CREATE OR REPLACE package body pkg_payroll as
procedure pro_getstate(p_cid number,p_cur out cur) is
begin
open p_cur for
select sid,sname from tb_state where cid = p_cid;
end pro_getstate;
procedure pro_getcountry(p_cur out cur) is
begin
open p_cur for
select cid,cname from tb_country;
end pro_getcountry;
procedure pro_getdesignation(p_cur out cur) is
begin
open p_cur for
select did,initcap(dname) as dname from TB_DESIG_IT;
end pro_getdesignation;
procedure pro_getdepartment(p_cur out cur) is
begin
open p_cur for
select did,initcap(dname) as dname from TB_DEPARTMENT_IT;
end pro_getdepartment;
procedure pro_getempid (empid out varchar) is
v_getempid varchar2(20);
v_year varchar2(20);
v_empnum number;
v_check number;
begin
select count(*) into v_check from tb_payroll_registration;
if(v_check = 0)
     empid:='10KG1';
else
     select empid into v_getempid from tb_payroll_registration where rownum = (select max(rownum) from tb_payroll_registration) order by empid;
     select to_char(sysdate,'yy') into v_year from sys.dual;
     v_empnum := to_number(substr(v_getempid,5));
     v_empnum := v_empnum+1;
     empid:=v_year||'KG'||v_empnum;
end if;
end;
procedure pro_saveregistrationinfo
empid varchar,
deptid number,
desigid number,
fname varchar,
mname varchar,
lname varchar,
gender varchar,
dob date,
dno varchar,
loc varchar,
area varchar,
country number,
state number,
district varchar,
city varchar,
zipcode number,
stdno number,
phno number,
ccode number,
mobileno number,
email varchar
) is
begin
insert into tb_payroll_registration values(
empid,
deptid,
desigid,
fname,
mname,
lname,
gender,
dob,
dno,
loc,
area,
country,
state,
district,
city,
zipcode,
stdno,
phno,
ccode,
mobileno,
email);
commit;
end pro_saveregistrationinfo;
end;

Answer 1

Not a (Java) question. Locking.