Package interpeting function call as variable call

Question

When I try to compile my package the compiler mistakes the function calls in this collection for variables.:
type dayonelist IS TABLE OF NUMBER;
dayone dayonelist := dayonelist(wkdaysminusone(), sadaysminusone(), sudaysminusone());
I get this error message:
Error(244,35): PLS-00306: wrong number or types of arguments in call to 'WKDAYSMINUSONE'
Anyone know how I can correct this?

Answer 1

rthakur-
I'm a beginner at this and looking for help and not smart comments. I may not have your experience but I have a little more courtesy than you. Here's the package code:
CREATE OR REPLACE
package accessreports is
vc_FirstofMonth DATE;
vc_CurrentPick date;
PROCEDURE PICK_DATE
(p_first_of_month IN DATE);
PROCEDURE EXEC_REPORTS(p_first_of_month IN DATE);
PROCEDURE PRODUCTIVITY_INSERT
(p_first_of_month IN DATE);
PROCEDURE AVERAGE_BOARDINGS
(p_first_of_month IN DATE);
end accessreports;
CREATE OR REPLACE PACKAGE BODY accessreports IS
/*Below are all functions that provide variables for calulations and WHERE
clauses. All functions are at the top of the package for visibility to all procs and
convenience*/
FUNCTION curpick RETURN DATE IS p_current_pick DATE;
BEGIN
SELECT MAX(pick) AS
pick
INTO p_current_pick
FROM bus_picks;
RETURN p_current_pick;
END curpick;
FUNCTION wkdays(p_first_of_month IN DATE)
RETURN NUMBER IS p_wk NUMBER;
BEGIN
vc_FirstofMonth := p_first_of_month;
SELECT COUNT(service_date) AS
wk
INTO p_wk
FROM
(SELECT DISTINCT service_date
FROM bus_daily_rides
WHERE to_char(service_date,'MM-YYYY') = to_char(vc_firstofmonth,'MM-YYYY')
AND day_type = 'W')
RETURN p_wk;
END wkdays;
FUNCTION sadays (p_first_of_month IN DATE)
RETURN NUMBER IS p_sa NUMBER;
BEGIN
vc_FirstofMonth := p_first_of_month;
SELECT COUNT(service_date) AS
sa
INTO p_sa
FROM
(SELECT DISTINCT service_date
FROM bus_daily_rides
WHERE to_char(service_date, 'MM-YYYY') = to_char(vc_firstofmonth, 'MM-YYYY')
AND day_type = 'A')
RETURN p_sa;
END sadays;
FUNCTION sudays(p_first_of_month IN DATE)
RETURN NUMBER IS p_su NUMBER;
BEGIN
vc_FirstofMonth := p_first_of_month;
SELECT COUNT(service_date) AS
su
INTO p_su
FROM
(SELECT DISTINCT service_date
FROM bus_daily_rides
WHERE to_char(service_date, 'MM-YYYY') = to_char(vc_firstofmonth, 'MM-YYYY')
AND day_type = 'U')
RETURN p_su;
END sudays;
FUNCTION wkdaysminusone(p_first_of_month IN DATE)
RETURN NUMBER IS p_wkone NUMBER;
BEGIN
vc_FirstofMonth := p_first_of_month;
SELECT COUNT(*) AS
wkone
INTO p_wkone
FROM
(SELECT DISTINCT to_char(add_months(service_date, -12), 'dd-mm-yyyy')
FROM bus_daily_rides
WHERE to_char(service_date, 'mm-yyyy') = to_char(vc_firstofmonth, 'MM-YYYY')
AND day_type = 'W')
RETURN p_wkone;
END wkdaysminusone;
FUNCTION sadaysminusone(p_first_of_month IN DATE)
RETURN NUMBER IS p_saone NUMBER;
BEGIN
vc_FirstofMonth := p_first_of_month;
SELECT COUNT(*) AS
saone
INTO p_saone
FROM
(SELECT DISTINCT to_char(add_months(service_date, -24), 'dd-mm-yyyy')
FROM bus_daily_rides
WHERE to_char(service_date, 'mm-yyyy') = to_char(vc_firstofmonth, 'MM-YYYY')
AND day_type = 'A')
RETURN p_saone;
END sadaysminusone;
FUNCTION sudaysminusone(p_first_of_month IN DATE)
RETURN NUMBER IS p_suone NUMBER;
BEGIN
vc_FirstofMonth := p_first_of_month;
SELECT COUNT(*) AS
suone
INTO p_suone
FROM
(SELECT DISTINCT to_char(add_months(service_date, -12), 'dd-mm-yyyy')
FROM bus_daily_rides
WHERE to_char(service_date, 'mm-yyyy') = to_char(vc_firstofmonth, 'MM-YYYY')
AND day_type = 'U')
RETURN p_suone;
END sudaysminusone;
FUNCTION wkdaysminustwo(p_first_of_month IN DATE)
RETURN NUMBER IS p_wktwo NUMBER;
BEGIN
vc_FirstofMonth := p_first_of_month;
SELECT COUNT(*) AS
wktwo
INTO p_wktwo
FROM
(SELECT DISTINCT to_char(add_months(service_date, -24), 'dd-mm-yyyy')
FROM bus_daily_rides
WHERE to_char(service_date, 'mm-yyyy') = to_char(vc_FirstofMonth, 'MM-YYYY')
AND day_type = 'W')
RETURN p_wktwo;
END wkdaysminustwo;
FUNCTION sadaysminustwo(p_first_of_month IN DATE)
RETURN NUMBER IS p_satwo NUMBER;
BEGIN
vc_FirstofMonth := p_first_of_month;
SELECT COUNT(*) AS
satwo
INTO p_satwo
FROM
(SELECT DISTINCT to_char(add_months(service_date, -24), 'dd-mm-yyyy')
FROM bus_daily_rides
WHERE to_char(service_date, 'mm-yyyy') = to_char(vc_firstofmonth, 'MM-YYYY')
AND day_type = 'A')
RETURN p_satwo;
END sadaysminustwo;
FUNCTION sudaysminustwo(p_first_of_month IN DATE)
RETURN NUMBER IS p_sutwo NUMBER;
BEGIN
vc_FirstofMonth := p_first_of_month;
SELECT COUNT(*) AS
sutwo
INTO p_sutwo
FROM
(SELECT DISTINCT to_char(add_months(service_date, -24), 'dd-mm-yyyy')
FROM bus_daily_rides
WHERE to_char(service_date, 'mm-yyyy') = to_char(vc_firstofmonth, 'MM-YYYY')
AND day_type = 'U')
RETURN p_sutwo;
END sudaysminustwo;
/*PICK_DATE determines if the report being provided takes place during a pick month.*/
PROCEDURE pick_date(p_first_of_month IN DATE)
AS
BEGIN
vc_firstofmonth := p_first_of_month;
vc_currentpick := curpick();
IF to_char(vc_firstofmonth, 'MM-YYYY') <> to_char(vc_currentpick, 'MM-YYYY') THEN
accessreports.exec_reports(p_first_of_month);
ELSE
NULL;
/*This procedure being built*/
END IF;
END pick_date;
/*EXEC_REPORTS executes the procs below it with two input vars.*/
PROCEDURE exec_reports(p_first_of_month IN DATE)
IS
BEGIN
accessreports.productivity_insert(p_first_of_month);
accessreports.average_boardings(p_first_of_month);
END;
/*Last two procs use dynamic SQL to rotate through the different day types and
pls_integer of days for each day type.*/
PROCEDURE productivity_insert(p_first_of_month DATE)
AS
TYPE daylist IS TABLE OF VARCHAR2(1);
DAYS daylist := daylist('W', 'A', 'U');
TYPE countlist IS TABLE OF NUMBER;
counts countlist := countlist(wkdays(), sadays(), sudays());
BEGIN
FOR i IN 1 .. 3 LOOP
EXECUTE IMMEDIATE 'INSERT INTO RFC_BUS' || DAYS(i) || 'PRODUCTIVITY(ROUTE,PPPH)
SELECT a.route, ((sr05 / sy05)/' || counts(i) || ') AS "RATIO"
FROM (SELECT route,
SUM (DECODE (TO_CHAR (pick, "MM-YYYY"),
to_char(vc_FirstofMonth, "MM-YYYY"), platform_hours, null)) AS sy05
FROM bus_platformhours
WHERE day_type =' || DAYS(i) || ' and platform_hours > 0
GROUP BY route) a,
(SELECT route,
SUM (DECODE (TO_CHAR (service_date, "mm-yyyy"),
to_char(vc_FirstofMonth, "MM-YYYY"), rides, null)) AS sr05
FROM bush_daily_rides
WHERE day_type = ' || DAYS(i) || 'GROUP BY route) b
WHERE a.route = b.route
ORDER BY a.route
VALUES(
p_route,
p_ratio
) USING days(i), counts(i)';
END LOOP;
END productivity_insert;
PROCEDURE average_boardings(p_first_of_month DATE)
AS
type daylist IS TABLE OF VARCHAR2(1);
DAYS daylist := daylist('W', 'A', 'U');
type countlist IS TABLE OF NUMBER;
counts countlist := countlist(wkdays(), sadays(), sudays());
type dayonelist IS TABLE OF NUMBER;
dayone dayonelist := dayonelist(wkdaysminusone(), sadaysminusone(), sudaysminusone());
type daytwolist IS TABLE OF NUMBER;
daytwo daytwolist := daytwolist(wkdaysminustwo(), sadaysminustwo(), sudaysminustwo());
BEGIN
vc_firstofmonth := p_first_of_month;
FOR i IN 1 .. 3 LOOP
EXECUTE IMMEDIATE 'INSERT INTO RFC' || DAYS(i) || 'BUSAVG_RIDES_AND_PROD(ROUTE, THIRD_YEAR, SECOND_YEAR, PRESENT_YEAR,
PER_DIFF_THIRDTOPRESENT, PER_DIFF_SECONDTOPRESENT, ROUTETWO, PASS_PLAT_HOUR)
select r.*,
t2.*
from (
select *
from (select route,
sum(y04)/' || counts(i) || ' y04,
sum(y05)/' || dayone(i) || ' y05,
sum(y06)/' || daytwo(i) || ' y06,
decode(sum(y04),0,0,(sum(y06)-sum(y04))/sum(y04)*100) Percent_difference_04to06,
decode(sum(y05),0,0,(sum(y06)-sum(y05))/sum(y05)*100) Percent_difference_05to06
from (select route,
     decode(to_char(service_date,"yy"),"04",Rides,0) y04,
decode(to_char(service_date,"yy"),"05",Rides,0) y05,
     decode(to_char(service_date,"yy"),"06",Rides,0) y06
from bus_daily_rides
where TO_CHAR(service_date, "YY") IN ("04","05", "06")
AND TO_CHAR(SERVICE_DATE,"MM")=TO_CHAR(vc_FirstofMonth, "MM")
AND day_type=' || DAYS(i) || '
group by route
WHERE ROWNUM > 0
) r,
' || DAYS(i) || '"_"Route_productivity t2
where t2.route = r.route
VALUES(p_route,
p_third_year,
p_second_year,
p_present_year,
p_thirdtopresent,
p_secondtopresent,
p_routetwo,
p_ppph) USING counts(i), days(i), daysone(i), daystwo(i)';
END LOOP;
END;
END accessreports;