Passing where and group by clause to cursor

Question

I am working on a procedure that builds a where clause and needs a group by clause to return the correct results. I am trying to pass both the where and group by variables into the cursor.
The variables are getting populated correctly, but when the cursor gets created, the variables are not in the cursor.
Here is the code I'm working with. It is a part of a package, but makes no calls to other parts of the package.
PROCEDURE createFollowUpTask_Exposure( psUppgkedjetyp IN tis.tial.uppgkedjetyp%TYPE default NULL,
psAlarmtyp IN tis.tial.alarmtyp%TYPE default NULL,
psSubtyp IN tis.tial.subtyp%TYPE default NULL,
pnDays IN NUMBER default NULL,
psKampkod IN tis.tiin.kampkod%TYPE default NULL,
psKatnr IN tis.tiin.katnr%TYPE default NULL,
psUtgava IN tis.tiin.utgava%TYPE default NULL,
psKatslag IN tis.tikg.katslag%TYPE default NULL,
psProdsyst IN tis.tikg.prodsyst%TYPE default NULL,
psUppgtyp IN tis.tiin.uppgtyp%TYPE default NULL,
psProdkod IN tis.tiin.prodkod%TYPE default NULL,
psStatus IN tis.tiin.status%TYPE default NULL
) AS
cTIAL tis.tial%ROWTYPE;
vLopnr tis.tial.lopnr%TYPE;
vSqlWhere VARCHAR2(4000);
vGroupBy VARCHAR2(1000) := ' tiin.kampkod, tiin.abnr, tiko.fordsalj';
cSelectCursor SYS_REFCURSOR;
vSqlSelect VARCHAR2(4000);
psDays VARCHAR2(50);
cRec T_TIAL_REC;
nCount number := 0;
CURSOR cSqlSelect( SqlWhere IN VARCHAR2, GroupBy IN VARCHAR2) IS
SELECT tiin.kampkod, tiin.abnr, tiko.fordsalj, MAX(tici.regdat) ALARMDATE
FROM tis.tiin
JOIN tis.tiko ON tiin.kampkod = tiko.kampkod AND tiin.abnr = tiko.abnr
JOIN core.tici ON tiin.kampkod = tici.kampkod AND tiin.abnr = tici.abnr AND tici.inplnr = tiin.inplnr
WHERE 1=1 || SqlWhere
GROUP BY GroupBy;
BEGIN
-- If these parameters are null, raise error
IF psUppgkedjetyp IS NULL and psSubtyp IS NULL THEN
raise_application_error(-20001,
'Either Event Chain or Starting Event must be assigned');
END IF;
-- Populate TIAL values
IF psUppgkedjetyp IS NOT NULL THEN
cTIAL.Uppgkedjetyp := psUppgkedjetyp;
END IF;
IF psAlarmtyp IS NOT NULL THEN
cTIAL.Alarmtyp := psAlarmtyp;
END IF;
cTIAL.Handklass := 'T';
cTIAL.Blobid := 0;
IF pnDays IS NOT NULL THEN
psDays := '+ '||pnDays;
END IF;
IF psSubtyp IS NOT NULL THEN
cTIAL.Subtyp := psSubtyp;
END IF;
-- Create Where clause for cursor
vSqlWhere := '';
IF psKampkod IS NOT NULL THEN
vSqlWhere := vSqlWhere||' AND tiin.kampkod = '''|| psKampkod||'''';
END IF;
IF psKatnr IS NOT NULL THEN
vSqlWhere := vSqlWhere||' AND tiin.katnr = '''||psKatnr||'''';
END IF;
IF psUtgava IS NOT NULL THEN
vSqlWhere := vSqlWhere||' AND tiin.utgava = '''||psUtgava||'''' ;
END IF;
IF psKatslag IS NOT NULL THEN
vSqlWhere := vSqlWhere||' AND tikg.katslag = '''||psKatslag||'''';
END IF;
IF psProdsyst IS NOT NULL THEN
vSqlWhere := vSqlWhere||' AND tikg.prodsyst = '''||psProdsyst||'''';
END IF;
IF psUppgtyp IS NOT NULL THEN
vSqlWhere := vSqlWhere||' AND tiin.uppgtyp = '''||psUppgtyp||'''';
END IF;
IF psProdkod IS NOT NULL THEN
vSqlWhere := vSqlWhere||' AND tiin.prodkod = '''||psProdkod||'''';
END IF;
IF psStatus IS NOT NULL THEN
vSqlWhere := vSqlWhere||' AND tiin.status = '''||psStatus||'''';
END IF;
-- Loop through all records meeting input parameters and set required TIAL values.
FOR i IN cSqlSelect(vSqlWhere, vGroupBy)
LOOP
--FETCH cSelectCursor INTO cRec;             
cTIAL.Kampkod := '';
cTIAL.Abnr := '';
cTIAL.Sign := '';
cTIAL.Alarmdate := '';
cTIAL.Kampkod := i.Kampkod;
cTIAL.Abnr := i.Abnr;
cTIAL.Sign := i.fordsalj;
cTIAL.Alarmdate := i.alarmdate;
nCount := nCount + 1;
IF vLopnr = -1 THEN
raise_application_error(-20002,
'Error Creating task for: '||cTIAL.Kampkod||' '||cTIAL.Abnr||' Sales Rep: '||cTIAL.Alarmdate);
END IF;
END LOOP;
DBMS_OUTPUT.PUT_LINE('I created '||nCount||' records.');
END createFollowUpTask_Exposure;
Thanks in advance for any help.

Answer 1

Hi,
Welcome to the forum!
Try this (not tested) as an example:
PROCEDURE createFollowUpTask_Exposure(psUppgkedjetyp IN tis.tial.uppgkedjetyp%TYPE DEFAULT NULL,
                                      psAlarmtyp     IN tis.tial.alarmtyp%TYPE DEFAULT NULL,
                                      psSubtyp       IN tis.tial.subtyp%TYPE DEFAULT NULL,
                                      pnDays         IN NUMBER DEFAULT NULL,
                                      psKampkod      IN tis.tiin.kampkod%TYPE DEFAULT NULL,
                                      psKatnr        IN tis.tiin.katnr%TYPE DEFAULT NULL,
                                      psUtgava       IN tis.tiin.utgava%TYPE DEFAULT NULL,
                                      psKatslag      IN tis.tikg.katslag%TYPE DEFAULT NULL,
                                      psProdsyst     IN tis.tikg.prodsyst%TYPE DEFAULT NULL,
                                      psUppgtyp      IN tis.tiin.uppgtyp%TYPE DEFAULT NULL,
                                      psProdkod      IN tis.tiin.prodkod%TYPE DEFAULT NULL,
                                      psStatus       IN tis.tiin.status%TYPE DEFAULT NULL) AS
   cTIAL         tis.tial%ROWTYPE;
   vLopnr        tis.tial.lopnr%TYPE;
   vSqlWhere     VARCHAR2(4000);
   vGroupBy      VARCHAR2(1000) := ' tiin.kampkod, tiin.abnr, tiko.fordsalj';
   cSelectCursor SYS_REFCURSOR;
   vSqlSelect    VARCHAR2(4000);
   psDays        VARCHAR2(50);
   cRec          T_TIAL_REC;
   nCount        NUMBER := 0;
   FUNCTION fnc_cSqlSelect(SqlWhere IN VARCHAR2,
                           GroupBy  IN VARCHAR2) RETURN VARCHAR2 IS
   BEGIN
      RETURN 'SELECT tiin.kampkod,
             tiin.abnr,
             tiko.fordsalj,
             MAX(tici.regdat) ALARMDATE
        FROM tis.tiin
        JOIN tis.tiko ON tiin.kampkod = tiko.kampkod
                     AND tiin.abnr = tiko.abnr
        JOIN core.tici ON tiin.kampkod = tici.kampkod
                      AND tiin.abnr = tici.abnr
                      AND tici.inplnr = tiin.inplnr
       WHERE 1 = 1 ' || SqlWhere || ' GROUP BY ' || GroupBy;
   END fnc_cSqlSelect;
BEGIN
   -- If these parameters are null, raise error
   IF psUppgkedjetyp IS NULL AND psSubtyp IS NULL THEN
      raise_application_error(-20001,
                              'Either Event Chain or Starting Event must be assigned');
   END IF;
   -- Populate TIAL values
   IF psUppgkedjetyp IS NOT NULL THEN
      cTIAL.Uppgkedjetyp := psUppgkedjetyp;
   END IF;
   IF psAlarmtyp IS NOT NULL THEN
      cTIAL.Alarmtyp := psAlarmtyp;
   END IF;
   cTIAL.Handklass := 'T';
   cTIAL.Blobid    := 0;
   IF pnDays IS NOT NULL THEN
      psDays := '+ ' || pnDays;
   END IF;
   IF psSubtyp IS NOT NULL THEN
      cTIAL.Subtyp := psSubtyp;
   END IF;
   -- Create Where clause for cursor
   vSqlWhere := '';
   IF psKampkod IS NOT NULL THEN
      vSqlWhere := vSqlWhere || ' AND tiin.kampkod = ''' || psKampkod || '''';
   END IF;
   IF psKatnr IS NOT NULL THEN
      vSqlWhere := vSqlWhere || ' AND tiin.katnr = ''' || psKatnr || '''';
   END IF;
   IF psUtgava IS NOT NULL THEN
      vSqlWhere := vSqlWhere || ' AND tiin.utgava = ''' || psUtgava || '''';
   END IF;
   IF psKatslag IS NOT NULL THEN
      vSqlWhere := vSqlWhere || ' AND tikg.katslag = ''' || psKatslag || '''';
   END IF;
   IF psProdsyst IS NOT NULL THEN
      vSqlWhere := vSqlWhere || ' AND tikg.prodsyst = ''' || psProdsyst || '''';
   END IF;
   IF psUppgtyp IS NOT NULL THEN
      vSqlWhere := vSqlWhere || ' AND tiin.uppgtyp = ''' || psUppgtyp || '''';
   END IF;
   IF psProdkod IS NOT NULL THEN
      vSqlWhere := vSqlWhere || ' AND tiin.prodkod = ''' || psProdkod || '''';
   END IF;
   IF psStatus IS NOT NULL THEN
      vSqlWhere := vSqlWhere || ' AND tiin.status = ''' || psStatus || '''';
   END IF;ç
   -- Loop through all records meeting input parameters and set required TIAL values.
   OPEN cSelectCursor FOR fnc_cSqlSelect(vSqlWhere,
                                         vGroupBy);
   LOOP
      FETCH cSelectCursor
         INTO v; -- You must define a variable 'v' to hold the data of cursor
      EXIT WHEN cSelectCursor%NOTFOUND;
      --FETCH cSelectCursor INTO cRec;
      cTIAL.Kampkod   := '';
      cTIAL.Abnr      := '';
      cTIAL.Sign      := '';
      cTIAL.Alarmdate := '';
      cTIAL.Kampkod   := i.Kampkod;
      cTIAL.Abnr      := i.Abnr;
      cTIAL.Sign      := i.fordsalj;
      cTIAL.Alarmdate := i.alarmdate;
      nCount := nCount + 1;
      IF vLopnr = -1 THEN
         raise_application_error(-20002,
                                 'Error Creating task for: ' || cTIAL.Kampkod || ' ' ||
                                 cTIAL.Abnr || ' Sales Rep: ' || cTIAL.Alarmdate);
      END IF;
   END LOOP;
   CLOSE cSelectCursor;
   DBMS_OUTPUT.PUT_LINE('I created ' || nCount || ' records.');
END createFollowUpTask_Exposure;
/Regards,