Peer reviews,coding standards and audit norms

hi,
what is meant by peer reviews, coding standards and audit norms in development project of ABAP.
regds:
balakrishna.

Hi Bala,
Peer review: The code which is written by the developer will be cross checked by one of the team member if the code fulfills the technical spec or not.
Coding Standards: In a project the client and the software service provider will have an understanding regarding naming convention of all variables, constants, internal table, select-options, etc.
Example: if it is a select-options the field should be named with the first letter S_ then you will write S_Matnr, and for variables you have to follow V_ then V_maktx.
Audit norms: Audit norms will depend on the organization so it does not have any standard answer.
Regards,
Lakshmikanth

Similar Messages

Implementation of Oracle Coding Standards and Code Quality Checks

I wanted to implement a list of coding standards and code quality checks for my oracle packages,functions,views,tableetc .
for example
All variables with number datatype should start with N_ and charcter type with C_ in all my tables & views definition.
This can be identified during peer review & can be corrected, but i think this is a repeated process which i don want to burden the developers rather i wanted a tool which does all these kind of checks which can be automated.
Is there any tool which does this operation or can someone give me a little idea how can i automate these stuffs bu creating a generic oracle procedure which can run through all the tables,views and generate a error report for those which are deviating from the standards.
Thus we can reduce the manual effort spent on peer review, please suggest.
thanks in advance

maru wrote:
I wanted to implement a list of coding standards and code quality checks for my oracle packages,functions,views,tableetc .
for example
All variables with number datatype should start with N_ and charcter type with C_ in all my tables & views definition.Hungarian notation is dead. It has no place in modern programming languages. Has no place in PL/SQL. Anit ain't just me saying that.
+"Encoding the type of a function into the name (so-called Hungarian notation) is brain damaged—the compiler knows the types anyway and can check those, and it only confuses the programmer."+
Linus Torvalds
+"No I don't recommend 'Hungarian'. I regard 'Hungarian' (embedding an abbreviated version of a type in a variable name) a technique that can be useful in untyped languages, but is completely unsuitable for a language that supports generic programming and object-oriented programming—both of which emphasize selection of operations based on the type an arguments (known to the language or to the run-time support). In this case, 'building the type of an object into names' simply complicates and minimizes abstraction."+
Bjarne Stroustrup
2) Conditional Statements
IF (x = 1) --> Wrong
IF ((x = 1) AND (y = 2)) --> wrong
IF x = 1 AND y = 2 --> RightIdiotic rules. The simple rule should be readability of code. Not how many brackets to use, and when not to use brackets. Minute standards like detracts from designing and writing proper code, fast and efficiently.
There are many more rules (which is specific to ur application) which can be incorporated in the tool, there by giving consistency ,readability and easy to maintain for the developers.Bull. The more rules there are, the more difficult it becomes for programmers to write code. As it is no longer about writing readable and flexible and performing code - it is about double checking every single statement line against a huge list of rules about do's and dont's. It is not about getting the programmer focusing on solving the problem - it is about distracting the programmer with a complex and large rule list of how the code should look like.
Sorry - but this rubs me the wrong way. In that environment, I would be the first to tell you to shove your "+many more rules+".
I've developed systems in over a dozen languages over the years. I've seen all kinds of standards. The standards that work are those that are short, simple and sensible. Hungarian notation is not sensible. Writing reserved words in uppercase is not sensible. Dictating how brackets should be used is not sensible.
What is sensible is using the de facto naming standards in use today - as per .Net Guidelines for Names (MSDN) and Code Conventions for the Java Programming Language.
What is sensible is providing guidelines like bulk collection needs to be justified (not possible using SQL only) and use the limit clause to manage memory spend on the collection variable. Or how packages need to be used to modularise code, providing a public interface and private implementation.
Standards are about creating a sensible and easy-to-use framework for writing code. It is not about creating a list of a 1001 rules that a developer needs to remember and adhere to, as if the developer is now part of some weird religious sect that has rules for every single aspect of human behaviour.

Coding standards and naming convention

Hi,
Can anyone please provide any documentation available for BPM development.
Would really appreciate for any pointers.
Edited by: 905033 on Oct 23, 2012 2:54 AM

we are using Oracle BPM 11.1.1.3

Need of peer review software (in research)

Hej (Swedish for Hi),
I have submitted this question to the Leopard forum, but if any administrator thinks it is more suitable in another Mac Forum, please feel free to move my post.
NEED OF SOFTWARE
Most of the times when I submit a manuscript to a scientific journal, that journal will ask me to supply the names, addresses and email addresses of 3-4 potential peer reviewers (they will scrutinize my paper and judge its quality). I do this over and over again. Sometimes a manuscript is rejected and I am quite convinced I know who rejected the paper (although peer review is anonymous), and I might not want to recommend that person again for the very same manuscript. Sometimes I have recommended a person as a peer reviewer several times within the last months, and want to recommend someone else.
It could also be nice to have some statistics of how many times a certain person has been recommended, and for what journal. Of course this could probably be done in Excel, but perhaps there is some nice Mac-program for this (otherwise, is anyone interrested in writing one...?)
I am looking for a software that could handle the following:
name of the reviewer
current email
current address
current institution
reasons for choosing him/her as a peer reviewer
Last time he was recommended
Number of times he/she has been recommended.
A list of all journals, dates and for what papers he has been recommended
The outcome of each submission when he/she was recommended
How would you have solved this?
Best regards, Jonas Ludvigsson
(doing research on celiac disease, and epidemiology in general)

Howdy Jonas (Texas for hej),
It sounds like you are looking for a simple database application. [Bento|http://store.apple.com/us/product/TW345LL/A] would probably be able to do everything you need. It is made by FileMaker.
Best of luck.

Standard and sys audit to syslog

Hello,
I have question about enabling auditing to syslog.
Is it possible to configure standard and sys auditing to local syslog in linux environment?
I have read that from version 10.2 it is possible to add AUDIT_SYSLOG_LEVEL parameter to init.ora to send audit trail to syslog. But I need to have both auditings: standard auditing and sys operations auditing on a remote host using syslog.
Regards
Dominik

Hi,
I hope that the following document helps: http://www.springerlink.com/index/ut68j3652k06747j.pdf
Regards,
Naveed.

OO ABAP and BSP coding standards

Hi,
Can anyone send me the documnet for OO ABAP and BSP coding standards.
Points will be rewarded.
Regards
Sandeep Reddy

Hi,
Can anyone send me the documnet for OO ABAP and BSP coding standards.
Points will be rewarded.
Regards
Sandeep Reddy

About documents in the peer review

1. What are the documents involved in the peer review of the object?
2. is there anything called quality check list using when we are doing peer review?
3. what is the meaning of quality check list, what do u do with the quality check list?

Do check the following things...
1) There are coding standards in every project. Try to check all the coding standards in the code.
2) see that no hard coding is done in the code.
3)Pls refer to an existing transaction code if you are making a module pool program.
4) Always test the changes.
5) If there are If & Else in program, make sure that you simulate conditions so that each line of code is executed at least once for testing.
6) While writing selects try to see if indexes can be used
7)Quality checklist generally means following the standards as laid out by the client.
do an extended code review and try to remove as much extra things as possible.
Reward if useful,
Cheers,
Sharadendu

XQuery Coding Standards

Are there any XQuery coding standards defined for use in OSM?
Or does Oracle provide any such standards for naming conventions, variable names, the case-sensitivity etc?
Or are the standards similar to what we follow for Java?
Please help.
Thanks in advance!

OSM does not dictate a specific set of coding guidelines for XQuery, just as it does not for Java. Normally coding guidelines (whether for Java, XQuery or other technologies) would be defined for a given project based on the best practices and experiences of the System Integrator or Service Provider that is implementing OSM.
Given that XQuery is an industry standard language, we would encourage you to follow best practices established in the industry.
Generally, for XQuery code that the OSM product team writes we follow Java style naming conventions and style wherever applicable. This is a convention we find reasonable given our team routinely writes and reviews both XQuery and Java code so having the same naming convention makes sense.
If there are are additional more specific questions you have on this topic feel free to ask them and we'll do our best to help you.
Regards,
Brian Dueck
VP - Product Strategy and Design
Oracle Communications
Edited by: brian.dueck on Jul 4, 2011 1:59 PM

Connection pooling and auditing on an oracle database

Integration of a weblogic application with an oracle backend,
Connection pooling, and auditing ,2 conflicting requirements ?
Problem statement :
We are in the process of maintaining a legacy client server application where
the client is
written in PowerBuilder and the backend is using an Oracle database.
Almost all business logic is implemented in stored procedures on the database.
When working in client/server mode ,1 PowerBuilder User has a one-to-one relation
with
a connection(session) on the oracle database.
It is a requirement that the database administrator must see the real user connected
to the database
and NOT some kind of superuser, therefore in the PowerBuilder app each user connects
to the database
with his own username.(Each user is configured on the database via a seperate
powerbuilder security app).
For the PowerBuilder app all is fine and this app can maintain conversional state(setting
and
reading of global variables in oracle packages).
The management is pushing for web-based application where we will be using bea
weblogic appserver(J2EE based).
We have build an business app which is web-based and accessing the same oracle
backend app as
the PowerBuilder app is doing.
The first version of this web-based app is using a custom build connector(based
on JCA standard and
derived from a template provided by the weblogic integration installation).
This custom build connector is essentially a combination of a custom realm in
weblogic terms
and a degraded connection pool , where each web session(browser) has a one-to-one
relation
with the back end database.
The reason that this custom connector is combining the security functionality
and the pooling
functionality , is because each user must be authenticated against the oracle
database(security requirement)
and NOT against a LDAP server, and we are using a statefull backend(oracle packages)
which would make it
difficult to reuse connections.
A problem that surfaced while doing heavy loadtesting with the custom connector,
is that sometimes connections are closed and new ones made in the midst of a transaction.
If you imagine a scenario where a session bean creates a business entity ,and
the session bean
calls 1 entity bean for the header and 1 entity bean for the detail, then the
header and detail
must be created in the same transaction AND with the same connection(there is
a parent-child relationship
between header and detail enforced on the back end database via Primary and Foreing
Keys).
We have not yet found why weblogic is closing the connection!
A second problem that we are experincing with the custom connector, is the use
of CMP(container managed persistence)
within entity beans.
The J2EE developers state that the use of CMP decreases the develoment time and
thus also maintenance costs.
We have not yet found a way to integrate a custom connector with the CMP persistence
scheme !
In order to solve our loadtesting and CMP persistence problems i was asked to
come up with a solution
which should not use a custom connector,but use standard connection pools from
weblogic.
To resolve the authentication problem on weblogic i could make a custom realm
which connects to the
backend database with the username and password, and if the connection is ok ,
i could consider this
user as authenticated in weblogic.
That still leaves me with the problem of auditing and pooling.
If i were to use a standard connection pool,then all transaction made in the oracle
database
would be done by a pool user or super user, a solution which will be rejected
by our local security officer,
because you can not see which real user made a transaction in the database.
I could still use the connection pool and in the application , advise the application
developers
to set an oracle package variable with the real user, then on arrival of the request
in the database,
the logic could use this package variable to set the transaction user.
There are still problems with this approach :
- The administrator of the database can still not see who is connected , he will
only see the superuser connection.
- This scheme can not be used when you want to use CMP persistence , since it
is weblogic who will generate the code
to access the database.
I thought i had a solution when oracle provided us with a connection pool known
as OracleOCIConnectionPool
where there is a connection made by a superuser, but where sessions are multiplexed
over this physical pipe with the real user.
I can not seem to properly integrate this OCI connectionpool into weblogic.
When using this pool , and we are coming into a bean (session or entity bean)
weblogic is wrapping
this pool with it's own internal Datasource and giving me back a connection of
the superuser, but not one for the real user,
thus setting me with my back to the wall again.
I would appreciate if anyone had experienced the same problem to share a possible
solution with us
in order to satisfy all requirements(security,auditing,CMP).
Many Thanks
Blyau Gino
[email protected]

Hi Blyau,
As Joe has already provided some technical advice,
I'll try to say something on engineering process level.
While migrating an application from one technology to
other, like client-server to n-tier in you case, customers and
stakeholders want to push into the new system as many old
requirements as possible. This approach is AKA "we must
have ALL of the features of the old system". Mostly it happens
because they don't know what they want. Ad little understanding
of abilities of the new technology, and you will get a requirement
like the one you have in you hands.
I think "DBA must see real user" is one of those. For this
type of requirements it can make sense to try to drop it,
or to understand its nature and suggest alternatives. In this
particular case it can be a system that logs user names,
login and logout times.
Blind copying of old features into an incompatible new architecture
may endanger the whole project and can result in its failure.
Hope this helps.
Regards,
Slava Imeshev
"Blyau Gino" <[email protected]> wrote in message
news:[email protected]...
>
Integration of a weblogic application with an oracle backend,
Connection pooling, and auditing ,2 conflicting requirements ?
Problem statement :
We are in the process of maintaining a legacy client server applicationwhere
the client is
written in PowerBuilder and the backend is using an Oracle database.
Almost all business logic is implemented in stored procedures on thedatabase.
When working in client/server mode ,1 PowerBuilder User has a one-to-onerelation
with
a connection(session) on the oracle database.
It is a requirement that the database administrator must see the real userconnected
to the database
and NOT some kind of superuser, therefore in the PowerBuilder app eachuser connects
to the database
with his own username.(Each user is configured on the database via aseperate
powerbuilder security app).
For the PowerBuilder app all is fine and this app can maintainconversional state(setting
and
reading of global variables in oracle packages).
The management is pushing for web-based application where we will be usingbea
weblogic appserver(J2EE based).
We have build an business app which is web-based and accessing the sameoracle
backend app as
the PowerBuilder app is doing.
The first version of this web-based app is using a custom buildconnector(based
on JCA standard and
derived from a template provided by the weblogic integrationinstallation).
This custom build connector is essentially a combination of a custom realmin
weblogic terms
and a degraded connection pool , where each web session(browser) has aone-to-one
relation
with the back end database.
The reason that this custom connector is combining the securityfunctionality
and the pooling
functionality , is because each user must be authenticated against theoracle
database(security requirement)
and NOT against a LDAP server, and we are using a statefull backend(oraclepackages)
which would make it
difficult to reuse connections.
A problem that surfaced while doing heavy loadtesting with the customconnector,
>
is that sometimes connections are closed and new ones made in the midst ofa transaction.
If you imagine a scenario where a session bean creates a business entity,and
the session bean
calls 1 entity bean for the header and 1 entity bean for the detail, thenthe
header and detail
must be created in the same transaction AND with the same connection(thereis
a parent-child relationship
between header and detail enforced on the back end database via Primaryand Foreing
Keys).
We have not yet found why weblogic is closing the connection!
A second problem that we are experincing with the custom connector, is theuse
of CMP(container managed persistence)
within entity beans.
The J2EE developers state that the use of CMP decreases the develomenttime and
thus also maintenance costs.
We have not yet found a way to integrate a custom connector with the CMPpersistence
scheme !
In order to solve our loadtesting and CMP persistence problems i was askedto
come up with a solution
which should not use a custom connector,but use standard connection poolsfrom
weblogic.
To resolve the authentication problem on weblogic i could make a customrealm
which connects to the
backend database with the username and password, and if the connection isok ,
i could consider this
user as authenticated in weblogic.
That still leaves me with the problem of auditing and pooling.
If i were to use a standard connection pool,then all transaction made inthe oracle
database
would be done by a pool user or super user, a solution which will berejected
by our local security officer,
because you can not see which real user made a transaction in thedatabase.
I could still use the connection pool and in the application , advise theapplication
developers
to set an oracle package variable with the real user, then on arrival ofthe request
in the database,
the logic could use this package variable to set the transaction user.
There are still problems with this approach :
- The administrator of the database can still not see who is connected ,he will
only see the superuser connection.
- This scheme can not be used when you want to use CMP persistence , sinceit
is weblogic who will generate the code
to access the database.
I thought i had a solution when oracle provided us with a connection poolknown
as OracleOCIConnectionPool
where there is a connection made by a superuser, but where sessions aremultiplexed
over this physical pipe with the real user.
I can not seem to properly integrate this OCI connectionpool intoweblogic.
When using this pool , and we are coming into a bean (session or entitybean)
weblogic is wrapping
this pool with it's own internal Datasource and giving me back aconnection of
the superuser, but not one for the real user,
thus setting me with my back to the wall again.
I would appreciate if anyone had experienced the same problem to share apossible
solution with us
in order to satisfy all requirements(security,auditing,CMP).
Many Thanks
Blyau Gino
[email protected]

What are the best coding standards for ADF 11g?

Hi,
Do we have any link that will suggest the best coding standard practices used for ADF 11g?
I am looking out from the perspective of some standards that can be defined before starting my project to know the team on how to
1. Minimize Duplicity and max reusability of code
2. Package the code
3. Resource bundle usage and its calls
4. Maintainning format consistency eg. date display format, number format
5. Exception handling
6. Logging
7. Namiing conventions
Also then we might have standards on
1. Task flow dev.
2. EO and VO creation standards
3. UI development standards [purely ADF component based]
Thanks in advance
Edited by: user8925296 on May 26, 2010 3:24 PM

The ADF Enterprise Methodology Group has a page on standards that gives you a starting point on many of your questions: http://groups.google.com/group/adf-methodology/web/adf-coding-standards
John

Please help regarding PLSQL coding standards

Hi,
Can you please send any document for PL/SQL coding standards,
Please help.. I did nt find any good resources on net regarding..
Pleease help me if any pdf regarding are exitst to my mail id
[email protected]
Thanks and Regards
asp

I did nt find any good resources on net regarding..Here is a list from the net for you to start with (courtesy of many of the fellow posters here in these forums), and there will be plenty more. Just need to search correctly.
http://www.redhat.com/docs/manuals/waf/rhea-dg-waf-en-6.0/ap-sql-standards.html
http://www.orafaq.com/faqplsql.htm
http://www.williamrobertson.pwp.blueyonder.co.uk/documents/plsqlcodingstandards.html
http://www.orafaq.com/node/48
http://apex.oracle.com/pls/otn/f?p=2853:4:11598658413321972351::NO::P4_QA_ID:3262
http://www.bbc.co.uk/guidelines/newmedia/technical/databases.shtml
Message was edited by:
Kamal Kishore
Message was edited by:
Kamal Kishore

Technical Specification Peer Review Document

Hi Team
right now i am working in a implementation project where PI system is a middleware system. here i am developing several abap related and PI related objects for that i have developed some Techincal specifications and now my requirement is to do the technical specification peer review. so I want to know more details about technical specification peer review document. Please tell me what is technical specification peer review document and why is used in detail. if possible please provide me the sample technical specification peer review document for my reference. i request you to please explain me more details about the technical specification peer review document because i am having much knowledge and now there is a requirement for me to do technical specification peer review and update in the template, so please do provide me the sample techincal specification peer review template for my better understanding. Thanks in advance.
Regards
Raj

Hi Raj,
I never com across Technical Specification peer review document, We develop TS for every interface which covers
1)Bussiness reuirement
2)Trchnical Description in deatil
3)Bussiness Flow
4)Source and Tget data fromats description
5)Mapping Logic
6)Which adapters are you going to use,ad you need to specify all obejcts required for this interface/developed for this interface
whick convers SLD,ESR,ID ...
fter completion of evry interface we updates the all deatils in TS,then we need to review the same TS.if anything misses of we need to document the same.May be you need to develop one template for to note down all review comments...
Regards,
Raj

History tables and audit columns?

I need suggestions that is it a best practice to make a history table of every table and audit columns in every table as well?
Kind Regards
Abbas

I agree with Christian. I'd also add that you do NOT want to implement this as a Forms solution , this should be done within the database and be transparent to the Forms. There is also standard Oracle Audit software that can be configured and used too.

R12.2.0 online pathcing coding standard - table alias name = shcema name

We are getting coding standard violation error for particular file saying schema name is hard coded in the file. But actually we didn't use any table name with schema name.
For ex.
select xle.event_id from xla_events xle;
Here the table xla_event doesn't use any schema name, but the "XLE" is a schema name in database. Because of this we are getting code standard violation error.
This shouldn't be a coding violation.

Please post the details of the application release, database version and OS.
We are getting coding standard violation error for particular file saying schema name is hard coded in the file. But actually we didn't use any table name with schema name.How do you get this error?
For ex.
select xle.event_id from xla_events xle;
Here the table xla_event doesn't use any schema name, but the "XLE" is a schema name in database. Because of this we are getting code standard violation error.
This shouldn't be a coding violation.What is the complete error message? What is the patch you are trying to apply?
Thanks,
Hussein

Premiere Pro CS4 and Audition 3 problem!

Please help! I have CS4 Premiere and Audition 3 I update Premiere to version 4.2 and I got to edit in Audition, but dark and I can not hit. When I push edit original, audition opened and the processed sound. When I want to save the file leaves me a window that can not be done because the file is open in another program. Thanks in advance reply.

The solution is very simple,:
This update resolves the question.
This update install modification in dynalic link to support adobe autition3 instead of soundbooth.
This updaye , also adds support for AAF import/export, Apple Final Cut Pro XML project import, and OMF export, along with
numerous other stability and quality improvements. The update is recommended for all Adobe Premiere Pro CS4 users.
An important detail is that this feature only works in Windows. Sorry ´bout the poor MAC software.
http://www.adobe.com/support/downloads/detail.jsp?ftpID=4088
The home page of all updates for Premiere Pro CS4 is here :
http://www.adobe.com/support/downloads/product.jsp?product=98&platform=Windows
Reinstalling all the apllication and if the aplication is standard CS4 (4.0) this acti0on will not resolve the issue.
My recomendation is to install update 4.0.1 and 4.1.0
Others like 420, 421 is apllicable only if demand use of large avc intra, red format and p2 with h264 and other improvments
Best Regards,
Leon Unger
Adobe Certified Professional

Peer reviews,coding standards and audit norms

Similar Messages

Maybe you are looking for