Performance issue in Loop statement.

Hi experts,
I got an issue regarding performance in the loop statement. (IT_OUT_FINAL has huge amount of data.)
LOOP AT it_out_final INTO wa_out_final.
READ TABLE it_prdline_txt
WITH KEY ydprodln = wa_out_final-prdline.
IF sy-subrc = 0.
wa_out_final-prdline = it_prdline_txt-ydvtext.
MODIFY it_out_final FROM wa_out_final TRANSPORTING prdline.
CLEAR: wa_out_final.
ENDIF.
read table i_sokna with key kunnr = wa_out_final-kunnr.
if sy-subrc eq 0.
wa_out_final-soreg = i_sokna-regio.
MODIFY it_out_final FROM wa_out_final TRANSPORTING soreg.
endif.
read table i_sokna with key kunnr = wa_out_final-kunwe.
if sy-subrc eq 0.
wa_out_final-shreg = i_sokna-regio.
MODIFY it_out_final FROM wa_out_final TRANSPORTING shreg.
endif.
clear : i_sokna,wa_out_final.
ENDLOOP.
Can you please help me , how to improve the performance in the above loop statement.
Thanks,
Revanth Kumar
Moderator message: duplicate post locked.
Edited by: Thomas Zloch on Jun 20, 2011 1:22 PM

Hi,
This one helped me in understanding the basics clearly. But I would like to further give you one example by which my question will be more clear to you and hence your further answer to it will help me in getting the idea about WHERE clause clarified.
I was required to develop a report of all held docs by the SAP USER that were created through transaction FB60, the input obtained from user should be SAP USERNAME(obligatory).
So the straight approach by me was that writing a SELECT-OPTIONS asking SAP USERNAME, and such username obtained from USER executing a report will be compared with the USERNAME stored in the column of table RFDT which stores all such held docs by a SAP USER that used transaction FB60 to temporarily hold it.
So the approach used by me was using the select statement fetch all records from the column storing the SAP USERNAMES that have held docs using FB60 transaction and where clause is used to filter out only values matching the values obtained from user i.e. using SELECT-OPTIONS.
So I was under the impression that WHERE clause can only be used in SELECT STATEMENT and not in LOOP AT...ENDLOOP.
Now I hope my question is more clear to you. If I am not wrong, there can be two approaches,
1) Using a SELECT statement containing the WHERE clause, fetch a resultset and then using LOOP...ENDLOOP. statement, display the output of the report using WRITE statement.
i.e. SELECT...WHERE...ENDSELECT and then LOOP AT...ENDLOOP.
2) Using SELECT statement, fetch all possible records and using LOOP...ENDLOOP. statement filter out the records using WHERE to match the resultset and display values in that resultset using WRITE statement
i.e. SELECT...ENDSELECT and then LOOP AT...WHERE...ENDLOOP.
Hope you will now be able to guide me better.
Regards
Ameet

Similar Messages

Performance issue with Loop under Loop

Hi,
I have an issue with the performance, as per the requirement I have to use the Loop under Loop logic.
I have sorted the Where condition field in Parent Loop and also in Child Loop like below :
SELECT GUID_PRCTSC "Primary Key as GUID in "RAW" Format
 GUID_PR "Primary Key as GUID in "RAW" Format
 STCTS "Numbering Scheme for Customs Tariff System
 DATAB "Definitive Date (Valid-From Time)
 GUID_CTSNUMC "Primary Key as GUID in "RAW" Format
 FROM /SAPSLL/PRCTSC
 INTO TABLE T_PRCTSC
 WHERE STCTS IN S_STCTS.
IF T_PRCTSC IS INITIAL.
 MESSAGE : I007(ZMSSG) WITH 'Data not available for this entry'.
 STOP.
ENDIF.
SORT T_PRCTSC BY GUID_PR.
SELECT GUID_PRGEN "Primary Key as GUID in "RAW" Format "+ DG1K902277
 GUID_PR "Primary Key as GUID in "RAW" Format
 ATTR05A "Materail Type
 ATTR05B "Sub-Family
 ATTR05C "SPEC BUS + DG1K902190
 ATTR10A "Materail Group
 ATTR20A "SUBSTANCE ID
 FROM /SAPSLL/PRGEN
 INTO TABLE T_PRGEN
 FOR ALL ENTRIES IN T_TCOATV20
 WHERE ATTR20A EQ T_TCOATV20-ATTRV20
 AND ATTR05A IN S_ATR5A " +DG1K902168
 AND ATTR05C IN S_ATR5C. " + DG1K902190
IF T_PRGEN IS INITIAL.
 MESSAGE : I007(ZMSSG) WITH 'Data not available for this entry'.
 STOP.
ENDIF.
*N-23
SORT T_PRGEN BY GUID_PR.
There are 90,000 records available in the table T_PRGEN.
LOOP AT T_PRGEN INTO WA_PRGEN.
 IF SY-SUBRC = 0.
 WA_FINAL-ATTR05A = WA_PRGEN-ATTR05A.
 WA_FINAL-ATTR05B = WA_PRGEN-ATTR05B.
 WA_FINAL-ATTR05C = WA_PRGEN-ATTR05C. " + DG1K902190
 WA_FINAL-ATTR10A = WA_PRGEN-ATTR10A.
 WA_FINAL-ATTR20A = WA_PRGEN-ATTR20A.
 ENDIF.
 READ TABLE T_V_TCAV201 INTO WA_V_TCAV201 WITH KEY ATTRV20 = WA_PRGEN-ATTR20A.
 IF SY-SUBRC = 0.
 WA_FINAL-TEXT1 = WA_V_TCAV201-TEXT1. "SUBID-TEXT1
 ENDIF.
 READ TABLE T_PNTPR INTO WA_PNTPR WITH KEY GUID_PR = WA_PRGEN-GUID_PR.
 IF SY-SUBRC = 0.
 WA_FINAL-PRVSY = WA_PNTPR-PRVSY. "PROD NO
 WA_FINAL-GRVSY = WA_PNTPR-GRVSY. "LOGICAL SYS GROUP
 ENDIF.
* TO Remove the Leading Zeros from prvsy
 SHIFT WA_FINAL-PRVSY LEFT DELETING LEADING '0'.
 READ TABLE T_CORSTA INTO WA_CORSTA WITH KEY GUID_MOBJ = WA_PNTPR-GUID_PR.
 IF SY-SUBRC = 0.
 WA_FINAL-QUAL_STA = WA_CORSTA-QUAL_STA.
 ENDIF.
 READ TABLE T_PR INTO WA_PR WITH KEY GUID_PR = WA_PNTPR-GUID_PR.
*& IN THE PROD MASTER PRODUCT CHANGED ON VALUE HAS BEEN &
*& MAINTAINED AS SINGLE '0', THIS WILL CAUSE ISSUES WHILE &
*& USING CONVERSION EXIT TO DISPLAY THE DATE FORMAT IN &
*& MM/DD/YYYY HH:MM:SEC &
 IF SY-SUBRC = 0.
 IF WA_PR-CHTSP = '0'.
 WA_FINAL-CRTSP = WA_PR-CRTSP.
 wa_final-chtsp = W_DATE.
 ENDIF.
 IF WA_PR-CHTSP NE '0'.
 WA_FINAL-CRTSP = WA_PR-CRTSP.
 wa_final-chtsp = WA_PR-CHTSP.
 ENDIF.
 ENDIF.
 READ TABLE T_PRT INTO WA_PRT WITH KEY GUID_PR = WA_PR-GUID_PR.
 IF SY-SUBRC = 0.
 WA_FINAL-PRTXT = WA_PRT-PRTXT.
 ENDIF.
LOOP AT T_PRCTSC INTO WA_PRCTSC WHERE GUID_PR = WA_PRGEN-GUID_PR. "+DG1K902258 - Performance issue
 IF SY-SUBRC = 0.
*& TO FILL ATTR20A,PRVSY FOR DIFF STCTS AND CCNGN FOR |
*& EACH LOOP |
 IF WA_FINAL-ATTR20A IS INITIAL
 AND WA_FINAL-PRVSY IS INITIAL.
 IF WA_PRGEN-GUID_PR = WA_PNTPR-GUID_PR. "This condition is to fill up all the rows for the same
 " Subid which have multiple stcts fields.
 IF SY-SUBRC = 0.
 WA_FINAL-ATTR05A = WA_PRGEN-ATTR05A.
 WA_FINAL-ATTR05B = WA_PRGEN-ATTR05B.
 WA_FINAL-ATTR05C = WA_PRGEN-ATTR05C. " + DG1K902190
 WA_FINAL-ATTR10A = WA_PRGEN-ATTR10A.
 WA_FINAL-ATTR20A = WA_PRGEN-ATTR20A.
 ENDIF.
 IF SY-SUBRC = 0.
 WA_FINAL-TEXT1 = WA_V_TCAV201-TEXT1. "SUBID-TEXT1
 ENDIF.
 IF SY-SUBRC = 0.
 WA_FINAL-PRVSY = WA_PNTPR-PRVSY. "PROD NO
 WA_FINAL-GRVSY = WA_PNTPR-GRVSY. "LOGICAL SYS GROUP
 ENDIF.
* TO Remove the Leading Zeros from prvsy
 SHIFT WA_FINAL-PRVSY LEFT DELETING LEADING '0'.
 IF SY-SUBRC = 0.
 WA_FINAL-QUAL_STA = WA_CORSTA-QUAL_STA.
 ENDIF.
 IF SY-SUBRC = 0.
 IF WA_PR-CHTSP = '0'.
 WA_FINAL-CRTSP = WA_PR-CRTSP.
 WA_final-chtsp = W_DATE.
 ENDIF.
 IF WA_PR-CHTSP NE '0'.
 WA_FINAL-CRTSP = WA_PR-CRTSP.
 WA_final-chtsp = WA_PR-CHTSP.
 ENDIF.
 ENDIF.
 IF SY-SUBRC = 0.
 WA_FINAL-PRTXT = WA_PRT-PRTXT.
 ENDIF.
 ENDIF.
 ENDIF.
 IF SY-SUBRC = 0. " + DG1K902198
 WA_FINAL-GUID_PR = WA_PRCTSC-GUID_PR.
 WA_FINAL-STCTS = WA_PRCTSC-STCTS.
 WA_FINAL-DATAB = WA_PRCTSC-DATAB. " + DG1K902198
 ENDIF.
 READ TABLE T_CTSNUMC INTO WA_CTSNUMC WITH KEY GUID_CTSNUMC = WA_PRCTSC-GUID_CTSNUMC.
 IF SY-SUBRC = 0.
 WA_FINAL-CCNGN = WA_CTSNUMC-CCNGN.
 ENDIF.
 APPEND WA_FINAL TO T_FINAL.
 CLEAR WA_FINAL.
 ENDIF.
 ENDLOOP.
 APPEND WA_FINAL TO T_FINAL.
 CLEAR WA_FINAL.
ENDLOOP.
Any suggestions to improve the performance will be appreciated!
Thanks & Regards,
Kittu
Edited by: Kittu on Mar 23, 2009 4:03 PM

Hi
Instead of using the LOOP under LOOP directly. use the read statement for second loop and from that index u start the loop.
eg:
LOOP AT ITAB1.
read table itab2 with key field1 = itab1 - field1.
if sy-subrc = 0.
loop at itab2 index sy-tabix.
if itab2-field1 = itab1 - field1.
< do u r operations >
else.
exit.
endif.
ENDLOOP.
this will increase the performance

Performance tuning the loop statement

Hi,
I have the following requirement.
I have an internal table IT_TEST1 which has values
Column1
A
B
C
D
consider a second internal table IT_TEST2. It'll have values like as follows:..I need to know which are the entries in column1 that have more than one entry in column 2 without looping through this internal table..Kindly suggest..
Column1 column2
A            VAL1
B            VAL1
B            VAL2
C            VAL1
C            VAL2
D            VAL1
D            VAL2
D            VAL3
This has caused very big performance issue for it is

Hi,
I have faced a similar problem and the following strategy has saved a lot of processing time
the following code may serve your pupose
if you are using IT_TEST2 for further processing please use IT_TEST3
otherwise use IT_TEST2 instead of IT_TEST3 in the code below......'
*************************CODE SAMPLE************************************
data : IT_TEST3 like IT_TEST2. "declare internal table same as IT_TEST2
IT_TEST3[] = IT_TEST2[].
    "Pass contents if IT_TEST2 is used for further processing
Sort IT_TEST1 by column1 . "Sort
Sort IT_TEST3 by column1 . "Sort
   loop at IT_TEST1.
           read table IT_TEST3
                with key column1 = IT_TEST1-column1.
                 if sy-subrc = 0.
                      describle table IT_TEST3 lines n.
                          if lines > 1.
                             "Multiple entries
                           else.
                             "Single entry
                          endif.
                 endif.
"Perform all operations on IT_TEST3
    DELETE IT_TEST3 WHERE column1 = IT_TEST1-column1.
"Delete the entry in IT_TEST3 already processed with the key of IT_TEST1
"Next time you do the read entries for the previous and all predecessor loops
will not be there'
"As you go down the loop performance increases
endloop.
Regards
Byju

Performance Issue in Select Statement (For All Entries)

Hello,
I have a report where i have two select statement
First Select Statement:
Select A B C P Q R
     from T1 into Table it_t1
          where ....
Internal Table it_t1 is populated with 359801 entries through this select statement.
Second Select Statement:
Select A B C X Y Z
     from T2 in it_t2 For All Entries in it_t1
          where A eq it_t1-A
             and B eq it_t1-B
             and C eq it_t1-C
Now Table T2 contains more than 10 lac records and at the end of select statement it_t2 is populated with 844003 but it takes a lot of time (15 -20 min) to execute second select statement.
Can this code be optimized?
Also i have created respective indexes on table T1 and T2 for the fields in Where Condition.
Regards,

If you have completed all the steps mentioned by others, in the above thread, and still you are facing issues then,.....
Use a Select within Select.
First Select Statement:
Select A B C P Q R package size 5000
     from T1 into Table it_t1
          where ....
Second Select Statement:
Select A B C X Y Z
     from T2 in it_t2 For All Entries in it_t1
          where A eq it_t1-A
             and B eq it_t1-B
             and C eq it_t1-C
do processing........
endselect
This way, while using for all entries on T2, your it_t1, will have limited number of entries and thus the 2nd select will be faster.
Thanks,
Juwin

Performance Issue in select statements

In the following statements, it is taking too much time for execution,Is there any best way to change these selection statements...int_report_data is my final internal table....
select fsplant fvplant frplant fl1_sto pl1_delivery pl1_gr pl2_sto           pl2_delivery perr_msg into (dochdr-swerks,dochdr-vwerks,dochdr-rwerks,dochdr-l1sto,docitem-l1xblnr, docitem-l1gr,docitem-l2sto, docitem-l2xblnr,docitem-err_msg) from zdochdr as f inner join zdocitem as p on fl1_sto = pl1_sto where fsplant in s_werks and
fvplant in v_werks and frplant in r_werks and pl1_delivery in l1_xblnr and pl1_gr in l1_gr and p~l2_delivery in l2_xblnr.
move : dochdr-swerks    to int_report_data-i_swerks,
        dochdr-vwerks    to int_report_data-i_vwerks,
        dochdr-rwerks    to int_report_data-i_rwerks,
        dochdr-l1sto     to int_report_data-i_l1sto,
        docitem-l1xblnr to int_report_data-i_l1xblnr,
        docitem-l1gr     to int_report_data-i_l1gr,
        docitem-l2sto    to int_report_data-i_l2sto,
        docitem-l2xblnr to int_report_data-i_l2xblnr,
        docitem-err_msg to int_report_data-i_errmsg.
        append int_report_data.
    endselect.
Goods receipt
loop at int_report_data.
select single ebeln from ekbe into l2gr where ebeln = int_report_data-i_l2sto and bwart = '101' and bewtp = 'E' and vgabe = '1'.
if sy-subrc eq 0.
       move l2gr to int_report_data-i_l2gr.
       modify int_report_data.
   endif.
endloop.
first Billing document (I have to check fkart = ZRTY for second billing *document..how can i write the statement)
select vbeln from vbfa into (tabvbfa-vbeln) where vbelv = int_report_data-i_l2xblnr or vbelv = int_report_data-i_l1xblnr.
select single vbeln from vbrk into tabvbrk-vbeln where vbeln = tabvbfa-vbeln and fkart = 'IV'.
if sy-subrc eq 0.
         move tabvbrk-vbeln to int_report_data-i_l2vbeln.
         modify int_report_data.
   endif.
   endselect.
Thanks in advance,
Yad

Hi!
Which of your selects is slow? Make a SQL-trace, check which select(s) is(are) slow.
For EKBE and VBFA you are selecting first key field - in general that is fast. If your z-tables are the problem, maybe an index might help.
Instead of looping and making a lot of select singles, one select 'for all entries' can help, too.
Please analyze further and give feedback.
Regards,
Christian

Performance issue in 'Selelect statement with for all entries'

Hi,
The following SELECT statement is taking too much time.
         SELECT * FROM /rb04/yc5_mver
         INTO TABLE g_it_mver
         FOR ALL ENTRIES IN l_it_inva
         WHERE matnr EQ l_it_inva-matnr AND
                      werks EQ l_it_inva-werks AND
                      indei EQ l_it_inva-indei AND
                      gjahr IN g_r_gjahr.
     Internal table l_it_inva is having too many records.
    Is there any way to optimize it.
Regards,
Tintu

Hi Tintu,
check table l_it_inva for initial.
sort internal table l_it_inva with key matnr werks indei gjahr.
delete adjacent duplicates from l_it_inva comparing   matnr werks indei gjahr.
Then use following select query.
SELECT * FROM /rb04/yc5_mver
INTO TABLE g_it_mver
FOR ALL ENTRIES IN l_it_inva
WHERE matnr EQ l_it_inva-matnr AND
werks EQ l_it_inva-werks AND
indei EQ l_it_inva-indei AND
gjahr IN g_r_gjahr.
Regards,
Vijay

Performance issue with the ABAP statements

Hello,
Please can some help me with the below statements where I am getting performance problem.
SELECT * FROM /BIC/ASALHDR0100 into Table CHDATE.
SORT CHDATE by DOC_NUMBER.
SORT SOURCE_PACKAGE by DOC_NUMBER.
LOOP AT CHDATE INTO WA_CHDATE.
   READ TABLE SOURCE_PACKAGE INTO WA_CIDATE WITH KEY DOC_NUMBER =
   WA_CHDATE-DOC_NUMBER BINARY SEARCH.
   MOVE WA_CHDATE-CREATEDON to WA_CIDATE-CREATEDON.
APPEND WA_CIDATE to CIDATE.
ENDLOOP.
I wrote an above code for the follwing requirement.
1. I have 2 tables from where i am getting the data
2.I have common fields in both the table names CREATEDON date. In both the tables I hve the values.
3. While accessing the 2 table and copying to thrid table i have to modify the field.
I am getting performance issues with the above statements.
Than
Edited by: Rob Burbank on Jul 29, 2010 10:06 AM

Hello,
try a select like the following one instead of you code.
SELECT field field2 ...
INTO TABLE it_table
FROM table1 AS T1 INNER JOIN table2 AS T2
ON t1-doc_number = t2-doc_number

LOOP inside loop -performance issue.

hi ppl,
I want to put the select query mentioned below outside the loop to resolve performance issue. The 'for all entries' does not support aggregate functions like 'sum' and 'group by'. plz have a look at my approach and suggest some changes.
the code:
LOOP AT T_UNITS.
V_TABIX = SY-TABIX.
CONCATENATE TEXT-S01 T_UNITS-UNIT INTO VL_TEXT SEPARATED BY ' '.
CALL FUNCTION 'SAPGUI_PROGRESS_INDICATOR'
EXPORTING
PERCENTAGE = 0
TEXT = VL_TEXT.
get GLPCA postings
SELECT AWTYP AWORG RACCT REFDOCNR SUM( HSL ) FROM GLPCA "1062
INTO TABLE T_GLPCA
WHERE RPRCTR = T_UNITS-UNIT
AND RACCT IN S_HKONT
AND KOKRS = V_KOKRS
AND RYEAR = P_GJAHR
AND POPER <= P_MONAT
GROUP BY AWTYP AWORG RACCT REFDOCNR.
lopp at t_glpca.
endloop.
endloop.
my approach:
all this put outside the loop 'loop at t_units'.
SELECT rprctr AWTYP AWORG RACCT REFDOCNR HSL FROM GLPCA "1062
INTO TABLE T_GLPCA
For all entries in t_units
 WHERE RPRCTR = T_UNITS-UNIT
 AND RACCT IN S_HKONT
 AND KOKRS = V_KOKRS
 AND RYEAR = P_GJAHR
 AND POPER <= P_MONAT.
loop at t_glpca.
 v_tabix = sy-tabix.
 select sum( hsl ) from glpca into t_glpca-hsl.
 modify t_glpca index v_tabix.
endloop.
The select query 'select sum( hsl ) from glpca into t_glpca-hsl' is consuming lot of time.
thanks in advance
Archana

hi ,
 u can use sum function while displaying also .
u have selected some values into itab na .aftyer that use the below code.
loop at itab.
at end of <fielname>.
sum.
write:/ itab-<fieldname>.
endat.
like this also u can some .so u can use for all entries in select statement .
hopw it's usefull for u .
or use
on change of <fielname>
endon.
instead of at endof.
EXAMPLE CODE
SELECT *
 FROM sflight
 INTO TABLE sflight_tab.
LOOP AT sflight_tab INTO sflight_wa.
AT NEW connid.
 WRITE: / sflight_wa-carrid,
 sflight_wa-connid.
 ULINE.
ENDAT.
WRITE: / sflight_wa-fldate,
 sflight_wa-seatsocc.
AT END OF connid.
 SUM.
 ULINE.
 WRITE: / 'Sum',
 sflight_wa-seatsocc UNDER sflight_wa-seatsocc.
 SKIP.
ENDAT.

Performance issues using control references in Analog control loop?

My main vi of a tensile tester control application calls a number of sub-vi's, including a analog control loop which controls the test. The control loop must update some boolean and digital indicators and respond to user input on the front panel of the main vi during a test.
To simplify my main vi, I moved the control loop code into a sub-vi, and used control references to access the controls and indicators on the front panel. However, this has dramatically affected my loop performance, and the loop can no longer keep up with the acquisition speed.
Do control references always cause such a slowdown? Is there anything that I can do besides moving the code back into the main vi?
Thank You,
David Creech

I have had the same problem. I have discovered other funny things about references also; some kind of memory management (or mismamagement?) is taking place behind the scenes.
Regardless, you can often do away with the references by passing the initial state of a control or indicator into the subvi, changing it inside, and passing the altered state back to the caller. Once back in the caller you update the front panel control or indicator by using a local variable.
One thing to watch out for if using this scenario is the dreaded race condition; this can be avoided using a state machine. Check out
http://www.advmeas.com/goodies/statemachine.html
for a good example. It is a shame that references behave in this way; it limits thier usefulness.
Perhaps someo
ne else will point out a way to utilize them more sucessfully?

Performance issue: CALL FUNCTION inside a Loop.

Hi Friends
I have a Performance Issue. That is, inside a loop...endloop a CALL FUNCTION has been used which gets data from another database table. Finally it's appended into another internal table. Please see this :
LOOP AT i_mdkp.
    REFRESH lt_mdtbx.
    CLEAR lt_mdtbx.
    CALL FUNCTION 'READ_MRP_LIST'
      EXPORTING
        idtnum        = i_mdkp-dtnum
        icflag        = 'X'
      tables
        mdtbx         = lt_mdtbx
    APPEND LINES OF lt_mdtbx TO i_mdtb.
ENDLOOP.
It happens for each record available in i_mdkp. Suppose, i_mdkp have around 50000 records, it needs to call the function module till that much time.
So, I want to split it. Can I?
Please give me your valueable suggestions.
Regards
Senthil

If internal table i_mdkp has 50,000 records it does not mean that you need to run 50,000 iterations. You just need dtnum from internal table i_mdkp so you number of iterations should be eqaul to the unique number of dtnum in the internal table. Sort the internal table by dtnum and delete adjacent duplicates from the internal table comparing dtnum before looping. Look at the code below.
DATA i_mdkp_tmp LIKE TABLE OF i_mdkp.
IF NOT i_mdkp[] IS INITIAL.
i_mdkp_tmp[] = i_mdkp[].
SORT i_mdkp BY dtnum.
DELETE ADJACENT DUPLICATES FROM i_mdkp COMPARING dtnum.
REFRESH i_mdtb.
LOOP AT i_mdkp.
    CALL FUNCTION 'READ_MRP_LIST'
      EXPORTING
        idtnum = i_mdkp-dtnum
        icflag = 'X'
      TABLES
        mdtbx = lt_mdtbx.
    APPEND LINES OF lt_mdtbx TO i_mdtb.
    REFRESH lt_mdtbx.
ENDLOOP.
i_mdkp[] = i_mdkp_tmp[]
ENDIF.

Performance Issues DPS - Single Edition - PDF Rendering, Multi-State Text

Hello,
Please advise on the above issue...
On a retina display ipad, I'm having issues with multi-state objects that contain text. The column on the left is crisp text, non multi-state object. However when I place the text in a multi state object (right) it's not rendering in high resolution. A bit pixelated.
Single Issue - Creative Cloud License
iPad Gen III Retina Original Version
My application is compiled using app version: v24
Also I experience performance issues using PDF mode... when you change a page everything is super grainy, and then ~2 Seconds later it renders crisp. It used to be prerendered, or much faster. Perhaps I was using PNG? I switched to PDF mode as recommended in countless articles. Is the slow render just a side affect of PDF? Anything I can do to optimize? Recommendations?
Thanks so much!
Richie

Thank You, Bob!
Vector fixed it! I only have to change it on 29872498329 pages
One thing I just realized is, that I have the same issue with buttons. I have a button with Normal, and Click states. It has the same rendering issue (grainy) and I couldn't find a place to make the button render 'vector'.

Avoiding performance issue due to loop within loop on internal tables

Hi Experts,
I have a requirement where in i want to check whether each of the programs stored in one internal table are called from any of the programs stored in another internal table. In this case i am looping on two internal tables (Loop within a loop) which is causing a major performance issue. Program is running very very slow.
Can any one advise how to resolve this performance issue so that program runs faster.
Thanks in advance.
Regards,
Chetan.

Forget the parallel cursur stuff, it is much to complicated for general usage and helps nearly nothing. I will publish a blog in the next days where this is shown in detail.
Loop on loop is no problem if the inner table is a hashed or sorted table.
If it must be a standard table, then you must make a bit more effort and faciliate a binary search (read binary search / loop from index exit)
see here the exact coding Measurements on internal tables: Reads and Loops:
/people/siegfried.boes/blog/2007/09/12/runtimes-of-reads-and-loops-on-internal-tables
And don't forget, the other table must not be sorted, the loop reaches anyway every line. The parallel cursor requires both tables to be sorted. The additional sort
consumes nearly the whole advantage of the parallel cursor compared to the simple but good loop in loop solutions.
Siegfried

Performance issues with pipelined table functions

I am testing pipelined table functions to be able to re-use the base_query function. Contrary to my understanding, the with_pipeline procedure runs 6 time slower than the legacy no_pipeline procedure. Am I missing something? The processor function is from [url http://www.oracle-developer.net/display.php?id=429]improving performance with pipelined table functions .
Edit: The underlying query returns 500,000 rows in about 3 minutes. So there are are no performance issues with the query itself.
Many thanks in advance.
CREATE OR REPLACE PACKAGE pipeline_example
IS
 TYPE resultset_typ IS REF CURSOR;
 TYPE row_typ IS RECORD (colC VARCHAR2(200), colD VARCHAR2(200), colE VARCHAR2(200));
 TYPE table_typ IS TABLE OF row_typ;
 FUNCTION base_query (argA IN VARCHAR2, argB IN VARCHAR2)
 RETURN resultset_typ;
 c_default_limit CONSTANT PLS_INTEGER := 100;
 FUNCTION processor (
 p_source_data IN resultset_typ,
 p_limit_size IN PLS_INTEGER DEFAULT c_default_limit)
 RETURN table_typ
 PIPELINED
 PARALLEL_ENABLE(PARTITION p_source_data BY ANY);
 PROCEDURE with_pipeline (argA IN VARCHAR2,
 argB IN VARCHAR2,
 o_resultset OUT resultset_typ);
 PROCEDURE no_pipeline (argA IN VARCHAR2,
 argB IN VARCHAR2,
 o_resultset OUT resultset_typ);
END pipeline_example;
CREATE OR REPLACE PACKAGE BODY pipeline_example
IS
 FUNCTION base_query (argA IN VARCHAR2, argB IN VARCHAR2)
 RETURN resultset_typ
 IS
 o_resultset resultset_typ;
 BEGIN
 OPEN o_resultset FOR
 SELECT colC, colD, colE
 FROM some_table
 WHERE colA = ArgA AND colB = argB;
 RETURN o_resultset;
 END base_query;
 FUNCTION processor (
 p_source_data IN resultset_typ,
 p_limit_size IN PLS_INTEGER DEFAULT c_default_limit)
 RETURN table_typ
 PIPELINED
 PARALLEL_ENABLE(PARTITION p_source_data BY ANY)
 IS
 aa_source_data table_typ;-- := table_typ ();
 BEGIN
 LOOP
 FETCH p_source_data
 BULK COLLECT INTO aa_source_data
 LIMIT p_limit_size;
 EXIT WHEN aa_source_data.COUNT = 0;
 /* Process the batch of (p_limit_size) records... */
 FOR i IN 1 .. aa_source_data.COUNT
 LOOP
 PIPE ROW (aa_source_data (i));
 END LOOP;
 END LOOP;
 CLOSE p_source_data;
 RETURN;
 END processor;
 PROCEDURE with_pipeline (argA IN VARCHAR2,
 argB IN VARCHAR2,
 o_resultset OUT resultset_typ)
 IS
 BEGIN
 OPEN o_resultset FOR
 SELECT /*+ PARALLEL(t, 5) */ colC,
 SUM (CASE WHEN colD > colE AND colE != '0' THEN colD / ColE END)de,
 SUM (CASE WHEN colE > colD AND colD != '0' THEN colE / ColD END)ed,
 SUM (CASE WHEN colD = colE AND colD != '0' THEN '1' END) de_one,
 SUM (CASE WHEN colD = '0' OR colE = '0' THEN '0' END) de_zero
 FROM TABLE (processor (base_query (argA, argB),100)) t
 GROUP BY colC
 ORDER BY colC
 END with_pipeline;
 PROCEDURE no_pipeline (argA IN VARCHAR2,
 argB IN VARCHAR2,
 o_resultset OUT resultset_typ)
 IS
 BEGIN
 OPEN o_resultset FOR
 SELECT colC,
 SUM (CASE WHEN colD > colE AND colE != '0' THEN colD / ColE END)de,
 SUM (CASE WHEN colE > colD AND colD != '0' THEN colE / ColD END)ed,
 SUM (CASE WHEN colD = colE AND colD != '0' THEN 1 END) de_one,
 SUM (CASE WHEN colD = '0' OR colE = '0' THEN '0' END) de_zero
 FROM (SELECT colC, colD, colE
 FROM some_table
 WHERE colA = ArgA AND colB = argB)
 GROUP BY colC
 ORDER BY colC;
 END no_pipeline;
END pipeline_example;
ALTER PACKAGE pipeline_example COMPILE;Edited by: Earthlink on Nov 14, 2010 9:47 AM
Edited by: Earthlink on Nov 14, 2010 11:31 AM
Edited by: Earthlink on Nov 14, 2010 11:32 AM
Edited by: Earthlink on Nov 20, 2010 12:04 PM
Edited by: Earthlink on Nov 20, 2010 12:54 PM

Earthlink wrote:
Contrary to my understanding, the with_pipeline procedure runs 6 time slower than the legacy no_pipeline procedure. Am I missing something? Well, we're missing a lot here.
Like:
- a database version
- how did you test
- what data do you have, how is it distributed, indexed
and so on.
If you want to find out what's going on then use a TRACE with wait events.
All nessecary steps are explained in these threads:
HOW TO: Post a SQL statement tuning request - template posting
http://oracle-randolf.blogspot.com/2009/02/basic-sql-statement-performance.html
Another nice one is RUNSTATS:
http://asktom.oracle.com/pls/asktom/ASKTOM.download_file?p_file=6551378329289980701

Performance issues with version enable partitioned tables?

Hi all,
Are there any known performance issues with version enable partitioned tables?
Ive been doing some performance testes with a large version enable partitioned table and it seems that OCB optimiser is choosing very expensive plans during merge operations.
Tanks in advance,
Vitor
Example:
 Object Name Rows Bytes Cost Object Node In/Out PStart PStop
UPDATE STATEMENT Optimizer Mode=CHOOSE 1 249
UPDATE SIG.SIG_QUA_IMG_LT
NESTED LOOPS SEMI 1 266 249
PARTITION RANGE ALL 1 9
TABLE ACCESS FULL SIG.SIG_QUA_IMG_LT 1 259 2 1 9
VIEW SYS.VW_NSO_1 1 7 247
NESTED LOOPS 1 739 247
NESTED LOOPS 1 677 247
NESTED LOOPS 1 412 246
NESTED LOOPS 1 114 244
INDEX RANGE SCAN WMSYS.MODIFIED_TABLES_PK 1 62 2
INDEX RANGE SCAN SIG.QIM_PK 1 52 243
TABLE ACCESS BY GLOBAL INDEX ROWID SIG.SIG_QUA_IMG_LT 1 298 2 ROWID ROW L
INDEX RANGE SCAN SIG.SIG_QUA_IMG_PKI$ 1 1
INDEX RANGE SCAN WMSYS.WM$NEXTVER_TABLE_NV_INDX 1 265 1
INDEX UNIQUE SCAN WMSYS.MODIFIED_TABLES_PK 1 62
/* Formatted on 2004/04/19 18:57 (Formatter Plus v4.8.0) */
UPDATE /*+ USE_NL(Z1) ROWID(Z1) */sig.sig_qua_img_lt z1
SET z1.nextver =
SYS.ltutil.subsversion
(z1.nextver,
SYS.ltutil.getcontainedverinrange (z1.nextver,
'SIG.SIG_QUA_IMG',
'NpCyPCX3dkOAHSuBMjGioQ==',
4574,
4575
4574
WHERE z1.ROWID IN (
(SELECT /*+ ORDERED USE_NL(T1) USE_NL(T2) USE_NL(J2) USE_NL(J3)
INDEX(T1 QIM_PK) INDEX(T2 SIG_QUA_IMG_PKI$)
INDEX(J2 WM$NEXTVER_TABLE_NV_INDX) INDEX(J3 MODIFIED_TABLES_PK) */
t2.ROWID
FROM (SELECT /*+ INDEX(WM$MODIFIED_TABLES MODIFIED_TABLES_PK) */
UNIQUE VERSION
FROM wmsys.wm$modified_tables
WHERE table_name = 'SIG.SIG_QUA_IMG'
AND workspace = 'NpCyPCX3dkOAHSuBMjGioQ=='
AND VERSION > 4574
AND VERSION <= 4575) j1,
sig.sig_qua_img_lt t1,
sig.sig_qua_img_lt t2,
wmsys.wm$nextver_table j2,
(SELECT /*+ INDEX(WM$MODIFIED_TABLES MODIFIED_TABLES_PK) */
UNIQUE VERSION
FROM wmsys.wm$modified_tables
WHERE table_name = 'SIG.SIG_QUA_IMG'
AND workspace = 'NpCyPCX3dkOAHSuBMjGioQ=='
AND VERSION > 4574
AND VERSION <= 4575) j3
WHERE t1.VERSION = j1.VERSION
AND t1.ima_id = t2.ima_id
AND t1.qim_inf_esq_x_tile = t2.qim_inf_esq_x_tile
AND t1.qim_inf_esq_y_tile = t2.qim_inf_esq_y_tile
AND t2.nextver != '-1'
AND t2.nextver = j2.next_vers
AND j2.VERSION = j3.VERSION))

Hello Vitor,
There are currently no known issues with version enabled tables that are partitioned. The merge operation may need to access all of the partitions of a table depending on the data that needs to be moved/copied from the child to the parent. This is the reason for the 'Partition Range All' step in the plan that you provided. The majority of the remaining steps are due to the hints that have been added, since this plan has provided the best performance for us in the past for this particular statement. If this is not the case for you, and you feel that another plan would yield better performance, then please let me know and I will take a look at it.
One suggestion would be to make sure that the table was been recently analyzed so that the optimizer has the most current data about the table.
Performance issues are very hard to fix without a reproducible test case, so it may be advisable to file a TAR if you continue to have significant performance issues with the mergeWorkspace operation.
Thank You,
Ben

Performance Issue For Opening And Closing Balance In FBL1N/3N/5N

Dear experts,
 I Am Having Requirement to Bring Opening And Closing Balance In FBL1N, FBL3N, FBL5N.
For This requirement I Used BADI : FI_ITEMS_CH_DATA~CHANGE_ITEMS, below is my Code For FBL1N, And I've Done the same For 3N/5N...With Related BAPI
* IF SY-TCODE = 'FBL1N'.
* LOOP AT ct_items INTO gs_items.
* CALL FUNCTION 'RP_CALC_DATE_IN_INTERVAL'
* EXPORTING
* date = gs_items-budat
* days = '01'
* months = '00'
* signum = '-'
* years = '00'
* IMPORTING
* calc_date = lv_date.
* CALL FUNCTION 'BAPI_AP_ACC_GETKEYDATEBALANCE'
* EXPORTING
* companycode = gs_items-bukrs
* vendor = gs_items-konto
* keydate = lv_date
** BALANCESPGLI = ' '
** NOTEDITEMS = ' '
** IMPORTING
** RETURN =
* TABLES
* keybalance = lv_obal.
* CALL FUNCTION 'BAPI_AP_ACC_GETKEYDATEBALANCE'
* EXPORTING
* companycode = gs_items-bukrs
* vendor = gs_items-konto
* keydate = gs_items-budat
** BALANCESPGLI = ' '
** NOTEDITEMS = ' '
** IMPORTING
** RETURN =
* TABLES
* keybalance = lv_cbal
* READ TABLE lv_cbal INTO gs_cbal INDEX 1.
* gs_items-cbal = gs_cbal-lc_bal.
* READ TABLE lv_obal INTO gs_obal INDEX 1.
* gs_items-obal = gs_obal-lc_bal.
* MODIFY ct_items FROM gs_items TRANSPORTING obal cbal.
* CLEAR: gs_items,gs_obal,gs_cbal.
* ENDLOOP.
* ENDIF.
So, Above Code Causing Me the Performance Issue, Kindly Suggest Me the Solution..
Regards,
uday.

Hi Uday,
I am sending you the code i used for the creation a Zreport based on FBL5N. Please check if it can of any help.
*& Report ZFBL5N *
REPORT zfbl5n_new .
TABLES : bsid,knc1,lfc1.
TYPE-POOLS: slis.
TYPES: BEGIN OF ty_bsid,
 bukrs TYPE bsid-bukrs,
 kunnr TYPE bsid-kunnr,
 belnr TYPE bsid-belnr,
 buzei TYPE bsid-buzei,
 bldat TYPE bsid-bldat,
 blart TYPE bsid-blart,
 bschl TYPE bsid-bschl,
 shkzg TYPE bsid-shkzg,
 dmbtr TYPE bsid-dmbtr,
 augdt TYPE bsid-augdt,
 augbl TYPE bsid-augbl,
 zuonr TYPE bsid-zuonr,
 sgtxt TYPE bsid-sgtxt,
 zfbdt TYPE bsid-zfbdt,
 zterm TYPE bsid-zterm,
 zbd1t TYPE bsid-zbd1t,
 zbd2t TYPE bsid-zbd2t,
 zbd3t TYPE bsid-zbd3t,
 kkber TYPE bsid-kkber,
 bstat TYPE bsid-bstat,
 umskz TYPE bsid-umskz,
 END OF ty_bsid.
TYPES: BEGIN OF ty_bsik,
 bukrs TYPE bsik-bukrs,
 lifnr TYPE bsik-lifnr,
 belnr TYPE bsik-belnr,
 buzei TYPE bsik-buzei,
 bldat TYPE bsik-bldat,
 blart TYPE bsik-blart,
 bschl TYPE bsik-bschl,
 shkzg TYPE bsik-shkzg,
 dmbtr TYPE bsik-dmbtr,
 augdt TYPE bsik-augdt,
 augbl TYPE bsik-augbl,
 zuonr TYPE bsik-zuonr,
 sgtxt TYPE bsik-sgtxt,
 zfbdt TYPE bsik-zfbdt,
* KKBER TYPE bsik-kkber,
 zterm TYPE bsik-zterm,
 zbd1t TYPE bsik-zbd1t,
 zbd2t TYPE bsik-zbd2t,
 zbd3t TYPE bsik-zbd3t,
 bstat TYPE bsid-bstat,
 umskz TYPE bsid-umskz,
 END OF ty_bsik.
TYPES: BEGIN OF ty_final,
 belnr TYPE bsid-belnr,
* buzei TYPE bsak-buzei,
 bldat TYPE bsid-bldat,
 blart TYPE bsid-blart,
 chq TYPE bsid-zuonr,
 debit TYPE bsid-dmbtr,
 credit TYPE bsid-dmbtr,
 txt TYPE bsid-sgtxt,
 date TYPE bsid-zfbdt,
 kkber TYPE bsid-kkber,
 zterm TYPE bsid-zterm,
 augbl TYPE bsid-augbl,
 augdt TYPE bsid-augdt,
 flag TYPE c,
 END OF ty_final.
TYPES : BEGIN OF gs_openbal,
 bukrs TYPE bapi3007_2-comp_code,
 kunnr TYPE bapi3007_2-customer,
 dmbtr TYPE bapi3007_2-lc_amount,
 END OF gs_openbal.
DATA: it_bsid TYPE STANDARD TABLE OF ty_bsid,
 it_bsik TYPE STANDARD TABLE OF ty_bsik,
 it_final TYPE STANDARD TABLE OF ty_final.
DATA: wa_bsid TYPE ty_bsid,
 wa_bsik TYPE ty_bsik,
 wa_final TYPE ty_final.
DATA: w_days TYPE t5a4a-dlydy,
 w_month TYPE t5a4a-dlymo,
 w_year TYPE t5a4a-dlyyr,
 w_date TYPE p0001-begda,
 w_name1 TYPE kna1-name1,
 w_ort01 TYPE kna1-ort01,
 w_lifnr TYPE kna1-lifnr,
 w_dmbtr1 TYPE bsid-dmbtr,
 w_dmbtr2 TYPE bsid-dmbtr,
 w_dmbtr3 TYPE bsad-dmbtr,
 w_dmbtr4 TYPE bsad-dmbtr,
 w_opbal TYPE bsid-dmbtr,
 w_credit TYPE bsik-dmbtr,
 w_debit TYPE bsik-dmbtr,
 w_clobal TYPE bsik-dmbtr,
 w_credit1 TYPE bsik-dmbtr,
 w_debit1 TYPE bsik-dmbtr,
 w_clobal1 TYPE bsik-dmbtr.
DATA: ld_yrper LIKE rwcoom-fiscper,
 kunnr LIKE kna1-kunnr,
 x_norm TYPE c,
 x_park,
 x_apar,
 x_merk,
 ok_code(4),
 wa_x001 LIKE x001,
 return LIKE bapireturn,
 line_count LIKE sy-loopc,
 number_of_records TYPE i,
 xindex LIKE sy-tabix,
 open LIKE knc1-um01s,
 temp(20),
 close LIKE knc1-um01s,
 gjahr LIKE bsid-gjahr,
 period LIKE bkpf-monat,
 f(1),
 v_char(2),
 closec(20),
 openc(20),
 debit LIKE bapi3007_2-lc_amount,
 credit LIKE debit.
DATA : v_dmbtr LIKE bsid-dmbtr.
*DATA : tot_debit LIKE t_ar-debit,
* tot_credit LIKE t_ar-credit.
DATA : t_kna1 LIKE kna1 OCCURS 1 WITH HEADER LINE,
 t_knb1 LIKE knb1 OCCURS 10 WITH HEADER LINE.
DATA ibsid LIKE bsid OCCURS 0 WITH HEADER LINE.
DATA ibsad LIKE bsad OCCURS 0 WITH HEADER LINE.
DATA ibsik LIKE bsik OCCURS 0 WITH HEADER LINE.
DATA ibsak LIKE bsak OCCURS 0 WITH HEADER LINE.
DATA : it_fieldcat_alv TYPE slis_t_fieldcat_alv,
 wa_fieldcat_alv TYPE slis_fieldcat_alv,
 is_layout_alv TYPE slis_layout_alv,
 wa_layout_alv TYPE slis_layout_alv,
 it_list_top_of_page TYPE slis_t_listheader,
 it_events TYPE slis_t_event,
 wa_events TYPE LINE OF slis_t_event.
DATA : BEGIN OF ibukrs OCCURS 0,
 bukrs LIKE t001-bukrs,
 END OF ibukrs.
DATA : BEGIN OF ikunnr1 OCCURS 0,
 kunnr LIKE knc1-kunnr,
 END OF ikunnr1.
DATA : BEGIN OF ikunnr OCCURS 0,
 kunnr LIKE knc1-kunnr,
 bukrs LIKE t001-bukrs,
 lifnr LIKE lfc1-lifnr,
 END OF ikunnr.
DATA: it_sort TYPE slis_t_sortinfo_alv,
 wa_sort TYPE slis_sortinfo_alv.
DATA: r_bschl TYPE RANGE OF bschl,
 wa_bschl LIKE LINE OF r_bschl.
SELECTION-SCREEN BEGIN OF BLOCK b1 WITH FRAME TITLE text-001.
PARAMETERS : p_kunnr TYPE bsid-kunnr OBLIGATORY,
 p_bukrs TYPE bsid-bukrs OBLIGATORY.
SELECT-OPTIONS: so_budat FOR bsid-budat .
SELECTION-SCREEN END OF BLOCK b1.
SELECTION-SCREEN BEGIN OF BLOCK b2 WITH FRAME TITLE text-002.
PARAMETERS : p_normal AS CHECKBOX,
 p_spl AS CHECKBOX,
 p_vendor AS CHECKBOX.
SELECTION-SCREEN END OF BLOCK b2.
PERFORM get_data.
PERFORM process_data.
*PERFORM calculate_openbal. " Commented by anish
PERFORM calculate_open_bal.
PERFORM calculate_closing_bal.
PERFORM build_catalog_sort USING it_sort.
PERFORM reuse_alv_events_get .
PERFORM display_data.
*& Form GET_DATA
* text
* --> p1 text
* <-- p2 text
FORM get_data .
 SELECT bukrs kunnr belnr buzei bldat blart bschl shkzg dmbtr augdt augbl zuonr sgtxt zfbdt zterm zbd1t zbd2t zbd3t kkber
 bstat umskz FROM bsid
 INTO TABLE it_bsid
 WHERE bukrs = p_bukrs
 AND kunnr = p_kunnr
 AND budat IN so_budat.
 SELECT bukrs kunnr belnr buzei bldat blart bschl shkzg dmbtr augdt augbl zuonr sgtxt zfbdt zterm zbd1t zbd2t zbd3t kkber
 bstat umskz FROM bsad
 APPENDING TABLE it_bsid
 WHERE bukrs = p_bukrs
 AND kunnr = p_kunnr
 AND budat IN so_budat.
 SELECT SINGLE name1 ort01 lifnr FROM kna1
 INTO (w_name1 , w_ort01 , w_lifnr)
 WHERE kunnr = p_kunnr.
 IF p_vendor IS NOT INITIAL.
 SELECT bukrs lifnr belnr buzei bldat blart bschl shkzg dmbtr augdt augbl zuonr sgtxt zfbdt zterm zbd1t zbd2t zbd3t
 bstat umskz FROM bsik
 APPENDING TABLE it_bsik
 WHERE bukrs = p_bukrs
 AND lifnr = w_lifnr
 AND budat IN so_budat.
 SELECT bukrs lifnr belnr buzei bldat blart bschl shkzg dmbtr augdt augbl zuonr sgtxt zfbdt zterm zbd1t zbd2t zbd3t
 bstat umskz FROM bsak
 APPENDING TABLE it_bsik
 WHERE bukrs = p_bukrs
 AND lifnr = w_lifnr
 AND budat IN so_budat.
 ENDIF.
 SORT it_bsid BY bschl.
 DELETE it_bsid WHERE bschl = '04'.
 DELETE it_bsid WHERE bschl = '07'.
 DELETE it_bsid WHERE bschl = '17'.
 DELETE it_bsid WHERE bschl = '34'.
 DELETE it_bsid WHERE bschl = '27'.
 DELETE it_bsid WHERE bschl = '37'.
 SORT it_bsik BY bschl.
 DELETE it_bsik WHERE bschl = '04'.
 DELETE it_bsik WHERE bschl = '07'.
 DELETE it_bsik WHERE bschl = '17'.
 DELETE it_bsik WHERE bschl = '34'.
 DELETE it_bsik WHERE bschl = '27'.
 DELETE it_bsik WHERE bschl = '37'.
ENDFORM. " GET_DATA
*& Form PROCESS_DATA
* text
* --> p1 text
* <-- p2 text
FORM process_data .
 DATA:okay TYPE c VALUE space.
 w_month = '00'.
 w_year = '00'.
 SORT it_bsid BY bldat .
 LOOP AT it_bsid INTO wa_bsid.
 PERFORM check_item_ok USING p_normal
 p_spl
 p_vendor
* x_park
 wa_bsid
 CHANGING okay.
 CHECK okay = 'X'.
 wa_final-belnr = wa_bsid-belnr.
 wa_final-bldat = wa_bsid-bldat.
 wa_final-blart = wa_bsid-blart.
 wa_final-txt = wa_bsid-sgtxt.
 wa_final-kkber = wa_bsid-kkber.
 wa_final-zterm = wa_bsid-zterm.
 wa_final-augbl = wa_bsid-augbl.
 wa_final-augdt = wa_bsid-augdt.
 wa_final-flag = 'C'.
 IF wa_bsid-blart = 'DZ'.
 wa_final-chq = wa_bsid-zuonr.
 ENDIF.
 IF wa_bsid-shkzg = 'S'.
 wa_final-debit = wa_bsid-dmbtr.
 ELSEIF wa_bsid-shkzg = 'H'.
 wa_final-credit = wa_bsid-dmbtr.
 ENDIF.
 w_credit = w_credit + wa_final-credit.
 w_debit = w_debit + wa_final-debit.
****** Net due date
 IF wa_bsid-zbd1t IS NOT INITIAL.
 w_days = wa_bsid-zbd1t.
 ELSEIF wa_bsid-zbd2t IS NOT INITIAL.
 w_days = wa_bsid-zbd2t.
 ELSEIF wa_bsid-zbd3t IS NOT INITIAL.
 w_days = wa_bsid-zbd3t.
 ENDIF.
 IF w_days IS INITIAL.
 wa_final-date = wa_bsid-zfbdt.
 ELSE.
 CALL FUNCTION 'RP_CALC_DATE_IN_INTERVAL'
 EXPORTING
 date = wa_bsid-zfbdt
 days = w_days
 months = w_month
 signum = '+'
 years = w_year
 IMPORTING
 calc_date = w_date.
 wa_final-date = w_date.
 ENDIF.
 APPEND wa_final TO it_final.
 CLEAR: w_days , w_date , wa_final .
 ENDLOOP.
 IF it_bsik IS NOT INITIAL.
 CLEAR: w_days , w_date.
 SORT it_bsik BY bldat.
 LOOP AT it_bsik INTO wa_bsik.
 wa_final-belnr = wa_bsik-belnr.
 wa_final-bldat = wa_bsik-bldat.
 wa_final-blart = wa_bsik-blart.
 wa_final-txt = wa_bsik-sgtxt.
* wa_final-kkber = wa_bsik-kkber.
 wa_final-zterm = wa_bsik-zterm.
 wa_final-augbl = wa_bsik-augbl.
 wa_final-augdt = wa_bsik-augdt.
 wa_final-flag = 'V'.
 IF wa_bsik-blart = 'DZ'.
 wa_final-chq = wa_bsik-zuonr.
 ENDIF.
 IF wa_bsik-shkzg = 'S'.
 wa_final-debit = wa_bsik-dmbtr.
 ELSEIF wa_bsik-shkzg = 'H'.
 wa_final-credit = wa_bsik-dmbtr.
 ENDIF.
 w_credit1 = w_credit1 + wa_final-credit.
 w_debit1 = w_debit1 + wa_final-debit.
******* Net Due date
 IF wa_bsik-zbd1t IS NOT INITIAL.
 w_days = wa_bsik-zbd1t.
 ELSEIF wa_bsik-zbd2t IS NOT INITIAL.
 w_days = wa_bsik-zbd2t.
 ELSEIF wa_bsik-zbd3t IS NOT INITIAL.
 w_days = wa_bsik-zbd3t.
 ENDIF.
 IF w_days IS INITIAL.
 wa_final-date = wa_bsik-zfbdt.
 ELSE.
 CALL FUNCTION 'RP_CALC_DATE_IN_INTERVAL'
 EXPORTING
 date = wa_bsik-zfbdt
 days = w_days
 months = w_month
 signum = '+'
 years = w_year
 IMPORTING
 calc_date = w_date.
 ENDIF.
 wa_final-date = w_date.
 APPEND wa_final TO it_final.
 CLEAR: wa_final.
 ENDLOOP.
 ENDIF.
ENDFORM. " PROCESS_DATA
*& Form DISPLAY_DATA
* text
* --> p1 text
* <-- p2 text
FORM display_data .
 wa_fieldcat_alv-fieldname = 'BELNR'.
 wa_fieldcat_alv-tabname = 'IT_FINAL'.
 wa_fieldcat_alv-seltext_l = text-003.
 wa_fieldcat_alv-outputlen = '11'.
 APPEND wa_fieldcat_alv TO it_fieldcat_alv.
 CLEAR wa_fieldcat_alv.
 wa_fieldcat_alv-fieldname = 'BLDAT'.
 wa_fieldcat_alv-tabname = 'IT_FINAL'.
 wa_fieldcat_alv-seltext_l = text-004.
 wa_fieldcat_alv-outputlen = '13'.
 APPEND wa_fieldcat_alv TO it_fieldcat_alv.
 CLEAR wa_fieldcat_alv.
 wa_fieldcat_alv-fieldname = 'BLART'.
 wa_fieldcat_alv-tabname = 'IT_FINAL'.
 wa_fieldcat_alv-seltext_l = text-005.
 wa_fieldcat_alv-outputlen = '02'.
 APPEND wa_fieldcat_alv TO it_fieldcat_alv.
 CLEAR wa_fieldcat_alv.
 wa_fieldcat_alv-fieldname = 'CHQ'.
 wa_fieldcat_alv-tabname = 'IT_FINAL'.
 wa_fieldcat_alv-seltext_l = text-006.
 wa_fieldcat_alv-outputlen = '09'.
 APPEND wa_fieldcat_alv TO it_fieldcat_alv.
 CLEAR wa_fieldcat_alv.
 wa_fieldcat_alv-fieldname = 'DEBIT'.
 wa_fieldcat_alv-tabname = 'IT_FINAL'.
 wa_fieldcat_alv-seltext_l = text-007.
 wa_fieldcat_alv-outputlen = '15'.
 wa_fieldcat_alv-do_sum = 'X'.
 APPEND wa_fieldcat_alv TO it_fieldcat_alv.
 CLEAR wa_fieldcat_alv.
 wa_fieldcat_alv-fieldname = 'CREDIT'.
 wa_fieldcat_alv-tabname = 'IT_FINAL'.
 wa_fieldcat_alv-seltext_l = text-008.
 wa_fieldcat_alv-outputlen = '15'.
 wa_fieldcat_alv-do_sum = 'X'.
 APPEND wa_fieldcat_alv TO it_fieldcat_alv.
 CLEAR wa_fieldcat_alv.
 wa_fieldcat_alv-fieldname = 'TXT'.
 wa_fieldcat_alv-tabname = 'IT_FINAL'.
 wa_fieldcat_alv-seltext_l = text-009.
 wa_fieldcat_alv-outputlen = '50'.
 APPEND wa_fieldcat_alv TO it_fieldcat_alv.
 CLEAR wa_fieldcat_alv.
 wa_fieldcat_alv-fieldname = 'DATE'.
 wa_fieldcat_alv-tabname = 'IT_FINAL'.
 wa_fieldcat_alv-seltext_l = text-010.
 wa_fieldcat_alv-outputlen = '12'.
 APPEND wa_fieldcat_alv TO it_fieldcat_alv.
 CLEAR wa_fieldcat_alv.
 wa_fieldcat_alv-fieldname = 'KKBER'.
 wa_fieldcat_alv-tabname = 'IT_FINAL'.
 wa_fieldcat_alv-seltext_l = text-011.
 wa_fieldcat_alv-outputlen = '04'.
 APPEND wa_fieldcat_alv TO it_fieldcat_alv.
 CLEAR wa_fieldcat_alv.
 wa_fieldcat_alv-fieldname = 'ZTERM'.
 wa_fieldcat_alv-tabname = 'IT_FINAL'.
 wa_fieldcat_alv-seltext_l = text-012.
 wa_fieldcat_alv-outputlen = '13'.
 APPEND wa_fieldcat_alv TO it_fieldcat_alv.
 CLEAR wa_fieldcat_alv.
 wa_fieldcat_alv-fieldname = 'AUGBL'.
 wa_fieldcat_alv-tabname = 'IT_FINAL'.
 wa_fieldcat_alv-seltext_l = text-013.
 wa_fieldcat_alv-outputlen = '15'.
 APPEND wa_fieldcat_alv TO it_fieldcat_alv.
 CLEAR wa_fieldcat_alv.
 wa_fieldcat_alv-fieldname = 'AUGDT'.
 wa_fieldcat_alv-tabname = 'IT_FINAL'.
 wa_fieldcat_alv-seltext_l = text-014.
 wa_fieldcat_alv-outputlen = '17'.
 APPEND wa_fieldcat_alv TO it_fieldcat_alv.
 CLEAR wa_fieldcat_alv.
 wa_fieldcat_alv-fieldname = 'FLAG'.
 wa_fieldcat_alv-tabname = 'IT_FINAL'.
 wa_fieldcat_alv-tech = 'X'.
 APPEND wa_fieldcat_alv TO it_fieldcat_alv.
 CLEAR wa_fieldcat_alv.
 CALL FUNCTION 'REUSE_ALV_LIST_DISPLAY'
 EXPORTING
 i_callback_program = sy-repid
 is_layout = wa_layout_alv
 it_fieldcat = it_fieldcat_alv
* IT_EXCLUDING =
* IT_SPECIAL_GROUPS =
 it_sort = it_sort
 it_events = it_events
 i_save = 'A'
 TABLES
 t_outtab = it_final
 EXCEPTIONS
 program_error = 1
 OTHERS = 2
 IF sy-subrc <> 0.
* MESSAGE ID SY-MSGID TYPE SY-MSGTY NUMBER SY-MSGNO
* WITH SY-MSGV1 SY-MSGV2 SY-MSGV3 SY-MSGV4.
 ENDIF.
* CALL FUNCTION 'REUSE_ALV_GRID_DISPLAY'
* EXPORTING
* i_callback_program = sy-repid
* i_callback_top_of_page = 'TOP_OF_PAGE'
* is_layout = wa_layout_alv
* it_fieldcat = it_fieldcat_alv
* it_sort = it_sort
*** I_DEFAULT = 'X'
** i_save = 'A'
*** IT_EVENTS =
* TABLES
* t_outtab = it_final
* EXCEPTIONS
* program_error = 1
* OTHERS = 2
* IF sy-subrc <> 0.
*** MESSAGE ID SY-MSGID TYPE SY-MSGTY NUMBER SY-MSGNO
*** WITH SY-MSGV1 SY-MSGV2 SY-MSGV3 SY-MSGV4.
* ENDIF.
ENDFORM. " DISPLAY_DATA
*& Form TOP_OF_PAGE
* Header at top of page.
FORM top_of_page.
 SKIP 1.
 WRITE: AT 35 'Account Statement from' , so_budat-low , 'to' , so_budat-high.
 SKIP 2.
 WRITE: AT /5 'CUSTOMER:' , p_kunnr.
 WRITE: AT 35 'Name:' , w_name1.
 WRITE: AT /5 'Company:' , p_bukrs.
 WRITE: AT 35 'City:' , w_ort01.
 SKIP 1.
 WRITE: AT /5 'Opening Balance as on' , so_budat-low , ' ' , w_opbal LEFT-JUSTIFIED.
 SKIP 2.
ENDFORM. "TOP_OF_PAGE
*& Form END_OF_PAGE
* Footer at End of page.
FORM end_of_page.
 SKIP 2.
 IF so_budat-high IS NOT INITIAL.
 WRITE: AT 5 'Closing Balance as on' , so_budat-high , ' ' , w_clobal LEFT-JUSTIFIED.
 ELSE.
 WRITE: AT 5 'Closing Balance ' , w_clobal LEFT-JUSTIFIED.
 ENDIF.
ENDFORM. "end_of_page
*& Form CALCULATE_OPENBAL
* text
* --> p1 text
* <-- p2 text
FORM calculate_openbal .
 DATA:v_gjahr TYPE bsid-gjahr.
 DATA: v_period LIKE t009b-poper,v_monat LIKE t001-periv.
 CALL FUNCTION 'FI_PERIOD_DETERMINE'
 EXPORTING
 i_budat = so_budat-low
 i_bukrs = p_bukrs
* I_PERIV = ' '
* I_GJAHR = 0000
* I_MONAT = 00
* X_XMO16 = ' '
 IMPORTING
 e_gjahr = v_gjahr
* e_monat = v_monat
 e_poper = v_period.
 IF sy-subrc NE 0.
 ENDIF.
 DATA: f_date LIKE sy-datum.
 CALL FUNCTION 'FIRST_DAY_IN_PERIOD_GET'
 EXPORTING
 i_gjahr = v_gjahr
 i_monmit = 00
 i_periv = 'V3'
 i_poper = v_period
 IMPORTING
 e_date = f_date.
 period = v_period - 1.
 gjahr = v_gjahr.
 DATA wa_kna1 LIKE kna1.
 CALL FUNCTION 'READ_KNA1'
 EXPORTING
 xkunnr = p_kunnr
 IMPORTING
 xkna1 = wa_kna1
 EXCEPTIONS
 key_incomplete = 1
 not_authorized = 2
 not_found = 3
 OTHERS = 4.
 IF sy-subrc <> 0.
 MESSAGE w023(zwww).
 CALL SCREEN 0010.
 ENDIF.
 MOVE-CORRESPONDING wa_kna1 TO t_kna1.
 APPEND t_kna1.
 SELECT kunnr FROM kna1 INTO TABLE ikunnr1
 WHERE kunnr = p_kunnr.
 SELECT bukrs FROM t001 INTO TABLE ibukrs
 FOR ALL ENTRIES IN t_knb1
 WHERE bukrs = t_knb1-bukrs.
 LOOP AT ikunnr1.
 LOOP AT ibukrs.
 ikunnr-kunnr = ikunnr1-kunnr.
 ikunnr-bukrs = ibukrs-bukrs.
 READ TABLE t_kna1 WITH KEY kunnr = ikunnr1-kunnr.
 ikunnr-lifnr = t_kna1-lifnr.
 APPEND ikunnr.
 ENDLOOP.
 ENDLOOP.
 DELETE ikunnr WHERE bukrs NE p_bukrs.
 LOOP AT ikunnr.
 CLEAR: knc1,lfc1,f.
 IF NOT ( ikunnr-kunnr IS INITIAL ) AND NOT ( p_vendor IS INITIAL ).
 SELECT SINGLE * FROM lfc1
 WHERE gjahr = gjahr AND bukrs = ikunnr-bukrs
 AND lifnr = ikunnr-lifnr.
 ENDIF.
 SELECT SINGLE * FROM knc1
 WHERE gjahr = gjahr AND bukrs = p_bukrs
 AND kunnr = p_kunnr.
 IF sy-subrc = 0.
 CASE period .
 WHEN 12.
 open = knc1-umsav +
 knc1-um01s - knc1-um01h + knc1-um02s - knc1-um02h +
 knc1-um03s - knc1-um03h + knc1-um04s - knc1-um04h +
 knc1-um05s - knc1-um05h + knc1-um06s - knc1-um06h +
 knc1-um07s - knc1-um07h + knc1-um08s - knc1-um08h +
 knc1-um09s - knc1-um09h + knc1-um10s - knc1-um10h +
 knc1-um11s - knc1-um11h + knc1-um12s - knc1-um12h.
 IF NOT ( lfc1 IS INITIAL ).
 open = open + lfc1-umsav +
 lfc1-um01s - lfc1-um01h + lfc1-um02s - lfc1-um02h +
 lfc1-um03s - lfc1-um03h + lfc1-um04s - lfc1-um04h +
 lfc1-um05s - lfc1-um05h + lfc1-um06s - lfc1-um06h +
 lfc1-um07s - lfc1-um07h + lfc1-um08s - lfc1-um08h +
 lfc1-um09s - lfc1-um09h + lfc1-um10s - lfc1-um10h +
 lfc1-um11s - lfc1-um11h + lfc1-um12s - lfc1-um12h.
 ENDIF.
 WHEN 11.
 open = knc1-umsav +
 knc1-um01s - knc1-um01h + knc1-um02s - knc1-um02h +
 knc1-um03s - knc1-um03h + knc1-um04s - knc1-um04h +
 knc1-um05s - knc1-um05h + knc1-um06s - knc1-um06h +
 knc1-um07s - knc1-um07h + knc1-um08s - knc1-um08h +
 knc1-um09s - knc1-um09h + knc1-um10s - knc1-um10h +
 knc1-um11s - knc1-um11h.
 IF NOT ( lfc1 IS INITIAL ) .
 open = open + lfc1-umsav +
 lfc1-um01s - lfc1-um01h + lfc1-um02s - lfc1-um02h +
 lfc1-um03s - lfc1-um03h + lfc1-um04s - lfc1-um04h +
 lfc1-um05s - lfc1-um05h + lfc1-um06s - lfc1-um06h +
 lfc1-um07s - lfc1-um07h + lfc1-um08s - lfc1-um08h +
 lfc1-um09s - lfc1-um09h + lfc1-um10s - lfc1-um10h +
 lfc1-um11s - lfc1-um11h.
 ENDIF.
 WHEN 10.
 open = knc1-umsav +
 knc1-um01s - knc1-um01h + knc1-um02s - knc1-um02h +
 knc1-um03s - knc1-um03h + knc1-um04s - knc1-um04h +
 knc1-um05s - knc1-um05h + knc1-um06s - knc1-um06h +
 knc1-um07s - knc1-um07h + knc1-um08s - knc1-um08h +
 knc1-um09s - knc1-um09h + knc1-um10s - knc1-um10h .
 IF NOT ( lfc1 IS INITIAL ) .
 open = open + lfc1-umsav +
 lfc1-um01s - lfc1-um01h + lfc1-um02s - lfc1-um02h +
 lfc1-um03s - lfc1-um03h + lfc1-um04s - lfc1-um04h +
 lfc1-um05s - lfc1-um05h + lfc1-um06s - lfc1-um06h +
 lfc1-um07s - lfc1-um07h + lfc1-um08s - lfc1-um08h +
 lfc1-um09s - lfc1-um09h + lfc1-um10s - lfc1-um10h.
 ENDIF.
 WHEN 9.
 open = knc1-umsav +
 knc1-um01s - knc1-um01h + knc1-um02s - knc1-um02h +
 knc1-um03s - knc1-um03h + knc1-um04s - knc1-um04h +
 knc1-um05s - knc1-um05h + knc1-um06s - knc1-um06h +
 knc1-um07s - knc1-um07h + knc1-um08s - knc1-um08h +
 knc1-um09s - knc1-um09h .
 IF NOT ( lfc1 IS INITIAL ) .
 open = open + lfc1-umsav +
 lfc1-um01s - lfc1-um01h + lfc1-um02s - lfc1-um02h +
 lfc1-um03s - lfc1-um03h + lfc1-um04s - lfc1-um04h +
 lfc1-um05s - lfc1-um05h + lfc1-um06s - lfc1-um06h +
 lfc1-um07s - lfc1-um07h + lfc1-um08s - lfc1-um08h +
 lfc1-um09s - lfc1-um09h.
 ENDIF.
 WHEN 8.
 open = knc1-umsav +
 knc1-um01s - knc1-um01h + knc1-um02s - knc1-um02h +
 knc1-um03s - knc1-um03h + knc1-um04s - knc1-um04h +
 knc1-um05s - knc1-um05h + knc1-um06s - knc1-um06h +
 knc1-um07s - knc1-um07h + knc1-um08s - knc1-um08h.
 IF NOT ( lfc1 IS INITIAL ) .
 open = open + lfc1-umsav +
 lfc1-um01s - lfc1-um01h + lfc1-um02s - lfc1-um02h +
 lfc1-um03s - lfc1-um03h + lfc1-um04s - lfc1-um04h +
 lfc1-um05s - lfc1-um05h + lfc1-um06s - lfc1-um06h +
 lfc1-um07s - lfc1-um07h + lfc1-um08s - lfc1-um08h .
 ENDIF.
 WHEN 7.
 open = knc1-umsav +
 knc1-um01s - knc1-um01h + knc1-um02s - knc1-um02h +
 knc1-um03s - knc1-um03h + knc1-um04s - knc1-um04h +
 knc1-um05s - knc1-um05h + knc1-um06s - knc1-um06h +
 knc1-um07s - knc1-um07h .
 IF NOT ( lfc1 IS INITIAL ) .
 open = open + lfc1-umsav +
 lfc1-um01s - lfc1-um01h + lfc1-um02s - lfc1-um02h +
 lfc1-um03s - lfc1-um03h + lfc1-um04s - lfc1-um04h +
 lfc1-um05s - lfc1-um

Performance issue in Loop statement.

Similar Messages

Maybe you are looking for