Performance of the Insertion

Question

Hi,
I have a procedure which inserts 3 million Records into the table.
Whole insertion process is taking 15-17 minutes .
Oracle version  :- Oracle Database 11g Enterprise Edition Release 11.2.0.3.0 - 64bit
I have tried using Bulk Collect with Limit 50,000 which is not making much difference as I cannot use forall for insertion.
I have also tried with Insert select which again is not making difference .
Can you please suggest me what else I can try to improve the Performance .
Befor insertion I am Disabling the primary key of the table.
For your reference I am giving code below.
--create statement
create table tmp_tab
  tmp_id NUMBER,
  tmp_cod VARCHAR2(32),
  tmp_date          DATE,
  tmp_num    NUMBER,
  tmp_num1       NUMBER
create index Idx_tmp on tmp_tab(tmp_id,tmp_num1);
create table hs_bad
  bad_seq_id            NUMBER,
  bad_id NUMBER,
  bad_cod      VARCHAR2(32),
  bad_date          DATE,
  bad_num    NUMBER,
  bad_num1       NUMBER,
  bad_err_code      VARCHAR2(20),
  bad_message       VARCHAR2(500)
create table hs_corr
  corr_Seq_id            NUMBER not null,
  corr_id        NUMBER,
  corr_cod      VARCHAR2(32),
  corr_date          DATE,
  corr_num    NUMBER,
  corr_num1       NUMBER
alter table hs_corr add constraint corr_pk primary key (corr_Seq_id);
create sequence seq_bad_id;
create sequence seq_corr_id;
----Block which inserts
declare
l_err_code   varchar2(10);
l_err_message varchar2(10);
l_err_rec number ;
l_ok_rec number ;
begin
  for l_cur in (select tmp_id,
                       tmp_cod,
                       tmp_date,
                       tmp_num,
                       tmp_num1,
                       count(*) over(partition by tmp_cod, tmp_date) cnt
                  from (select distinct tmp_id,
                                        tmp_cod,
                                        tmp_date,
                                        tmp_num,
                                        tmp_num1
                          from tmp_tab
                         where tmp_id = 4436
                           and (tmp_num1 <> 0 or tmp_num1 is null))) loop
    if l_cur.tmp_num1 is null or l_cur.tmp_num1 <> 1 or
       l_cur.tmp_date is null or l_cur.tmp_num is null or
       l_cur.tmp_cod is null or l_cur.cnt <> 1 then
      if l_cur.tmp_cod is null then
        l_err_code    := '00020';
        l_err_message := 'error 20';
      elsif (l_cur.tmp_num is null or l_cur.tmp_date is null) then
        l_err_code    := '00023';
        l_err_message := 'error 23';
      elsif (l_cur.tmp_num1 is null or l_cur.tmp_num1 <> 1) then
        l_err_code    := '00024';
        l_err_message := 'error 24';
      elsif l_cur.cnt <> 1 then
        l_err_code    := '00025';
        l_err_message := 'error 25';
      end if;
      insert into hs_bad
        (bad_seq_id,
         bad_id,
         bad_cod,
         bad_date,
         bad_num,
         bad_num1,
         bad_err_code,
         bad_message)
      values
        (seq_bad_id.nextval,
         l_cur.tmp_id,
         l_cur.tmp_cod,
         l_cur.tmp_date,
         l_cur.tmp_num,
         l_cur.tmp_num1,
         l_err_code,
         l_err_message);
      l_err_rec := l_err_rec + 1;
    else
      insert into hs_corr
        (corr_Seq_id, corr_id, corr_cod, corr_date, corr_num, corr_num1)
      values
        (seq_corr_id.nextval,
         l_cur.tmp_id,
         l_cur.tmp_cod,
         l_cur.tmp_date,
         l_cur.tmp_num,
         1);
      l_ok_rec := l_ok_rec + 1;
    end if;
  end loop;
commit;
end;
---insert statement for tmp_bad (I have 3 million such records for reference I am giving 22 records)
insert into tmp_tab (tmp_id, tmp_cod, tmp_date, tmp_num, tmp_num1)
values (4436, 'ABCD84043451', to_date('26-03-2014', 'dd-mm-yyyy'), 1.0029237, 1);
insert into tmp_tab (tmp_id, tmp_cod, tmp_date, tmp_num, tmp_num1)
values (4436, 'ABCD84043451', to_date('25-03-2014', 'dd-mm-yyyy'), 1.0009655, 1);
insert into tmp_tab (tmp_id, tmp_cod, tmp_date, tmp_num, tmp_num1)
values (4436, 'ABCD84043451', to_date('24-03-2014', 'dd-mm-yyyy'), 1.0036647, 1);
insert into tmp_tab (tmp_id, tmp_cod, tmp_date, tmp_num, tmp_num1)
values (4436, 'ABCD84043451', to_date('21-03-2014', 'dd-mm-yyyy'), 1.0007618, 1);
insert into tmp_tab (tmp_id, tmp_cod, tmp_date, tmp_num, tmp_num1)
values (4436, 'ABCD84043451', to_date('20-03-2014', 'dd-mm-yyyy'), 0.99546863, 1);
insert into tmp_tab (tmp_id, tmp_cod, tmp_date, tmp_num, tmp_num1)
values (4436, 'ABCD84043451', to_date('19-03-2014', 'dd-mm-yyyy'), 0.99925022, 1);
insert into tmp_tab (tmp_id, tmp_cod, tmp_date, tmp_num, tmp_num1)
values (4436, 'ABCD84043451', to_date('18-03-2014', 'dd-mm-yyyy'), 1.0008772, 1);
insert into tmp_tab (tmp_id, tmp_cod, tmp_date, tmp_num, tmp_num1)
values (4436, 'ABCD84043451', to_date('17-03-2014', 'dd-mm-yyyy'), 0.99927982, 1);
insert into tmp_tab (tmp_id, tmp_cod, tmp_date, tmp_num, tmp_num1)
values (4436, 'ABCD84043451', to_date('14-03-2014', 'dd-mm-yyyy'), 0.99545721, 1);
insert into tmp_tab (tmp_id, tmp_cod, tmp_date, tmp_num, tmp_num1)
values (4436, 'ABCD84043451', to_date('13-03-2014', 'dd-mm-yyyy'), 1.0035274, 1);
insert into tmp_tab (tmp_id, tmp_cod, tmp_date, tmp_num, tmp_num1)
values (4436, 'ABCD84043451', to_date('12-03-2014', 'dd-mm-yyyy'), 1.0028031, 1);
insert into tmp_tab (tmp_id, tmp_cod, tmp_date, tmp_num, tmp_num1)
values (4436, 'ABCD84043451', to_date('11-03-2014', 'dd-mm-yyyy'), 0.99607308, 1);
insert into tmp_tab (tmp_id, tmp_cod, tmp_date, tmp_num, tmp_num1)
values (4436, 'ABCD84043451', to_date('10-03-2014', 'dd-mm-yyyy'), 1.005378, 1);
insert into tmp_tab (tmp_id, tmp_cod, tmp_date, tmp_num, tmp_num1)
values (4436, 'ABCD84043451', to_date('07-03-2014', 'dd-mm-yyyy'), 1.0011711, 1);
insert into tmp_tab (tmp_id, tmp_cod, tmp_date, tmp_num, tmp_num1)
values (4436, 'ABCD84043451', to_date('06-03-2014', 'dd-mm-yyyy'), 0.99464087, 1);
insert into tmp_tab (tmp_id, tmp_cod, tmp_date, tmp_num, tmp_num1)
values (4436, 'ABCD84043451', to_date('05-03-2014', 'dd-mm-yyyy'), 1.00101, 1);
insert into tmp_tab (tmp_id, tmp_cod, tmp_date, tmp_num, tmp_num1)
values (4436, 'ABCD84043451', to_date('04-03-2014', 'dd-mm-yyyy'), 0.99421354, 1);
insert into tmp_tab (tmp_id, tmp_cod, tmp_date, tmp_num, tmp_num1)
values (4436, 'ABCD84043451', to_date('03-03-2014', 'dd-mm-yyyy'), 1.0110608, 1);
insert into tmp_tab (tmp_id, tmp_cod, tmp_date, tmp_num, tmp_num1)
values (4436, 'ABCD84043451', to_date('28-02-2014', 'dd-mm-yyyy'), 0.98747385, 1);
insert into tmp_tab (tmp_id, tmp_cod, tmp_date, tmp_num, tmp_num1)
values (4436, 'ABCD84043451', to_date('27-02-2014', 'dd-mm-yyyy'), 1.0049316, 1);
insert into tmp_tab (tmp_id, tmp_cod, tmp_date, tmp_num, tmp_num1)
values (4436, 'ABCD84043451', to_date('26-02-2014', 'dd-mm-yyyy'), 1.0042771, 1);
insert into tmp_tab (tmp_id, tmp_cod, tmp_date, tmp_num, tmp_num1)
values (4436, 'ABCD84043451', to_date('25-02-2014', 'dd-mm-yyyy'), null, 1);
commit;
Thanks in advance

Answer 1

The hs_bad part:
          INSERT INTO hs_bad (bad_seq_id, bad_id, bad_cod, bad_date, bad_num, bad_num1, bad_err_code, bad_message)
          SELECT seq_bad_id.nextval AS bad_seq_id
                ,tmp_id
                ,tmp_cod
                ,tmp_date
                ,tmp_num
                ,tmp_num1
                ,TO_CHAR(error_num,'FM00000')
                ,NULLIF('error ' || TO_CHAR(error_num),'error ')
            from (    SELECT tmp_id
                            ,tmp_cod
                            ,tmp_date
                            ,tmp_num
                            ,tmp_num1
                            ,CASE
                                WHEN tmp_cod  IS NULL                     THEN 20
                                WHEN tmp_num  IS NULL OR tmp_date IS NULL THEN 23
                                WHEN tmp_num1 IS NULL OR tmp_num1 <> 1    THEN 24
                                WHEN cnt      <> 1                        THEN 25
                             END AS error_num
                        FROM (SELECT tmp_id
                                   , tmp_cod
                                   , tmp_date
                                   , tmp_num
                                   , tmp_num1
                                   , COUNT(*) over(partition BY tmp_cod, tmp_date) cnt
                                FROM tmp_tab
                               WHERE tmp_id = 4436
                                 AND (tmp_num1 <> 0 OR tmp_num1 IS NULL)
                               GROUP BY tmp_id, tmp_cod, tmp_date, tmp_num, tmp_num1)
                       WHERE tmp_num1 IS NULL
                          OR tmp_num1 <> 1
                          OR tmp_date IS NULL
                          OR tmp_num  IS NULL
                          OR tmp_cod  IS NULL
                          OR cnt      <> 1);
the hs_corr part:
          INSERT INTO hs_corr (corr_Seq_id, corr_id, corr_cod, corr_date, corr_num, corr_num1)
          SELECT seq_corr_id.nextval AS bad_seq_id
                ,tmp_id
                ,tmp_cod
                ,tmp_date
                ,tmp_num
                ,tmp_num1
            FROM (SELECT tmp_id
                       , tmp_cod
                       , tmp_date
                       , tmp_num
                       , tmp_num1
                       , COUNT(*) over(partition BY tmp_cod, tmp_date) cnt
                    FROM tmp_tab
                   WHERE tmp_id = 4436
                     AND (tmp_num1 <> 0 OR tmp_num1 IS NULL)
                   GROUP BY tmp_id, tmp_cod, tmp_date, tmp_num, tmp_num1)
           WHERE NOT (   tmp_num1 IS NULL
                      OR tmp_num1 <> 1
                      OR tmp_date IS NULL
                      OR tmp_num  IS NULL
                      OR tmp_cod  IS NULL
                      OR cnt      <> 1);
hth