Performance problem creating rows on viewobject

Question

Hi,
When a user pushes a button in my Oracle ADF 11.1.1.3.0 GUI,
he triggers a method in my backing bean.
This method is called insertNewForecastTable, that takes a (Tree)Map called forecastMap as input. (see below)
( The key of this map is a Timestamp,
the value of this map is an object ForecastEntry.
A ForecastEntry consists out of 10 ForecastParts, and each Forecastpart contains 4 long values. )
private void insertNewForecastTable(Map forecastMap) {
DCBindingContainer bc = (DCBindingContainer)getBindings();
DCIteratorBinding ForecastIter = bc.findIteratorBinding("ForecastViewIterator");
DCDataControl dc = ForecastIter.getDataControl();
ApplicationModule am = (ApplicationModule)dc.getDataProvider();
ViewObject forecastVO = am.findViewObject("ForecastView");
Set keys = forecastMap.keySet();
Iterator keyIter = keys.iterator();
RowSetIterator it = ForecastIter.getRowSetIterator();
while (keyIter.hasNext()) {
Long timestamp = (Long)keyIter.next();
Timestamp ts = new Timestamp(timestamp);
Row r = it.createRow();
r.setAttribute(0, ts);
ForecastEntry forecastentry = (ForecastEntry)forecastMap.get(timestamp);
int j = 1;
for (int i=0;i<10;i++) {
ForecastPart forecastPart = forecastentry.getForecastPart(i);
r.setAttribute(j,forecastPart.getHistory());
j++;
r.setAttribute(j,forecastPart.getForecast());
j++;
r.setAttribute(j,forecastPart.getTrend());
j++;
r.setAttribute(j,forecastPart.getLimit());
j++;
forecastVO.insertRow(r);
am.getTransaction().commit();
Configuration.releaseRootApplicationModule(am,true);
Problem is : for 3360 entries in this table or viewobject, it takes 10 minutes (!!!) to complete this code.
Bottleneck is the for-loop and the forecastVO.insertRow(r);
Both timings are rising from 15 msec in the beginning to 500 msec at the end.
Anyone has some ideas how to improve my performance ?
Am I doing something wrong trying to create and insert 3360 rows in this table ?
Thanks.

Answer 1

Ok,
My binding is back ok, so the nullpointer is gone.
But the speed of processing 1000+ inserts into a table is still very poor.
This is my code at the moment :
  +private void insertNewForecastTable(Map forecastMap) {+
    +DCBindingContainer bc = (DCBindingContainer)getBindings();+
    +DCIteratorBinding ForecastIter = bc.findIteratorBinding("ForecastViewIterator");+
    +DCDataControl dc  = ForecastIter.getDataControl();+
    +ApplicationModule am = (ApplicationModule)dc.getDataProvider();+
    +ViewObject forecastVO = am.findViewObject("ForecastView");+ 
    +RowSetIterator it = ForecastIter.getRowSetIterator();+
    +Set keys = forecastMap.keySet();+        
    +Iterator keyIter = keys.iterator();+
    +List nameList = new ArrayList();+
    +nameList.add("Timestamp");+
    +for (int i=1 ; i<=10; i ++) {+
      +String H = "H"+i;+
      +String F = "F"+i;+
      +String T = "T"+i;+
      +String L = "L"+i;+
      +nameList.add(H);+
      +nameList.add(F);+
      +nameList.add(T);+
      +nameList.add(L);+
    +}+
    +long time_begin = System.currentTimeMillis();+
    +int counter = 0;+
    +// for each timestamp+
    +while (keyIter.hasNext()) {+
      +// Get the timestamp.+
       +Long timestamp = (Long)keyIter.next();+
       +// convert long to timestamp+
       +Timestamp ts = new Timestamp(timestamp);+
       +// create new row in table+
       +Row r = it.createRow();+
      +List valueList = new ArrayList();+
      +valueList.add(ts);+
      +ForecastEntry forecastentry = (ForecastEntry)forecastMap.get(timestamp);+
      +for (int i=0;i<10;i++) {+
          +ForecastPart forecastPart = forecastentry.getForecastPart(i);+
          +valueList.add(forecastPart.getHistory());+
          +valueList.add(forecastPart.getForecast());+
          +valueList.add(forecastPart.getTrend());+
          +valueList.add(forecastPart.getLimit());+
      +}+
      +r.setAttributeValues(nameList, valueList);+
      +forecastVO.insertRow(r);+
      +counter++;+
      +if (counter % 100 == 0) {+
        +am.getTransaction().commit();+
        +System.out.println("Committing rows " + (counter-100) + " to " + counter );+
      +}+
    +}+
    +long time_end = System.currentTimeMillis();+
    +// commit+
    +am.getTransaction().commit();+
   +// Configuration.releaseRootApplicationModule(am,true);+
    +System.out.println("Total time to insert all rows : " + (time_end-time_begin ));+
  +}+It takes up to 500 seconds to insert 3000 rows !
I also changed the update batch value from 100 to 5, but no difference.
I'm now also committing every 100 rows.
And at the end, I get a nullpointer exception at RowDataManager.getRowIndex(RowDataManager.java:191)
All help welcome.