Performance tuning required

Question

The table contains 2 crores of records
Its taking lot of time to get executed.
please suggest to improve the performance
The execution of this query taking lot of time in the below procedure
UPDATE ctrl_settled_shipments
SET
msrbnr = v_document_ids (i),
msrdat = SYSDATE
WHERE msdgnr = v_consignment_ids (i) AND msrbnr IS NULL;
PROCEDURE proctest(
data_source IN VARCHAR2,
toll_flag IN NUMBER,
damage_status IN NUMBER,
execid IN NUMBER,
msg OUT VARCHAR2
As
UPDATE controlling
SET
-- MSREKO= rec.lv_consignment_amount,
msrbnr = v_document_ids (i),
msrdat = SYSDATE
WHERE msdgnr = v_consignment_ids (i) AND msrbnr IS NULL;
lv_document_no NUMBER;
lv_consignment_number NUMBER;
lv_consignment_amount NUMBER;
lv_doc_type VARCHAR2 (2);
lv_damage_amount NUMBER;
lv_ilnbetr NUMBER;
lv_spedbetr NUMBER;
lv_spedbetr_flag NUMBER;
lv_ilnbetr_flag NUMBER;
c_consigment_numbers billing_pkg.cursor_typ;
TYPE t_num_array IS TABLE OF NUMBER
INDEX BY BINARY_INTEGER;
TYPE t_char_array IS TABLE OF VARCHAR2 (20)
INDEX BY BINARY_INTEGER;
v_consignment_ids t_char_array;
v_document_ids t_num_array;
v_doc_type_ids t_char_array;
v_consignment_amts t_num_array;
v_spedbetr_amts t_num_array;
v_ilnbetr_amts t_num_array;
v_spedbetr_flags t_num_array;
v_ilnbetr_flags t_num_array;
v_row_count NUMBER := 0;
ort varchar2(50);
cons_query varchar2(1000);
pctx bl_plog.log_ctx
:= bl_plog.init ('BL_UPDATED_CONTROLLING', plevel => bl_plog.LINFO);--NP
BEGIN
pctx.lsubsection := ''||execid;
BL_PLOG.INFO(pctx,' data_source ' || data_source);
IF UPPER (data_source) = 'CONTROLLING' THEN
cons_query :=
' SELECT document_no AS lv_document_no,
blc.msdgnr AS lv_consignment_number,
doc_type AS lv_doc_type,
0 AS lv_consignment_amount,
0 AS lv_ilnbetr,
0 AS lv_spedbetr,
0 AS lv_spedbetr_flag,
0 AS lv_ilnbetr_flag
FROM tmp_header_position_amount1,bl_controlling blc
WHERE document_no IS NOT NULL
and document_no = decode(doc_type,''R'',msrbnr,''G'',msgbnr)
and blc.exec_id = '||execid;
ELSIF UPPER (data_source) = 'BL_CONT_SCHADEN' THEN
cons_query :=
'SELECT document_no AS lv_document_no,
bcs.bcs_msdgnr AS lv_consignment_number,
doc_type AS lv_doc_type,
decode(doc_type,''R'',bcs_msreko,''G'',bcs_msguko) AS lv_consignment_amount,
nvl(bcs.bcs_ilnbetr,0) AS lv_ilnbetr,
nvl(bcs.bcs_spedbetr,0) AS lv_spedbetr,
bcs.bcs_spedbetr_flag AS lv_spedbetr_flag,
bcs.bcs_ilnbetr_flag AS lv_ilnbetr_flag
FROM tmp_header_position_amount1,bl_cont_schaden bcs
WHERE document_no IS NOT NULL
and document_no = decode(doc_type,''R'',bcs_msrbnr,''G'',bcs_msgbnr)
and bcs.exec_id = '||execid;
END IF;
OPEN c_consigment_numbers FOR cons_query;
LOOP
FETCH c_consigment_numbers
BULK COLLECT INTO v_document_ids, v_consignment_ids,
v_doc_type_ids, v_consignment_amts, v_ilnbetr_amts,
v_spedbetr_amts, v_spedbetr_flags, v_ilnbetr_flags LIMIT 200;
EXIT WHEN v_row_count = c_consigment_numbers%ROWCOUNT;
v_row_count := c_consigment_numbers%ROWCOUNT;
FOR i IN 1 .. v_consignment_ids.COUNT
LOOP
--IF UPPER (data_source) ='CONTROLLING' AND rec.lv_doc_type = Billing_Pkg.BILL THEN
IF UPPER (data_source) = 'CONTROLLING'
AND v_doc_type_ids (i) = billing_pkg.bill
THEN
UPDATE ctrl_settled_shipments
SET
msrbnr = v_document_ids (i),
msrdat = SYSDATE
WHERE msdgnr = v_consignment_ids (i) AND msrbnr IS NULL;
end if;
commit;
end loop;
EXCEPTION
WHEN OTHERS
THEN
msg:='records failed to update'||sqlerrm;
rollback;
end proctest;
Edited by: 812809 on 9 Jul, 2011 5:48 AM

Answer 1

You think your problem is the UPDATE? How long does a SINGLE update take? Ever tried? Did you run a trace followed by TKPROF?
Your problem is that you use a lot of code, nested loops, dynamic SQL etc. when you can do the update with a singe MERGE command, which will reduce to less than 10% of your code and be VERY much faster.
something like this. (If I got the idea of your code correct)
MERGE INTO ctrl_settled_shipments X
USING (
SELECT document_no AS lv_document_no,
   blc.msdgnr AS lv_consignment_number,
   doc_type AS lv_doc_type,
   s.rowid rid
FROM tmp_header_position_amount1,
      bl_controlling blc,
       ctrl_settled_shipments s
WHERE document_no IS NOT NULL
   and document_no = decode(doc_type,''R'',msrbnr,''G'',msgbnr)
and blc.exec_id = execid
and s.msdgnr = blc.msdgnr AND s.msrbnr IS NULL) Y
on x.rowid = y.rid
  WHEN MATCHED THEN UPDATE
   msrbnr = lv_document_no,
   msrdat = SYSDATE;