Photoshop sometimes freezes after on close ('Cls ') event script

Question

Hi!
We are working on integrating Photoshop with a content management system. For this we are using a synchronisation file. The cms writes the filepath of pictures to be edited to the sync file. Photoshop writes a modified flag to the sync file and/or a closed flag after work is done. This is implemented by an on save ('save') and an on close ('Cls ') event script.
The scripts are doing fine and the whole system is working. Now our problem: Sometimes (every 50 or 100 pictures) Photshop hangs up after closing a picture.
As far as we can conclude from the sync file and log file the close event script did complete its work without problem in such a case. But after that Photoshop freezes with doing 50% CPU load.
Has anyone an idea what we could be doing wrong? May it have to do with the file access of our scripts (sync file and log file)? Is there any common mistake with scripting that results in the described behaviour? Is this even a problem of our scripts?
For everyone interested I attached the scripts copied together to a single text file.
Thanks for your help,
  Eric

Answer 1

Beolw the complete source code. Attached file in my first posting seems not to be working ("QUEUED"?).
// The only script to be called by MRS when starting to edit a photo
// in Photoshop. The image file itself is not to be passed as
// parameter, it is just written to the sync file.
// (see concept document.)
* @@@BUILDINFO@@@ MRS_start.jsx 1.0.0.1
#target photoshop
//@include "MRS_settings.jsx"
//@include "MRS_eventsinit.jsx"
//@include "MRS_open.jsx"
//@include "MRS_logging.jsx"
// on localized builds we pull the $$$/Strings from a .dat file, see documentation for more details
$.localize = false;
try {
    // Install the event scripts in Photoshop
    InitializeEvents();
    // Load the selected image files
    CheckOpenFiles();
catch( e ) {
    // always wrap your script with try/catch blocks so you don't stop production
    // remove comments below to see error for debugging
    Log(e);
    alert("Fehler in der MRS Anbindung: " + e);
=======================================================================================================
//  Install all event scripts required by the MRS Photoshop integration
* @@@BUILDINFO@@@ MRS_eventsinit.jsx 1.0.0.1
//@include "MRS_settings.jsx"
// Install all event scripts required by the MRS Photoshop integration
function InitializeEvents(){
    //Check the script files.
    var onSave = new File(MRS_SCRIPTONSAVE);
    if (! onSave.exists) {
        Log("Script file not found: " + MRS_SCRIPTONSAVE);
        alert("MRS Anbindung fehlerhaft!");       
        return false;
    var onClose = new File(MRS_SCRIPTONCLOSE);
    if (! onClose.exists) {
        Log("Script file not found: " + MRS_SCRIPTONCLOSE);
        alert("MRS Anbindung fehlerhaft!");       
        return false;
    app.notifiersEnabled = true;
    //Install the script.
    installNotifier (onSave, "save");
    installNotifier (onClose, "Cls ");
    return true;
// Install an event script
function installNotifier(scriptFile, eventId) {
    if(findNotifier(scriptFile, eventId) != null) {
        Log("Script already installed: " + scriptFile.fullName);
    } else {
        app.notifiers.add(eventId, scriptFile);
        Log("New script file installed: " + scriptFile.fullName);
// Checks if an event script is already installed
function findNotifier(scriptFile, eventId) {
    for(i=0; i<app.notifiers.length; i++) {
        var installedNotifier = app.notifiers[i];
        if (installedNotifier.eventFile.fullName.toLowerCase() == scriptFile.fullName.toLowerCase()
            && installedNotifier.event.toLowerCase() == eventId.toLowerCase()) {
                return installedNotifier;
    return null;
=======================================================================================================
//@include "MRS_settings.jsx"
* @@@BUILDINFO@@@ MRS_logging.jsx 1.0.0.1
// Class Logger
function Log(text) {
    var logfile = new File (MRS_LOGFILE);
    logfile.open('a');   
    try {
        var now = new Date();
        logfile.writeln(now.toLocaleString() + " | " + text);
    } finally {
        logfile.close();   
=======================================================================================================
* @@@BUILDINFO@@@ MRS_settings.jsx 1.0.0.1
MRS_PICTUREPATH = '/D/Projekte/npi/project/dpa.MRS.WinUI/bin/Debug/Photoshop/pictures/';
MRS_SCRIPTPATH = '/D/Projekte/npi/project/dpa.MRS.WinUI/bin/Debug/Photoshop/ps-script/';
MRS_SYNCFILE ='/D/Projekte/npi/project/dpa.MRS.WinUI/bin/Debug/Photoshop/PSIntergation.txt/';
MRS_SCRIPTONSAVE = MRS_SCRIPTPATH + 'MRS_onsave.jsx';
MRS_SCRIPTONCLOSE = MRS_SCRIPTPATH + 'MRS_onclose.jsx';
MRS_LOGFILE = MRS_PICTUREPATH + 'PSIntegration.log';
=======================================================================================================
// Event script for "save" in Photoshop.
// Marks the saved file in the sync file as "M" (modified)
* @@@BUILDINFO@@@ MRS_onsave.jsx 1.0.0.1
var begDesc = "$$$/JavaScripts/MRS_onsave/Description=Benachrichtigt MRS wenn das Bild gespeichert wurde." // endDesc
var begName = "$$$/JavaScripts/MRS_onsave/MenuName=MRS OnSave" // endName
// on localized builds we pull the $$$/Strings from a .dat file, see documentation for more details
$.localize = false;
//@include "MRS_settings.jsx"
//@include "MRS_syncfile.jsx"
//@include "MRS_logging.jsx"
Log("OnSave triggered.");
try {
    var savedFile = GetDataFromDocument (app.activeDocument);
    var pssyncer = new PSSyncer();
    var photo = pssyncer.GetFileInfo(savedFile.fileName);
    if (photo != null) {
        photo.SetModified();
        pssyncer.Flush();
}  catch( e ) {
    Log(e);
    alert("Fehler in der MRS Anbindung: " + e);
// Extracts the file name from Photoshop Document class.
function GetDataFromDocument( inDocument ) {
    var data = new Object();
    var fullPathStr = inDocument.fullName.toString();
    var lastDot = fullPathStr.lastIndexOf( "." );
    var lastSlash = fullPathStr.lastIndexOf( "/" );
    data.extension = fullPathStr.substr( lastDot + 1, fullPathStr.length );
    data.folder = fullPathStr.substr( 0, lastSlash );
    data.fileName = fullPathStr.substr( lastSlash+1, fullPathStr.length );
    return data;
=======================================================================================================
// Event script for "close" in Photoshop.
// Marks the saved file in the sync file as "M" (modified)
* @@@BUILDINFO@@@ MRS_onclose.jsx 1.0.0.1
// on localized builds we pull the $$$/Strings from a .dat file, see documentation for more details
$.localize = false;
//@include "MRS_settings.jsx"
//@include "MRS_syncfile.jsx"
//@include "MRS_logging.jsx"
//@include "MRS_tools.jsx"
Log("OnClose triggered.");
try {
    var saved = SavedWhileClosing(arguments);
    var pssyncer = new PSSyncer();   
    for(var i=0; i<pssyncer.GetFileInfoList().length; i++) {
        var photo = pssyncer.GetFileInfoList()[i];
        if(photo.WorkInProgress() && !IsDocumentOpened(photo.GetFileName())) {
            if (saved) {
                photo.SetModified();
            photo.SetClosed();
    pssyncer.Flush();
}  catch( e ) {
    Log(e);
    alert("Fehler in der MRS Anbindung: " + e);
// Checks if picture has been saved while closing it. (yes/no dialog on close)
function SavedWhileClosing(myArguments) {
    var usingKeyCopy = false;
    var actionDescripto = null;
    var actionDescriptor = myArguments[0];
    if ( actionDescriptor != null && "ActionDescriptor" == actionDescriptor.typename ) {
        if (actionDescriptor.hasKey(stringIDToTypeID("saving"))) {
            return actionDescriptor.getEnumerationValue(stringIDToTypeID("saving")) == stringIDToTypeID("yes");
    return false;
    var actionDescriptor = myArguments[0];
    var s = "";
    if ( actionDescriptor != null ) {
        if ( "ActionDescriptor" == actionDescriptor.typename ) {
            alert(actionDescriptor.count);
            for(i=0; i<actionDescriptor.count; i++) {
                s += actionDescriptor.getKey(i) + " | ";
                s += typeIDToStringID(actionDescriptor.getKey(i)) + " | ";
                s += actionDescriptor.getType(actionDescriptor.getKey(i))+ "\r\n";
    alert(s);
    //alert("1: " + actionDescriptor.getObjectValue(stringIDToTypeID("as")));
    //alert("2: " + actionDescriptor.getObjectValue(stringIDToTypeID("in")));
    //alert("3: " + actionDescriptor.getEnumerationType(stringIDToTypeID("saving")));
    alert("3-a: " + typeIDToStringID(actionDescriptor.getEnumerationType(stringIDToTypeID("saving"))));
    alert("3-b: " + typeIDToStringID(actionDescriptor.getEnumerationValue(stringIDToTypeID("saving"))));
=======================================================================================================
// Script used to open the files selected in MRS and written to
// the sync file.
@@@BUILDINFO@@@ MRS_open.jsx 1.0.0.1
//@include "MRS_settings.jsx"
//@include "MRS_syncfile.jsx"
//@include "MRS_tools.jsx"
// Opens all image files marked in the sync file as "S" (start work).
function CheckOpenFiles(){
    var pssyncer = new PSSyncer();
    for(var i=0; i<pssyncer.GetFileInfoList().length; i++) {
        var syncfile = pssyncer.GetFileInfoList()[i];
        if (syncfile.StartWork()) {
            //open the image file if in state "S" (start work)
            OpenFile(syncfile.GetFileName());
            //switch state to "W" (work in progress)
            syncfile.SetWorkInProgress();
            pssyncer.Flush();
        } else if (syncfile.WorkInProgress()) {
            if (!IsDocumentOpened(syncfile.GetFileName())) {
                //File was marked as "W" (work in progress).
                //-> Possibly Photoshop crashed. So just re-open the file and
                //don't chnge state.
                OpenFile(syncfile.GetFileName());
=======================================================================================================
// Some tool functions...
* @@@BUILDINFO@@@ MRS_tools.jsx 1.0.0.1
//@include "MRS_settings.jsx"
// Checks if the document is currently opened in Photoshop.
function IsDocumentOpened(fileName) {
    var fullFileName = MRS_PICTUREPATH + fileName;
    fullFileName = fullFileName.toLowerCase();
    for (i = 0; i < app.documents.length; i++) {
        if (app.documents[i].fullName.fullName.toLowerCase() == fullFileName) {
            return true;
    return false;
// Opens an image file in Photoshop
function OpenFile(fileName) {
    var syncfile = new File(MRS_PICTUREPATH + fileName);
    if (syncfile.exists) {
        app.open(syncfile);
=======================================================================================================
=======================================================================================================