PL/SQL Procedure guidelines

Question

I need to load the records from one table and insert and/or update it into different tables based on the column values. If any one has any template or guidelines for doing similar tasks, it would be give me a proper refernce. This is what I came up with based on the reading and other online examples. My concerns are about memory, commit & rollback points and performances. If anyone could point out any potential problems or any better ways of doing it, it would be greatly appreciated. There would be 30-40,000 records per day and this procedure is scheduled to run every evening. Please bear with me for this lengthy post.
--@test_pkg.sql;
--exec test_pkg.load_records(200);
create or replace package test_pkg
is
procedure load_records (fetch_limit in number := 200, log_lvl in number := 4);
procedure new_record (retKey out number);
procedure update_record(recKey in number);
procedure ins_upd_attribute (id1 in number, id2 in char, id3 in number, val in varchar2);
procedure log_msg(msg_type in number := 0, msg in varchar2);
function get_fk (col5 in varchar2) return number;
end test_pkg;
create or replace package body test_pkg
is
cursor test_cur
is
select col1, col2, col3, col4, col5,col6, name, phone, address1, city, state, zip, birthdate,
email, col7,lastdate, process_flag
from table1
where process_flag = 'N' for update of process_flag;
type test_cur_type is table of test_cur%rowtype;
cur_rec test_cur_type;
LOG_OFF number := 0;
LOG_FATAL number := 1;
LOG_ERROR number := 2;
LOG_WARNING number := 3;
LOG_INFO number := 4;
LOG_DEBUG number := 5;
log_level number := LOG_INFO;
i number := 1;
last_change_user number := 261;
last_change_date date; /* Sysdate */
rec_num, new_rec_count, error_record_count, total_record_count number;
start_time, end_time, processing_time number;
procedure load_records (fetch_limit in number := 200, log_lvl in number := 4)
is
begin
log_level := log_lvl;
start_time := dbms_utility.get_time;
log_msg(LOG_INFO, start_time||':test_pkg.load_records procedure started...');
select sysdate into last_change_date from dual;
new_rec_count := 0;
col2_count := 0;
col3_count := 0;
col4_count := 0;
attr_records_added := 0;
attr_records_updated := 0;
error_record_count := 0;
total_record_count := 0;
end_time := 0;
processing_time := 0;
open test_cur;
loop
fetch test_cur bulk collect into cur_rec limit fetch_limit;
for i in 1..cur_rec.count
loop
rec_num := 0;
if ((cur_rec(i).col5 > 0) and
(cur_rec(i).col1 = 'Y') or
(cur_rec(i).col2 = 'Y') or
(cur_rec(i).col3 = 'Y') or
(cur_rec(i).col4 = 'Y'))
then
if cur_rec(i).col1 = 'Y' then
new_record(rec_num);
else
rec_num := get_fk(cur_rec(i).col5);
end if;
log_msg(LOG_DEBUG, 'col5<'||cur_rec(i).col5||'> rec_num<'||rec_num||'>');
if rec_num <= 0 then
log_msg(LOG_INFO, 'Invalid record. rec#<'||cur_rec(i).col5||'> cx<'||rec_num||'>. No matching record found in card table');
else
if cur_rec(i).col2 = 'Y' then
ins_upd_attribute(rec_num, 'C', 191, 'Y');
end if;
if cur_rec(i).col3 = 'Y' then
ins_upd_attribute(rec_num, 'C', 192, 'Y');
end if;
if cur_rec(i).col4 = 'Y' then
ins_upd_attribute(rec_num, 'P', 193, 'Test');
end if;
if cur_rec(i).col6 = 'Y' then
update_record(cur_rec(i).col5);
end if;
end if;
else
log_msg(LOG_INFO, cur_rec(i).col5||' is an invalid record...No options selected.');
error_record_count := error_record_count + 1;
end if;
total_record_count := total_record_count + 1;
end loop;
exit when test_cur%notfound;
end loop;
close test_cur;
commit;
end_time := sys.dbms_utility.get_time;
--processing_time := mod (((end_time - start_time) + power(2,32)), power(2,32));
processing_time := end_time - start_time;
log_msg(LOG_INFO, '*********** Execution Summary ***********');
log_msg(LOG_INFO, ' New record requests: ' || new_rec_count);
log_msg(LOG_INFO, ' Invalid option records: ' || error_record_count);
log_msg(LOG_INFO, ' Total records processed: ' || total_record_count);
log_msg(LOG_INFO, ' Total processing time: ' || processing_time || ' ms');
log_msg(LOG_INFO, '*****************************************');
exception
when others then
log_msg(LOG_INFO, 'Other exceptions occured...');
--loghandler.log(sqlcode, sqlerrm,'load_records');
end load_records;
procedure new_record (retKey out number)
is
key1, key2, key3 number;
begin
retKey := 0;
--log_msg(LOG_INFO, start_time||':test_pkg.new_record procedure started...');
select value into key1 from keyTable where parameter = 'KEY1' for update;
update keyTable set value = key1 + 1 where parameter = 'KEY1';
select value into key2 from keyTable where parameter = 'KEY2' for update;
update keyTable set value = key2 + 1 where parameter = 'KEY2';
select value into key3 from keyTable where parameter = 'KEY3' for update;
update keyTable set value = key3 + 1 where parameter = 'KEY3';
log_msg(LOG_DEBUG, 'rec#<'||cur_rec(i).col4||'> key1<'||key1||'> key2<'||key2||'> key3<'||key3||'>');
insert into table1 (col1, col2, col3, col4, rectype, lastchangedate, lastchangeuserid)
values (key1, key2, key3, cur_rec(i).col4,'Unknown',last_change_date,last_change_user);
log_msg(LOG_DEBUG, 'Table1 record inseted...');
insert into table2 (col1, col2, col3, col4)
values(key2, key3, key1, cur_rec(i).name);
log_msg(LOG_DEBUG, 'Table2 record inseted...');
insert into table3 (col1, col2, col3, phone, addr, postalcode, lastchangedate, lastchangeuserid)
values (key3, key1, key2, cur_rec(i).phone, cur_rec(i).address1, cur_rec(i).zip, last_change_date,last_change_user);
log_msg(LOG_DEBUG, 'Table3 record inseted...');
retKey := key1;
new_rec_count := new_rec_count + 1;
exception
when others then
log_msg(LOG_INFO, 'Other exceptions occured...sqlcode: '||sqlcode||' sqlerrm: '|| sqlerrm);
end new_record;
procedure ins_upd_attribute (id1 in number, id2 in char, id3 in number, val in varchar2) is
record_count number := 0;
begin
log_msg(LOG_DEBUG, start_time||':test_pkg.ins_upd_attribute procedure started...');
select count(1) into record_count from attributeTable where col1 = id1 and col2 = id2 and col3 = id3;
if record_count = 1
then
update attributeTable set value = val where col1 = id1 and col2 = id2 and col3 = id3;
attr_records_updated := attr_records_updated + 1;
else
insert into attributeTable(col1,col2,col3,value ) values(id1,id2,id3,val);
attr_records_added := attr_records_added + 1;
end if;
exception
when others then
log_msg(LOG_INFO, 'Other exceptions occured...sqlcode: '||sqlcode||' sqlerrm: '|| sqlerrm);
end ins_upd_attribute;
procedure update_record (recKey in number) is
id1 number := 0;
begin
log_msg(LOG_DEBUG, start_time||':test_pkg.update_record procedure started...');
select col4 into id1 from table1 where col1 = recKey;
if id1 > 1
then
update tabl3 set phone = cur_rec(i).phone,
addr = cur_rec(i).address1, postalcode =cur_rec(i).zip where id =id1;
end if;
exception
when others then
log_msg(LOG_INFO, 'Other exceptions occured...sqlcode: '||sqlcode||' sqlerrm: '|| sqlerrm);
end update_record;
function get_fk (recKey in varchar2) return number is
rec_num number := 0;
begin
select key4 into rec_num from table1 where col4 = recKey;
return rec_num;
exception
when no_data_found then
log_msg(LOG_INFO, 'No Data found exceptions occured...recKey<'||recKey||'>');
when others then
log_msg(LOG_INFO, 'Other exceptions occured...sqlcode: '||sqlcode||' sqlerrm: '|| sqlerrm);
end get_fk;
procedure log_msg(msg_type in number := 0, msg in varchar2) is
begin
if msg_type <= log_level
then
log_msg(LOG_DEBUG, start_time||':test_pkg.ins_upd_attribute procedure started...');
--loghandler.log(sqlcode, sqlerrm,'load_records')
end if;
exception
when others then
log_msg(LOG_INFO, 'Other exceptions occured...sqlcode: '||sqlcode||' sqlerrm: '|| sqlerrm);
end log_msg;
end test_pkg;
/

Answer 1

Thanks for your reply. No. I can not use insert into or merge into options. My scenario is like this.
Read the staging table records where processed_flag is 'N'
if (col1 !='Y' and col2 !='Y' or col3 !='Y' or col4 !='Y') and col5 = 0 then
log this record. goto the next record.
else
if col1 = 'Y' then
rec_key = new_record(rec_num);
else
rec_key = get_fk(col5);
end if;
if col2 = 'Y' then
ins_upd_attribute(rec_key,'C', 191, 'Y');
end if;
if col3 = 'Y' then
ins_upd_attribute(rec_key,'C', 192, 'Y');
end if;
if col4 = 'Y' then
ins_upd_attribute(rec_key,'P', 193, 'Test');
end if;
if col6 = 'Y' then
update_record(col5);
end if;
update the processed flag to 'Y';
end if;
procedure new_record(retKey out number) is
Select the next values for 3 keys from keyTable. update keyTable column values with +1.
Insert new records into table1, table2 and table3
end new_record;
procedure ins_upd_attribute (id1 in number, id2 in char, id3 in number, val in varchar2) is
if a record exists in attributeTable then
update the attributeTable record
else
insert new record into attributeTable.
end if;
end ins_upd_attribute;
function get_fk (recKey in varchar2) return number is
if a record exist in table1 then
return record key
else
return 0;
end if;
end get_fk;
procedure update_record (recKey in number) is
if a record exists in table1 then
update table3 using the key from table1
end if;
end update_record;
Should I commit after processing each record in the staging table or commit after processing all records?
Should I combine all procedures and functions into one large procedure (load_records) or leave it the way it is now? Does any one see any potential problems with my current approach? Any advice will be sincerely appreciated.
Message was edited by:
new2sql