PL/SQL report condition not working

Question

I have a PL/SQL statement to display a report based on a condition and no matter what i try, it still displays all the records. Im trying to display all the records where chart.voided does not equal 'Y'.
I have tried to add the condition to the where clause and also have tried to add a hidden item with a filter. Neither one seem to work.
Does anyone know what i am doing wrong here?
Thanks
Deanna
declare
q varchar2(4000);
begin
-- setup sql for report source
q := 'select * from
(select CHART.RECNUM,CHART.CASE_NUMBER,
CHART.INCIDENT_DATE,CHART.INCIDENT_TIME,
CHART.TROOP#1,CHART.TROOP#2,
CHART.COUNTY,
CHART.LOCATION,CHART.CASE_COMPLETED,CHART.CASE_STATUS,CHART.RECONSTRUCTION,CHART.MAP,
CHART.VOIDED,
CHART.TECHNICIAN1_RADIO,CHART.TECHNICIAN2_RADIO,
chart.technician1_lastname||'',''||chart.technician1_name "TROOPER#1",
chart.technician2_lastname||'',''||chart.technician2_name "TROOPER#2",
chart.technician3_lastname||'',''||chart.technician3_name "TROOPER#3",
chart.technician4_lastname||'',''||chart.technician4_name "TROOPER#4",
chart.technician5_lastname||'',''||chart.technician5_name "TROOPER#5",
CHART.ROLE#1,CHART.ROLE#2,CHART.ROLE#3,CHART.ROLE#4,CHART.ROLE#5,
CHART.TECHNICIAN1_LASTNAME,CHART.TECHNICIAN1_NAME,
CHART.TECHNICIAN2_LASTNAME,CHART.TECHNICIAN2_NAME,
CHART.TECHNICIAN3_LASTNAME,CHART.TECHNICIAN3_NAME,
CHART.TECHNICIAN4_LASTNAME,CHART.TECHNICIAN4_NAME,
CHART.TECHNICIAN5_LASTNAME,CHART.TECHNICIAN5_NAME
FROM CHART)
WHERE (
--:P22_VOID !=''Y'' AND
instr(upper("RECNUM"),upper(nvl(:P21_SEARCH,"RECNUM"))) > 0  or
instr(upper("CASE_NUMBER"),upper(nvl(:P21_SEARCH,"CASE_NUMBER"))) > 0  or
instr(upper("INCIDENT_TIME"),upper(nvl(:P21_SEARCH,"INCIDENT_TIME"))) > 0  or
instr(upper("INCIDENT_DATE"),upper(nvl(:P21_SEARCH,"INCIDENT_DATE"))) > 0  or
instr(upper("TROOP#1"),upper(nvl(:P21_SEARCH,"TROOP#1"))) > 0  or
instr(upper("TROOP#2"),upper(nvl(:P21_SEARCH,"TROOP#2"))) > 0  or
instr(upper("TECHNICIAN1_RADIO"),upper(nvl(:P21_SEARCH,"TECHNICIAN1_RADIO"))) > 0  or
instr(upper("TECHNICIAN1_NAME"),upper(nvl(:P21_SEARCH,"TECHNICIAN1_NAME"))) > 0  or
instr(upper("TECHNICIAN1_LASTNAME"),upper(nvl(:P21_SEARCH,"TECHNICIAN1_LASTNAME"))) > 0  or
instr(upper("TECHNICIAN2_RADIO"),upper(nvl(:P21_SEARCH,"TECHNICIAN2_RADIO"))) > 0  or
instr(upper("TECHNICIAN2_NAME"),upper(nvl(:P21_SEARCH,"TECHNICIAN2_NAME"))) > 0  or
instr(upper("TECHNICIAN2_LASTNAME"),upper(nvl(:P21_SEARCH,"TECHNICIAN2_LASTNAME"))) > 0  or
instr(upper("COUNTY"),upper(nvl(:P21_SEARCH,"COUNTY"))) > 0  or
instr(upper("LOCATION"),upper(nvl(:P21_SEARCH,"LOCATION"))) > 0  or
instr(upper("CASE_COMPLETED"),upper(nvl(:P21_SEARCH,"CASE_COMPLETED"))) > 0  or
instr(upper("CASE_STATUS"),upper(nvl(:P21_SEARCH,"CASE_STATUS"))) > 0  or
instr(upper("RECONSTRUCTION"),upper(nvl(:P21_SEARCH,"RECONSTRUCTION"))) > 0  or
instr(upper("MAP"),upper(nvl(:P21_SEARCH,"MAP"))) > 0 or
instr(upper("VOIDED"),upper(nvl(:P21_SEARCH,"VOIDED"))) > 0)';
--Filter Voided
--         if :P22_VOID !='Y' THEN
--                q := q || ' and instr(upper("VOIDED"),upper(nvl
--(:P22_VOID,"VOIDED"))) > 0';
--         end if; 
return q;
end;

Answer 1

Hi, Deanna.
If the only condition for being selected is chart.voided = 'Y', then the WHERE clause should be:
WHERE   chart.voided     = 'Y'If the condition chart.voided = 'Y' is just one of many conditions that must be met, use AND, like this:
WHERE   chart.voided     = 'Y'
AND     (     instr(upper("RECNUM"),         upper(nvl(:P21_SEARCH,"RECNUM")))         > 0
     OR     instr(upper("CASE_NUMBER"), upper(nvl(:P21_SEARCH,"CASE_NUMBER")))  > 0
     OR     ...
     )Don't mix ANDs and ORs at the same level. In my example above, notice how there are two conditions, connected by AND
(1) "chart.voided = 'Y'"
(2) a whole bunch of tests involving INSTR, all connected by OR. The parentheses around this condition are necessary: they keep the ORs at a lower level than the AND connecting the 2 top-level conditions.
Edited by: Frank Kulash on Aug 17, 2009 6:55 PM