Please help me to identify problem

Question

create or replace procedure test4(p_id in number) as
begin
declare
str varchar2(1000) := null;
begin
str := 'update test set ID=p_id';
execute_immediate(str);
end;
end;
but ehen i execute
exec test4(5);
this gives folowing error
ERROR at line 1:
ORA-00904: "P_ID": invalid identifier
ORA-06512: at "ITD.EXECUTE_IMMEDIATE", line 4
ORA-06512: at "ITD.TEST4", line 7
ORA-06512: at line 1
Please tell me how to resolve error and please tell me whats changing required if query uses bind variables.
Thanks

Answer 1

Better to use DBMS_SQL
http://download.oracle.com/docs/cd/B19306_01/appdev.102/b14258/d_sql.htm#sthref7370
SQL> var sal number
SQL> var job varchar2(10)
SQL> exec :sal := 1000
PL/SQL procedure successfully completed.
SQL> declare
  2      cursor_name integer;
  3      rows_processed integer;
  4      l_sql long := 'update emp2 set';
  5  begin
  6      if :sal is not null then
  7          l_sql := l_sql || ' sal = :a';
  8      end if;
  9      if :job is not null then
10          l_sql := l_sql || ', job = :b';
11      end if;
12      cursor_name := dbms_sql.open_cursor;
13      dbms_sql.parse(cursor_name, l_sql, dbms_sql.native);
14      if :sal is not null then
15          dbms_sql.bind_variable(cursor_name, ':a', :sal);
16      end if;
17      if :job is not null then
18          dbms_sql.bind_variable(cursor_name, ':b', :job);
19      end if;
20      rows_processed := dbms_sql.execute(cursor_name);
21      dbms_sql.close_cursor(cursor_name);
22  end;
23  /
PL/SQL procedure successfully completed.
SQL> exec :job := 'ANALYST'
PL/SQL procedure successfully completed.
SQL> /
PL/SQL procedure successfully completed.
SQL> select sal, job from emp2;
       SAL JOB
      1000 ANALYST
      1000 ANALYST