Please let me plsql code standards

Question

Hi all,
Please let me know if i am missing any plsql standards
IF (    curr_rec.rqst_ctgry_lkpcd = 'AR'
                AND curr_rec.unfrm_blng_facility_type_code = 'B'
            THEN
               NULL;
            ELSIF (    curr_rec.rqst_ctgry_lkpcd <> 'AR'
                   AND curr_rec.unfrm_blng_facility_type_code = 'A'
            THEN
               NULL;
            ELSE
               INSERT INTO pa_request_run_error
                           (pa_rqst_run_err_sid,
                            pa_error_sid,
                            pa_rqst_sid, rsltn_user_acct_sid, run_nmbr,
                            erroneous_data_value,
                            error_action_lkpcd, error_rsltn_date,
                            rsltn_comment, oprtnl_flag, created_by,
                            created_date, modified_by, modified_date,
                            prvs_run_nmbr
                    VALUES (pa_request_run_error_seq.NEXTVAL,
                            (SELECT pa_error_sid
                               FROM pa_error
                              WHERE pa_error_nmbr = '7033'),
                            curr_rec.pa_rqst_sid, NULL, 1,
                               curr_rec.rqst_ctgry_lkpcd
                            || '-'||curr_rec.unfrm_blng_facility_type_code
                            'F', NULL,
                            NULL, 'A', 30,
                            SYSDATE, 30, SYSDATE,
                            NULL
            END IF;Regards,
P Prakash
Edited by: BluShadow on 27-May-2011 08:42
added {noformat}{noformat} tags as per the {message:id=9360002} FAQ
Edited by: BluShadow on 27-May-2011 08:47
Also fixed the <> issues as described in the FAQ                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                               

Answer 1

I do not like if-elseif constructs that much. These tend to get horrible warped and abused. Especially after a few years of code maintenance and enhancements.
My preference is instead for CASE statements.
I see that you are hardcoding literals in your code like +"A'+ and +'B'+ and so on. This is not readable, re-usable or easy maintainable. Consider instead a constants package that defines constants for these literals instead. You now have a single package and place for defining literals to use - easy to update and maintain. And vastly improves the readability of the code. E.g.
{code}
create or replace package Const as
--// active facility types (or whatever..)
C_ACTIVE_FACILITY_TYPE constant varchar2(1) := 'A';
.. rest of the constants
end;
{code}
Now you +IF+ condition can use this constant - resulting in more readable code and code that is a lot easier to maintain.
Also, as far as standards go. Writing long blocks of code in an +IF+ block (or +CASE+ block), seriously hampers the readability of the code. And re-usability.
So rather take that large block of code, modularise it, and then call that module from the +IF+ or +CASE+ code block.
A basic standard to aim for is to make code read like a story - especially at the "higher" levels (the main code blocks that initiate the processing and control the process flow).
A very simple example - the following code indicates very clearly the process flow being done. And is a lot better than not modularising and instead have large swathes of code blocks:
{code}
begin
loop
fetch invoiceCur bulk collect into invoiceList limit 100;
for i in 1..invoiceList.Count
loop
ProcessInventory( invoiceList(i) );
BillCustomer( invoiceList(i) );
ProcessShipping( invoiceList(i) );
NotifyCustomer( invoiceList(i) );
end loop;
exit when c%NotFound;
end loop;
close c;
end;
{code}