Please someone help me with this code..

Question

hi, i have a big problem trying to figure out how to do this, i get this code somewhere in the net, so it's not me who code this, that's why i got this problem.
this is a MIDlet games, something like gallaga. i like to add some features like the UP and DOWN movement and also i have a problem with his "fire", i can only shoot once after the fire image is gone in the screen, what i liked to have is even i pressed the fire button and press it again the fire will not gone, what i mean continues fire if i pressed everytime the fire button.
i will post the code here so you can see it and give me some feedback. i need this badly, hoping to all you guys! thanks..for this forum.
----CODE BEGIN ---------------
import java.io.IOException;
import java.io.PrintStream;
import java.util.Random;
import javax.microedition.lcdui.*;
import javax.microedition.midlet.MIDlet;
import javax.microedition.midlet.MIDletStateChangeException;
import javax.microedition.rms.RecordStore;
import javax.microedition.rms.RecordStoreException;
public class MobileGalaga extends MIDlet
implements CommandListener, Runnable
class ScoreScreen extends Canvas
public void paint(Graphics g)
g.setColor(0xffffff);
g.fillRect(0, 0, MobileGalaga.WIDTH, MobileGalaga.HEIGHT);
g.setColor(0x160291);
g.setFont(MobileGalaga.fs);
g.drawString("Help", MobileGalaga.CENTERW, 2, 17);
g.setColor(0);
g.drawString("Use left/right and fire", MobileGalaga.CENTERW, 20, 17);
g.drawString("to destory the", MobileGalaga.CENTERW, 30, 17);
g.drawString("incoming alien MobileGalaga", MobileGalaga.CENTERW, 40, 17);
public void keyPressed(int i)
int j = getGameAction(i);
if(j == 8)
display.setCurrent(titlescreen);
ScoreScreen()
class TitleScreen extends Canvas
public void paint(Graphics g)
g.setColor(0xffffff);
g.fillRect(0, 0, MobileGalaga.WIDTH, MobileGalaga.HEIGHT);
g.drawImage(MobileGalaga.logoimg, MobileGalaga.CENTERW, 15, 17);
g.setColor(0);
g.setFont(MobileGalaga.fs);
g.drawString("Press 5 to", MobileGalaga.CENTERW, 43, 17);
g.drawString("see help", MobileGalaga.CENTERW, 53, 17);
public void keyPressed(int i)
int j = getGameAction(i);
if(j == 8)
display.setCurrent(scorescreen);
TitleScreen()
class MainScreen extends Canvas
public void paint(Graphics g)
offg.setColor(0xffffff);
offg.fillRect(0, 0, MobileGalaga.WIDTH, MobileGalaga.HEIGHT);
for(int i = 0; i < MobileGalaga.slen; i++)
if(!MobileGalaga.dead)
offg.drawImage(MobileGalaga.alienimg[MobileGalaga.frame[i]], MobileGalaga.x[i], MobileGalaga.y[i], 17);
if(!MobileGalaga.playerdead)
offg.drawImage(MobileGalaga.playerimg, MobileGalaga.px, MobileGalaga.py, 17);
} else
if(MobileGalaga.explodeframe < 3)
offg.drawImage(MobileGalaga.explosionimg[MobileGalaga.explodeframe], MobileGalaga.px, MobileGalaga.py, 17);
MobileGalaga.explodeframe++;
if(!MobileGalaga.gameover)
MobileGalaga.playerpause++;
if(MobileGalaga.playerpause < 50)
MobileGalaga.playerpause++;
} else
MobileGalaga.playerdead = false;
MobileGalaga.playerpause = 0;
MobileGalaga.px = MobileGalaga.CENTERW;
offg.setColor(0);
offg.drawString(MobileGalaga.scorestr, MobileGalaga.WIDTH, 0, 24);
offg.drawImage(MobileGalaga.playerimg, 0, 0, 20);
offg.drawString(MobileGalaga.lives + "", 12, 0, 20);
if(MobileGalaga.laser)
offg.drawLine(MobileGalaga.laserx, MobileGalaga.lasery, MobileGalaga.laserx, MobileGalaga.lasery + 4);
if(MobileGalaga.showscores)
for(int j = 0; j < 5; j++)
if(j == MobileGalaga.rank)
offg.setColor(0xff0000);
else
offg.setColor(0);
offg.drawString((j + 1) + " .... " + getScoreStr(MobileGalaga.highscore[j]), MobileGalaga.CENTERW, 20 + j * 10, 17);
if(MobileGalaga.showmessage)
offg.setColor(0xff0000);
offg.drawString(MobileGalaga.msg, MobileGalaga.CENTERW, MobileGalaga.CENTERH, 17);
MobileGalaga.messagepause++;
if(MobileGalaga.messagepause > 20)
MobileGalaga.showmessage = false;
MobileGalaga.messagepause = 0;
if(MobileGalaga.gameover)
MobileGalaga.showscores = true;
else
if(MobileGalaga.wavecomplete)
initWave();
g.drawImage(offimg, 0, 0, 20);
public void keyPressed(int i)
int j = getGameAction(i);
if(j == 2)
MobileGalaga.playerLeft = true;
else
if(j == 5)
MobileGalaga.playerRight = true;
else
if(j == 8)
fireLaser();
public void keyReleased(int i)
int j = getGameAction(i);
if(j == 2)
MobileGalaga.playerLeft = false;
else
if(j == 5)
MobileGalaga.playerRight = false;
private Image offimg;
private Graphics offg;
public MainScreen()
offimg = Image.createImage(getWidth(), getHeight());
offg = offimg.getGraphics();
offg.setFont(MobileGalaga.fs);
public MobileGalaga()
rand = new Random();
display = Display.getDisplay(this);
mainscreen = new MainScreen();
titlescreen = new TitleScreen();
scorescreen = new ScoreScreen();
WIDTH = mainscreen.getWidth();
HEIGHT = mainscreen.getHeight();
CENTERW = WIDTH / 2;
CENTERH = HEIGHT / 2;
exitCommand = new Command("Exit", 7, 1);
playCommand = new Command("Play", 1, 1);
quitCommand = new Command("Quit", 1, 1);
againCommand = new Command("Again", 1, 1);
nullCommand = new Command("", 1, 1);
try
alienimg[0] = Image.createImage("/alien1.png");
alienimg[1] = Image.createImage("/alien2.png");
explosionimg[0] = Image.createImage("/explosion1.png");
explosionimg[1] = Image.createImage("/explosion2.png");
explosionimg[2] = Image.createImage("/explosion3.png");
playerimg = Image.createImage("/player.png");
logoimg = Image.createImage("/logo.png");
catch(IOException ioexception)
db("Couldn't get images!");
imgW = alienimg[0].getWidth();
imgH = alienimg[0].getHeight();
edgeH = imgW / 2;
edgeV = imgH / 2;
pimgW = playerimg.getWidth();
pimgH = playerimg.getHeight();
pedgeH = pimgW / 2;
pedgeV = pimgH / 2;
highscore = getHighScores();
public void run()
while(runner)
rp();
updatePos();
try
MobileGalaga _tmp = this;
Thread.sleep(75L);
catch(InterruptedException interruptedexception)
db("interrupted");
runner = false;
MobileGalaga _tmp1 = this;
Thread.yield();
public void startApp()
throws MIDletStateChangeException
display.setCurrent(titlescreen);
addBeginCommands(titlescreen, false);
addBeginCommands(scorescreen, false);
addPlayCommands(mainscreen, false);
public void pauseApp()
public void destroyApp(boolean flag)
runner = false;
th = null;
private void rp()
mainscreen.repaint();
private void startGame()
initGame();
if(th == null)
th = new Thread(this);
runner = true;
th.start();
private void initGame()
px = CENTERW;
py = HEIGHT - pedgeV - pimgH;
packcount = 0;
lives = 3;
score = 0;
scorestr = "000000";
rank = -1;
difficulty = 400;
wave = 1;
initWave();
private void initWave()
for(int i = 0; i < slen; i++)
frame[i] = i % 2;
x[i] = packX[i] = sposX[i];
y[i] = packY[i] = sposY[i];
dx[i] = packdx = alien_dx_right;
dy[i] = packdy = alien_dy_right;
dxcount[i] = dycount[i] = 0;
pmode[i] = 0;
flying[i] = false;
dead[i] = false;
playerLeft = false;
playerRight = false;
laser = false;
playerdead = false;
showscores = false;
showmessage = false;
gameover = false;
wavecomplete = false;
playerpause = 0;
messagepause = 0;
killed = 0;
private void updatePos()
if(playerLeft)
updatePlayerPos(-2);
else
if(playerRight)
updatePlayerPos(2);
fly = Math.abs(rand.nextInt() % difficulty);
if(fly < slen && !flying[fly] && !dead[fly])
if(x[fly] < CENTERW)
setDX(fly, alien_dx_flyright, 2);
setDY(fly, alien_dy_flyright, 2);
} else
setDX(fly, alien_dx_flyleft, 2);
setDY(fly, alien_dy_flyleft, 2);
flying[fly] = true;
for(int i = 0; i < slen; i++)
if(!dead[i])
if(!flying[i])
if(x[i] + edgeH + dx[i][dxcount[i]] > WIDTH)
changePackDir(alien_dx_left, alien_dy_left);
if((x[i] - edgeH) + dx[i][dxcount[i]] < 0)
changePackDir(alien_dx_right, alien_dy_right);
} else
if(y[i] + edgeV + dy[i][dycount[i]] > HEIGHT)
x[i] = packX[i];
y[i] = packY[i];
flying[i] = false;
setDX(i, packdx, 0);
setDY(i, packdy, 0);
if(!playerdead && y[i] <= py + pedgeV && y[i] >= py - pedgeV && x[i] <= px + pedgeH && x[i] >= px - pedgeH)
playerHit();
if(laser && lasery <= y[i] + edgeV && lasery >= y[i] - edgeV && laserx <= x[i] + edgeH && laserx >= x[i] - edgeH)
alienHit(i);
for(int j = 0; j < slen; j++)
if(!dead[j])
if(framecount == 3)
frame[j] = frame[j] + 1 < 2 ? 1 : 0;
lastx = x[j];
lasty = y[j];
x[j] += dx[j][dxcount[j]];
y[j] += dy[j][dycount[j]];
if(pmode[j] == 0)
dxcount[j] = dxcount[j] + 1 < dx[j].length ? dxcount[j] + 1 : 0;
dycount[j] = dycount[j] + 1 < dy[j].length ? dycount[j] + 1 : 0;
} else
if(pmode[j] == 2)
dxcount[j] = dxcount[j] + 1 < dx[j].length ? dxcount[j] + 1 : dxcount[j];
dycount[j] = dycount[j] + 1 < dy[j].length ? dycount[j] + 1 : dycount[j];
packX[j] += packdx[packcount];
packY[j] += packdy[packcount];
packcount = packcount + 1 < packlen ? packcount + 1 : 0;
framecount = framecount + 1 < 4 ? framecount + 1 : 0;
if(laser)
lasery -= 6;
if(lasery < 0)
laser = false;
private void setDX(int i, int ai[], int j)
if(i == -1)
for(int k = 0; k < slen; k++)
if(!flying[k])
dx[k] = ai;
dxcount[k] = 0;
pmode[k] = j;
} else
dx[i] = ai;
dxcount[i] = 0;
pmode[i] = j;
private void setDY(int i, int ai[], int j)
if(i == -1)
for(int k = 0; k < slen; k++)
if(!flying[k])
dy[k] = ai;
dycount[k] = 0;
pmode[k] = j;
} else
dy[i] = ai;
dycount[i] = 0;
pmode[i] = j;
private void changePackDir(int ai[], int ai1[])
setDX(-1, ai, 0);
setDY(-1, ai1, 0);
packdx = ai;
packdy = ai1;
packcount = 0;
private void updatePlayerPos(int i)
plastx = px;
px += i;
if(px + pedgeH > WIDTH || px - pedgeH < 0)
px = plastx;
private void fireLaser()
if(!laser)
laser = true;
laserx = px;
lasery = py;
private void alienHit(int i)
if(!playerdead)
dead[i] = true;
laser = false;
killed++;
if(flying[i])
score += 200;
else
score += 50;
if(killed == slen)
waveComplete();
scorestr = getScoreStr(score);
private void playerHit()
playerdead = true;
playerpause = 0;
explodeframe = 0;
lives--;
if(lives == 0)
gameOver();
private void waveComplete()
wavecomplete = true;
difficulty -= 100;
if(difficulty < 100)
difficulty = 100;
msg = "WAVE " + wave + " COMPLETE";
messagepause = 0;
showmessage = true;
wave++;
score += 1000 * wave;
scorestr = getScoreStr(score);
private void gameOver()
gameover = true;
msg = "GAME OVER";
for(int i = 0; i < 5; i++)
if(score < highscore[i])
continue;
for(int j = 4; j > i; j--)
highscore[j] = highscore[j - 1];
highscore[i] = score;
rank = i;
break;
setHighScores();
showmessage = true;
messagepause = 0;
addEndCommands(mainscreen, true);
private void addBeginCommands(Displayable displayable, boolean flag)
if(flag)
removeCommands();
displayable.addCommand(playCommand);
displayable.addCommand(exitCommand);
displayable.setCommandListener(this);
private void addPlayCommands(Displayable displayable, boolean flag)
if(flag)
removeCommands();
displayable.addCommand(nullCommand);
displayable.addCommand(quitCommand);
displayable.setCommandListener(this);
private void addEndCommands(Displayable displayable, boolean flag)
if(flag)
removeCommands();
displayable.addCommand(againCommand);
displayable.addCommand(quitCommand);
displayable.setCommandListener(this);
private void removeCommands()
Displayable displayable = display.getCurrent();
displayable.removeCommand(nullCommand);
displayable.removeCommand(quitCommand);
displayable.removeCommand(againCommand);
displayable.removeCommand(playCommand);
displayable.removeCommand(exitCommand);
public void commandAction(Command command, Displayable displayable)
if(command == playCommand)
display.setCurrent(mainscreen);
startGame();
if(command == quitCommand)
runner = false;
while(th.isAlive()) ;
th = null;
addPlayCommands(mainscreen, true);
display.setCurrent(titlescreen);
if(command == againCommand)
runner = false;
while(th.isAlive()) ;
th = null;
display.setCurrent(mainscreen);
addPlayCommands(mainscreen, true);
startGame();
if(command == exitCommand)
destroyApp(false);
notifyDestroyed();
private int[] getHighScores()
int ai[] = new int[5];
ai[0] = 5000;
ai[1] = 4000;
ai[2] = 3000;
ai[3] = 2000;
ai[4] = 1000;
byte abyte0[][] = new byte[5][6];
try
hsdata = RecordStore.openRecordStore("MobileGalaga", true);
int i = hsdata.getNumRecords();
if(i == 0)
for(int j = 0; j < 5; j++)
abyte0[j] = Integer.toString(ai[j]).getBytes();
hsdata.addRecord(abyte0[j], 0, abyte0[j].length);
} else
for(int k = 0; k < 5; k++)
abyte0[k] = hsdata.getRecord(k + 1);
String s = "";
for(int l = 0; l < abyte0[k].length; l++)
s = s + (char)abyte0[k][l] + "";
ai[k] = Integer.parseInt(s);
catch(RecordStoreException recordstoreexception)
db("problem with initialising highscore data\n" + recordstoreexception);
return ai;
private void setHighScores()
byte abyte0[][] = new byte[5][6];
try
hsdata = RecordStore.openRecordStore("MobileGalaga", true);
for(int i = 0; i < 5; i++)
abyte0[i] = Integer.toString(highscore[i]).getBytes();
hsdata.setRecord(i + 1, abyte0[i], 0, abyte0[i].length);
catch(RecordStoreException recordstoreexception)
db("problem with setting highscore data\n" + recordstoreexception);
private String getScoreStr(int i)
templen = 6 - (i + "").length();
tempstr = "";
for(int j = 0; j < templen; j++)
tempstr = tempstr + "0";
return tempstr + i;
public static void db(String s)
System.out.println(s);
public static void db(int i)
System.out.println(i + "");
private Display display;
private Command exitCommand;
private Command playCommand;
private Command quitCommand;
private Command againCommand;
private Command nullCommand;
private MainScreen mainscreen;
private TitleScreen titlescreen;
private ScoreScreen scorescreen;
private static int WIDTH;
private static int HEIGHT;
private static int CENTERW;
private static int CENTERH;
private boolean runner;
private Thread th;
private Random rand;
private static final int RED = 0xff0000;
private static final int ORANGE = 0xff9100;
private static final int YELLOW = 0xffff00;
private static final int WHITE = 0xffffff;
private static final int BLACK = 0;
private static final int BLUE = 0x160291;
private static Image alienimg[] = new Image[2];
private static Image explosionimg[] = new Image[3];
private static Image playerimg;
private static Image logoimg;
private static int imgH;
private static int imgW;
private static int pimgH;
private static int pimgW;
private static int edgeH;
private static int edgeV;
private static int pedgeH;
private static int pedgeV;
private static final Font fs = Font.getFont(64, 0, 8);
private static final Font fl = Font.getFont(64, 1, 16);
private static final int sposX[] = {
16, 28, 40, 52, 4, 16, 28, 40, 52, 64,
4, 16, 28, 40, 52, 64
private static final int sposY[] = {
14, 14, 14, 14, 26, 26, 26, 26, 26, 26,
38, 38, 38, 38, 38, 38
private static final int LOOP = 0;
private static final int ONCE = 1;
private static final int HOLD = 2;
private static final int move_none[] = {
0
private static final int alien_dx_right[] = {
1, 1, 1, 1, 1, 1, 1, 1
private static final int alien_dy_right[] = {
0, 0, 1, 1, 0, 0, -1, -1
private static final int alien_dx_left[] = {
-1, -1, -1, -1, -1, -1, -1, -1
private static final int alien_dy_left[] = {
0, 0, -1, -1, 0, 0, 1, 1
private static final int alien_dx_flyright[] = {
1, 1, 1, 0, -1, -1, -1, -1, -1, 0,
1, 1, 2, 3, 4, 5, 6
private static final int alien_dy_flyright[] = {
0, -1, -1, -1, -1, -1, 0, 1, 1, 1,
1, 1, 2, 3, 4, 5, 6
private static final int alien_dx_flyleft[] = {
-1, -1, -1, 0, 1, 1, 1, 1, 1, 0,
-1, -1, -2, -3, -4, -5, -6
private static final int alien_dy_flyleft[] = {
0, -1, -1, -1, -1, -1, 0, 1, 1, 1,
1, 1, 2, 3, 4, 5, 6
private static final int slen;
private static final int ailen;
private static final int packlen;
private static int pmode[];
private static int x[];
private static int y[];
private static int dx[][];
private static int dy[][];
private static int dxcount[];
private static int dycount[];
private static int frame[];
private static boolean flying[];
private static boolean dead[];
private static boolean exploding[];
private static int lastx;
private static int lasty;
private static int fly;
private static int packX[];
private static int packY[];
private static int packdx[];
private static int packdy[];
private static int packcount;
private static int framecount = 3;
private static int px;
private static int py;
private static int plastx;
private static int score;
private static String scorestr;
private static int lives;
private static int killed;
private static boolean playerdead;
private static int explodeframe;
private static int playerpause;
private static int rank;
private static boolean playerLeft;
private static boolean playerRight;
private static boolean laser;
private static int laserx;
private static int lasery;
private static RecordStore hsdata;
private static int highscore[] = new int[5];
private static boolean showmessage;
private static boolean showscores;
private static boolean gameover;
private static boolean wavecomplete;
private static int messagepause;
private static String msg;
private static int difficulty;
private static int wave;
private static String tempstr;
private static int templen;
static
slen = sposX.length;
ailen = alien_dx_flyright.length;
packlen = alien_dx_right.length;
pmode = new int[slen];
x = new int[slen];
y = new int[slen];
dx = new int[slen][ailen];
dy = new int[slen][ailen];
dxcount = new int[slen];
dycount = new int[slen];
frame = new int[slen];
flying = new boolean[slen];
dead = new boolean[slen];
exploding = new boolean[slen];
packX = new int[slen];
packY = new int[slen];
packdx = new int[packlen];
packdy = new int[packlen];
----END OF CODE ----------------

Answer 1

hi sorry if it's too big! i hope i can explain this very well (you know i only got this code in the net), if you try to run the program in emulator, the and lunch it will it will first display the title screen and if you hit the pressed key 5 it will display help,
so my problem is how to move UP and DOWN and also if i pressed the fire button it will continue to fire. here is the code.
//Code for the Left,Right,UP and Down movement and also the fire
public void keyPressed(int i)
int j = getGameAction(i);
if(j == 2)
MobileGalaga.playerLeft = true; //this is ok
else
if(j == 5)
MobileGalaga.playerRight = true; //this is ok
else
if(j==1)
MobileGalaga.playerUp = true; //i add this only, this has a problem
else
if(j==6)
MobileGalaga.playerDown = true; //i add this only, this has a problem
else
if(j == 8)
fireLaser(); //for the release of fire
//for the release of key pressed
public void keyReleased(int i)
int j = getGameAction(i);
if(j == 2)
MobileGalaga.playerLeft = false;
else
if(j == 5)
MobileGalaga.playerRight = false;
//Update the position base on key pressed
private void updatePos()
if(playerLeft)
updatePlayerPos(-5);
else
if(playerUp)
updatePlayerPos1(-4);
else
if(playerDown)
updatePlayerPos1(4);
else
if(playerRight)
updatePlayerPos(5);
fly = Math.abs(rand.nextInt() % difficulty);
if(fly < slen && !flying[fly] && !dead[fly])
if(x[fly] < CENTERW)
setDX(fly, alien_dx_flyright, 2);
setDY(fly, alien_dy_flyright, 2);
} else
setDX(fly, alien_dx_flyleft, 2);
setDY(fly, alien_dy_flyleft, 2);
flying[fly] = true;
for(int i = 0; i < slen; i++)
if(!dead)
if(!flying[i])
if(x[i] + edgeH + dx[i][dxcount[i]] > WIDTH)
changePackDir(alien_dx_left, alien_dy_left);
if((x[i] - edgeH) + dx[i][dxcount[i]] < 0)
changePackDir(alien_dx_right, alien_dy_right);
} else
if(y[i] + edgeV + dy[i][dycount[i]] > HEIGHT)
x[i] = packX[i];
y[i] = packY[i];
flying[i] = false;
setDX(i, packdx, 0);
setDY(i, packdy, 0);
if(!playerdead && y[i] <= py + pedgeV && y[i] >= py - pedgeV && x[i] <= px + pedgeH && x[i] >= px - pedgeH)
playerHit();
if(laser && lasery <= y[i] + edgeV && lasery >= y[i] - edgeV && laserx <= x[i] + edgeH && laserx >= x[i] - edgeH)
alienHit(i);
for(int j = 0; j < slen; j++)
if(!dead[j])
if(framecount == 3)
frame[j] = frame[j] + 1 < 2 ? 1 : 0;
lastx = x[j];
lasty = y[j];
x[j] += dx[j][dxcount[j]];
y[j] += dy[j][dycount[j]];
if(pmode[j] == 0)
dxcount[j] = dxcount[j] + 1 < dx[j].length ? dxcount[j] + 1 : 0;
dycount[j] = dycount[j] + 1 < dy[j].length ? dycount[j] + 1 : 0;
} else
if(pmode[j] == 2)
dxcount[j] = dxcount[j] + 1 < dx[j].length ? dxcount[j] + 1 : dxcount[j];
dycount[j] = dycount[j] + 1 < dy[j].length ? dycount[j] + 1 : dycount[j];
packX[j] += packdx[packcount];
packY[j] += packdy[packcount];
packcount = packcount + 1 < packlen ? packcount + 1 : 0;
framecount = framecount + 1 < 4 ? framecount + 1 : 0;
if(laser)
lasery -= 6;
if(lasery < 0 )
laser = false;
// this will move the object UP,DOWN,Left and Right
private void updatePlayerPos(int i)
plastx = px;
px += i;
if(px + pedgeH > WIDTH || px - pedgeH < 0)
px = plastx;
private void updatePlayerPos1(int i)
plastx = py;
py += i;
if(px + pedgeV > HEIGHT || px - pedgeV < 0)
px = plastx;
// This will fire, if you hit the fire button
private void fireLaser()
if(!laser)
laser = true;
laserx = px;
lasery = py;
sorry if it's too long i just want too explain this. if anyone like to see this and run so that you can see it also, i can send an email.
thanks,
alek