Plsql block not executing

Question

Hi ,
The Below block not executing,please correct this block
declare
v_sql varchar2(1024);
begin
 for c in (
   SELECT TABLE_NAME FROM USER_TABLES WHERE TABLE_NAME LIKE 'B2M_%' and PARTITIONED='YES';
loop
  v_sql:='DELETE FROM '||'' || c.TABLE_NAME || ''||'WHERE SUB_SUBSIDIARYCODE=&1' ||''||'and TO_CHAR(DATE_FROM_PK, 'DD/MM/YYYY')=&2';
  execute immediate v_sql;
  end loop;
end;
thanks,
tmadugula

Answer 1

It would be helpful if you provided the actual errors and posted the code using \ tags so it was legible.
Please see {thread:id=2174552}
As far as your code, you don't need the semi-colon in the SELECT statement. Second, you should consider using bind variables in your code because it will prevent SQL injection attacks as well as make it easier to read/maintain your code. Also, instead of converting the DATE_FROM_PK to a character data type, consider converting your input value to a DATE data type.
This should work (not tested), in versions 10.2 and up:DECLARE
v_sql varchar2(1024);
v_date_filter VARCHAR2(10);
v_subsidiary_code_filter VARCHAR2(10); -- Correct this data type if incorrect.
BEGIN
v_subsidiary_code_filter := q'[&1]';
v_date_filter := q'[&2]';
FOR c IN
SELECT table_name
FROM user_tables
WHERE table_name LIKE 'B2M_%'
AND partitioned = 'YES'
LOOP
v_sql:='DELETE FROM '|| DBMS_ASSERT.SQL_OBJECT_NAME(c.TABLE_NAME) || ' WHERE SUB_SUBSIDIARYCODE = :1 ' || ' AND TRUNC(DATE_FROM_PK) = TO_DATE(:2,''MM/DD/YYYY'')';
EXECUTE IMMEDIATE v_sql USING v_subsidiary_code_filter, v_date_filter;
END LOOP;
END;Edited by: Centinul on Mar 11, 2011 8:30 AM