Plz help me convert this into a table format

Question

Hi,
private String makeInfo(Vector p_dataV)
String info = "";
if (p_dataV.size() > 0)
info += "<font size=1>";
for (int i=0; i<p_dataV.size(); i=i+2)
info += p_dataV.elementAt(i) + ": <b>" + p_dataV.elementAt(i+1) + "</b><br>";
info += "</font><br>";
return info;
I want values of p_dataV.elementAt(i) in one row &
values of p_dataV.elementAt(i+1) underneath the first row
Plz help ......
Regards,
Vishal

Answer 1

Come on dude, its pretty simple.
The following should work.
I've used Collection Interface rather than Vector (makes it more generic)
also used an iterator rather than a for loop.
And used a StringBuffer for building the data in the loop, rather than a String (more efficient). In Java1.5 you should probably use an enhanced for loop, and a StringBuilder.
I was also careful about the fact of bad data in the list. It won't break if you don't provide an odd number of elements.
private String makeInfo(Collection p_dataV)
String info = "";
StringBuffer topRow = new StringBuffer();
StringBuffer bottomRow = new StringBuffer();
for(Iterator it = p_dataV.iterator(); it.hasNext(); ){
  topRow.append("<td>" + it.next() + "</td>");
  if (it.hasNext()){
    bottomRow.append("<td>" + it.next() + "</td>");
info = "<table><tr>";
info += topRow.toString();
info += "</tr><tr>";
info += bottomRow.toString();
info += "</tr></table>";
return info;