PreparedStatement problem

Question

hi experts,
i have this simple bean for inserting data into the database...........................
// EmployeeDataBaseBean.java
package wh;
import java.lang.*;
import java.sql.*;
import javax.servlet.*;
import javax.servlet.http.*;
public class EmployeeDatabaseBean
String email = "";
String empname = "";
String extno = "";
String cellno = "";
String remarks = "";
HttpServletRequest request = null;
Connection dbConn = null;
* Set the request object. This is used for getting parameters.
public void setRequest(HttpServletRequest request)
this.request = request;
}//public void setRequest(HttpRequest request)
* Connect to the database.
public void connectToDatabase()
throws Exception
/* Use JDBC to connect to the SAMPLE database.*/
Class.forName("COM.ibm.db2.jdbc.app.DB2Driver").newInstance();
String url = "jdbc:db2:one";
String dbUser = "";
String dbPass = "";
Connection dbConn = DriverManager.getConnection(url);
/* If the connection fails, throw an Exception.*/
if(dbConn == null)
throw new Exception("The database connection failed.");
System.out.println("called connect inside connnecttodatabase");
* Run the SELECT statement query to return a single EMPLOYEE record.
public void runQuery()
throws Exception
/* Connect to the database.*/
connectToDatabase();
/* Get the EMPNO parameter from the request object.*/
String empmailParam = request.getParameter("EMAIL");
/* Build a SQL SELECT statement.*/
String sql = "SELECT EMAIL, EMP_NAME, EXT_NO, CELL_NO, REMARKS " +
"FROM CONTACT WHERE EMAIL = ?";
/* Prepare the SELECT statement.*/
PreparedStatement statement = dbConn.prepareStatement(sql);
/* Set the parameter in the SELECT statement and run it.*/
statement.setObject (1, empmailParam);
ResultSet result = statement.executeQuery();
/* Get the result row.*/
while(result.next())
email = result.getString("EMAIL");
empname = result.getString("EMP_NAME");
extno = result.getString("EXT_NO");
cellno = result.getString("CELL_NO");
remarks = result.getString("REMARKS");
/* Close the connection.*/
dbConn.close();
* Insert a record to the database.
public void insertEmployee()
throws Exception
/* Connect to the database.*/
connectToDatabase();
System.out.println("connected to db2 through insertemployee");
/* Get all the parameters from the calling HTML form.*/
String mailParam = request.getParameter("EMAIL");
System.out.println("the email is " + request.getParameter("EMAIL"));
String nameParam = request.getParameter("EMPNAME");
System.out.println("the name is " + request.getParameter("EMPNAME"));
int extnoParam = Integer.parseInt(request.getParameter("EXTNO"));
System.out.println("the extension number is " + request.getParameter("EXTNO"));
int cellnoParam = Integer.parseInt(request.getParameter("CELLNO"));
System.out.println("the cellno is " + request.getParameter("CELLNO"));
String remarksParam = request.getParameter("REMARKS");
System.out.println("the remark is " + request.getParameter("REMARKS"));
System.out.println("building sql query");
/* Build a SQL INSER statement.*/
String sql = "INSERT INTO CONTACT " + "(EMAIL, EMP_NAME, EXT_NO, CELL_NO, REMARKS) " + " VALUES " + "(?,?,?,?,?)";
System.out.println("executed sql statement");
/* Prepare the SELECT statement.*/
PreparedStatement statement = dbConn.prepareStatement(sql);
System.out.println("using preparedstatement");
/* Set the parameters for the INSERT run it.*/
statement.setString(1, mailParam);
statement.setString(2, nameParam);
statement.setInt(3, extnoParam);
statement.setInt(4, cellnoParam);
statement.setString(5, remarksParam);
boolean returnValue = statement.execute();
/* Close the connection.*/
dbConn.close();
System.out.println("query executed");
}//public void insertEmployee()
* Return the empNo.
public String getemail()
return email;
* Return the firstNme.
public String getempname()
return empname;
* Return the midInit.
public String getextno()
return extno;
* Return the lastName.
public String getcellno()
return cellno;
* Return the edLevel.
public String getremarks()
return remarks;
//and the html page calling the jsp page which inturn uses the bean.
//EmployeeInput.html
<HTML>
<HEAD>
<TITLE>
Employee Input
</TITLE>
</HEAD>
<BODY BGCOLOR="#f0f0ff">
<H2>Insert An Employee:</H2>
<BR><FORM NAME="employeeForm" ACTION="EmployeeDisplay.jsp">
<table border=2>
<tr>
<td>EMail:</td>
<td><INPUT NAME="EMAIL" VALUE="" TYPE="text"></td>
</tr>
<tr>
<td>Employee Name:</td>
<td><INPUT NAME="EMPNAME" VALUE="" TYPE="text"></td>
</tr>
<tr>
<td>Extension Number:</td>
<td><INPUT NAME="EXTNO" VALUE="" TYPE="text" LENGTH="6"></td>
</tr>
<tr>
<td>Cell Number:</td>
<td><INPUT NAME="CELLNO" VALUE="" TYPE="text"></td>
</tr>
<tr>
<td>Remarks:</td>
<td><INPUT NAME="REMARKS" VALUE="" TYPE="text"></td>
</tr>
<tr>
<td><center><INPUT NAME="submitButton" VALUE="Insert" TYPE="submit"></center></td>
</tr>
</FORM>
</BODY>
</HTML>
// the jsp page that uses the bean.
//EmployeeDisplay.jsp
<jsp:useBean id="employeeDatabaseBean" class="wh.EmployeeDatabaseBean" scope="request"/>
<!-- Perform the actions on the bean. -->
<%
try
/* Set the request object.*/
/* The request object is implicitly available in the JSP page.*/
employeeDatabaseBean.setRequest(request);
/* Insert the employee data into the database.*/
employeeDatabaseBean.insertEmployee();
/* Run the query to retrieve the employee data from the database.*/
//employeeDatabaseBean.runQuery();
catch (Exception e)
System.out.println(e.getMessage());
%>
<HTML>
<HEAD>
<TITLE>
Employee Display
</TITLE>
</HEAD>
<BODY BGCOLOR="#FFFFFF">
<H2>Employee Record:</H2>
<BR><FORM NAME="employeeDisplayForm" >
<BR>Employee No: <INPUT NAME="EMPNO" VALUE="<%= employeeDatabaseBean.getemail() %>" TYPE="text">
<BR>First Name: <INPUT NAME="FIRSTNME" VALUE="<%= employeeDatabaseBean.getempname() %>" TYPE="text">
<BR>Mid: <INPUT NAME="MIDINIT" VALUE="<%= employeeDatabaseBean.getextno() %>" TYPE="text" LENGTH="4">
<BR>Last Name: <INPUT NAME="LASTNAME" VALUE="<%= employeeDatabaseBean.getcellno() %>" TYPE="text">
<BR>Education Level: <INPUT NAME="EDLEVEL" VALUE="<%= employeeDatabaseBean.getremarks() %>" TYPE="text">
</FORM>
</BODY>
</HTML>
my problem is that the file runs perfectly on the browser. The issue arises here that the data doesnt gets inserted into the database...................also that the console does not show any error either........what i feel is that the prepared statement isnt functioning properly.......the control doesnt moves beyond the prepared statement
plz help

Answer 1

Hello hermione,
Try to insert a space after end of string in the SQL-statement, just before the qoutes, then it hopefully works, as bellow.
String sql = "INSERT INTO CONTACT " + "(EMAIL, EMP_NAME, EXT_NO, CELL_NO, REMARKS) " + " VALUES " + "(?,?,?,?,?)";
//javanalle