Problem with 1-to-many relationship between entity beans

Question

Hi All!
I have two tables TMP_GROUP and TMP_EMPLOYEE with following fields:
TMP_GROUP: ID, CAPTION, COMMENT, STATUS.
TMP_EMPLOYEE: ID, LOGIN, GROUP_ID.
For this tables i create two entity beans GROUP and EMPLOYEE respectively.
The relationship looks like this
descriptor ejb.xml:
<ejb-relation>
            <description>description</description>
            <ejb-relation-name>employeesOfGroup</ejb-relation-name>
            <ejb-relationship-role>
                <ejb-relationship-role-name>com.mypackage.GroupBean</ejb-relationship-role-name>
                <multiplicity>One</multiplicity>
                <relationship-role-source>
                    <ejb-name>GroupBean</ejb-name>
                </relationship-role-source>
                <cmr-field>
                    <cmr-field-name>employees</cmr-field-name>
                    <cmr-field-type>java.util.Collection</cmr-field-type>
                </cmr-field>
            </ejb-relationship-role>
            <ejb-relationship-role>
                <ejb-relationship-role-name>com.mypackage.EmployeeBean</ejb-relationship-role-name>
                <multiplicity>Many</multiplicity>
                <relationship-role-source>
                    <ejb-name>EmployeeBean</ejb-name>
                </relationship-role-source>
            </ejb-relationship-role>
        </ejb-relation>
descriptor persistent.xml:
<table-relation>
               <table-relationship-role
                    key-type="PrimaryKey">
                    <ejb-name>GroupBean</ejb-name>
                    <cmr-field>employees</cmr-field>
               </table-relationship-role>
               <table-relationship-role
                    key-type="NoKey">
                    <ejb-name>EmployeeBean</ejb-name>
                    <fk-column>
                         <column-name>GROUP_ID</column-name>
                         <pk-field-name>ejb_pk</pk-field-name>
                    </fk-column>
               </table-relationship-role>
          </table-relation>
Now i implement business method:
public Long addEmployee(String login, long groupId) {
          Long result;
          try {
               EmployeeLocal employee = employeeHome.create(login);
               GroupLocal group =
                    groupHome.findByPrimaryKey(new Long(groupId));
               Collection employees = group.getEmployees();
               employees.add(employee);
               result = (Long) employee.getPrimaryKey();
          } catch (CreateException ex) {
               result = new Long(0);
          } catch (FinderException ex) {
               result = new Long(0);
          return result;
When i call this method from web service, the following exception is raised:
com.sap.engine.services.ejb.exceptions.BaseTransactionRolledbackLocalException: Exception in method com.mypackage.GroupLocalHomeImpl0.findByPrimaryKey(java.lang.Object).
P.S.
1) I have transaction attribute set to "Required" for all methods of all beans
2) I have unique index for each table:
TMP_GROUP_I1: CAPTION
TMP_EMPLOYEE_I1: LOGIN (however i think GROUP_ID must be added here too)
3) I tried many:many relationship with this tables and it works fine
4) I try another implementation of addEmployee method with
EmployeeLocal employee = employeeHome.create(login, groupId);
without using GroupLocal cmr-field and GroupLocalHome findByPrimaryKey method, the result is same error.
Can somebody help me with this problem?
Thanks in advance.
Best regards, Abramov Andrey.

Answer 1

gimbal2 wrote:
1: The @JoinColumn on the listOfDepartments collection in Company is wrong. It should be something like this for a bidirectional relationship:
@OneToMany(mappedBy="company") // company is the matching property name in Department
private List <Department> listOfDepartment = new ArrayList<Department>();Note that I removed the fetch configuration; onetomany is fetched lazy by design. Saves some clutter eh.
2: use a Set in stead of a List (hibernate doesn't like lists much in entities and will break when you create slightly more complex entity relations)
3: don't just slap cascades on collections, especially of type ALL. Do it with care. In the many years I've been using JPA I've only had to cascade deletes in very specific situations, maybe once or twice. I never needed any of the other cascade types, they just invite sloppy code if you ask me. When working with persistence you should apply a little precision.I made all changes as you mentioned but still compID in department table shows null value...