Problem with Beansbinding as separated class

Question

Hello,
I used beansbinding together with a JTextfield and usually it works, which means that if I do it like the following;
  /// the class that I use implements a binding listener
binding = Bindings.createAutoBinding(AutoBinding.UpdateStrategy.READ_WRITE,                        // two-way binding
                                                    systemDaten ,                                                             //source and backing bean
                                                       BeanProperty.create("debeyeHueckelkonstanteA") ,          //name of field
                                                       debeyeHueckelkonstanteA,                                            // name of jtextfield as swing source
                                                       textProperty,                                                     //Property textProperty = BeanProperty.create("text");  
                                                      "debeyeHueckelkonstanteA" );                             // Name      
          binding.setConverter(null);
       binding.setValidator(null);
           binding.addBindingListener(this);                                                  /// this = because the class that I use implements a binding listener
        binding.bind();
//if I use instead of binding.addBindingListener(this) the following version with an anonym class, it works as well:
binding.addBindingListener(new BindingListener() {
            @Override
            public void bindingBecameBound(Binding binding) {
            @Override
            public void bindingBecameUnbound(Binding binding) {
            @Override
            public void syncFailed(Binding binding, SyncFailure failure) {
            @Override
            public void synced(Binding binding) {
            @Override
            public void sourceChanged(Binding binding, PropertyStateEvent event) {
            @Override
            public void targetChanged(Binding binding, PropertyStateEvent event) {
        } );if I use this form using a customized class and a constructor with the data (double number) to be represented :
                        binding.addBindingListener(new SystemBindingListener(systemDaten.getMesstemperatur()) )with a class implementing the listener as below it doesn't work.
public class SystemBindingListener implements BindingListener {
    private double value = 0.0;
    public SystemBindingListener(double value) {
     super();
     this.setValue(value);
    private final PropertyChangeSupport propertyChangeSupport =
     new PropertyChangeSupport(this);
     public void addPropertyChangeListener(PropertyChangeListener l) {
     propertyChangeSupport.addPropertyChangeListener(l);
    public void removePropertyChangeListener(PropertyChangeListener l) {
     propertyChangeSupport.removePropertyChangeListener(l);
             @Override
                public void bindingBecameBound(Binding binding) {
                    System.out.println("bound ok " + binding.getName());  }
            @Override
                public void bindingBecameUnbound(Binding binding) {
                    System.out.println("unbound ok " + binding.getName());  }
            @Override
                public void syncFailed(Binding binding, SyncFailure failure) {
                    System.out.println("sync not ok " + binding.getName());  }
            @Override
                public void synced(Binding binding) {
                this.setValue(value);
                  System.out.println("sync ok " + binding.getName() + this.getValue()); }
            @Override
                public void sourceChanged(Binding binding, PropertyStateEvent event) {
                    System.out.println("source ok " + binding.getName());    }
            @Override
                public void targetChanged(Binding binding, PropertyStateEvent event) {
                    System.out.println("target ok " + binding.getName()); }
        public double getValue(){
         return value;
        public void setValue(double value){
        final double old = this.value;
     this.value = value;
     propertyChangeSupport.firePropertyChange(
                      "value", // the name of the property
                      old, // the old value
                      value // the new value
        this.value = value;
}The problem is that I wanted to "outsource" the BindingListener but change its output depending on the source modified on the GUI.
I have several textfields and I want to be sure that whenever one of them gets modified the value is modified in the backing bean
and this should be visible by the System.out.println(this.getValue()) output.
I added Property Support but this didn't help. As you can see I want a Read-Write Binding which works as described in the first two examples.
But with a externalized class binding doesn't work.
Does anyone know how to do this.
Thanks for help
Thommy
Edited by: 886674 on 4 oct. 2011 08:31
Edited by: 886674 on 4 oct. 2011 08:35

Answer 1

Hello,
I am not sure if it is as short as you want to, but anyway there cannot be less classes than that, because I need each of them and any further reduction
would falsify the situation given.
Also there are only some lines which are determining size, location - and especially Layout - etc which I left nearly as they are.
Before using the given function addComponent() I had big problems to get a proper GUI Layout so I changed not to much concerning the layout (I didn't want to take the risk that nothing appears at all (or not at the right place) as I experienced many times before).
Anyway, it is much less than the 10 classes (or the 30 original classes) I had before. So here is the code:
package controls;
import java.awt.BorderLayout;
import java.awt.Component;
import java.awt.Dimension;
import java.awt.FlowLayout;
import java.awt.GridBagConstraints;
import java.awt.GridBagLayout;
import java.awt.GridLayout;
import java.awt.Toolkit;
import java.beans.PropertyChangeListener;
import java.beans.PropertyChangeSupport;
import javax.swing.JFrame;
import javax.swing.JLabel;
import javax.swing.JPanel;
import javax.swing.JTextField;
import org.jdesktop.beansbinding.AutoBinding;
import org.jdesktop.beansbinding.BeanProperty;
import org.jdesktop.beansbinding.Binding;
import org.jdesktop.beansbinding.Binding.SyncFailure;
import org.jdesktop.beansbinding.BindingGroup;
import org.jdesktop.beansbinding.BindingListener;
import org.jdesktop.beansbinding.Bindings;
import org.jdesktop.beansbinding.Property;
import org.jdesktop.beansbinding.PropertyStateEvent;
public class Main {
    public static Mainframe wg = null;
    public static void main(String[] args)  {
    wg = new Mainframe();
    wg.setVisible(true);
class Mainframe extends JFrame {
public static final long serialVersionUID = 1111111;
    private JPanel pnlOben;
    private JPanel pnlMitte;
    private KonstantenPanel kp = null;
    private   Dimension screendimension;
    private   Dimension dimension;   
    public Mainframe(){
    super();
    this.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
    screendimension = Toolkit.getDefaultToolkit().getScreenSize();
    dimension = new Dimension();
    dimension.setSize(400, 400);
    this.setSize(dimension);
    this.setLocation((int) ((screendimension.getSize().getWidth()) / 2), (int) (screendimension.getSize().getHeight()/ 2));
    init();
public void init(){
  desktopMalen();
private void desktopMalen() {
         this.setLayout(new BorderLayout(20, 20));
        this.add(NordPanelMalen(), BorderLayout.NORTH);
        this.add(CenterPanelMalen(), BorderLayout.WEST);
        this.add( new JPanel(),BorderLayout.SOUTH);
    private JPanel NordPanelMalen() {
        pnlOben = new JPanel(new FlowLayout(FlowLayout.LEFT));
        pnlOben.add(new JLabel("Test"));
       return pnlOben ;
   private JPanel CenterPanelMalen() {
        this.pnlMitte = new JPanel();  //new FlowLayout(FlowLayout.CENTER
        this.pnlMitte.setLayout(new GridLayout(1, 1));    
        Dimension d = new Dimension();       
        this.pnlMitte.setSize(400,400); d.setSize(400, 400);
        KonstantenPanel bp = new KonstantenPanel(d);  //// the panel with the swing component
         this.pnlMitte.add(bp);
  return pnlMitte;
class KonstantenPanel extends JPanel {
    public static final long serialVersionUID = 1111111;  
    private Systemdaten systemDaten = null;
    private JTextField messtemperatur;
    private BindingGroup bindinggroup = null;
    private Binding binding;
    private SystemBindingListener sbl1;
    public KonstantenPanel(Dimension d) {
    this.setSize(d);
    init();
    private void init() {
   systemDaten = new Systemdaten();           /////// the bean class
    GridBagLayout gbl = new GridBagLayout();
   this.setLayout(gbl);
    this.addComp(gbl,new JLabel("Konstanten"),0,0,4,1,0,0,GridBagConstraints.HORIZONTAL, GridBagConstraints.NORTHWEST);
    this.addComp(gbl,new JLabel("                   "),     0,1,4,1,0,0,GridBagConstraints.HORIZONTAL, GridBagConstraints.NORTHWEST);
    this.addComp(gbl,new JLabel("Messtemperatur   "),       0,2,2,1,0,0,GridBagConstraints.HORIZONTAL, GridBagConstraints.NORTHWEST);
                                                            /////the swing component using beansbinding
   messtemperatur = new JTextField("298.15             ");
   messtemperatur.setName("messtemperatur");
   this.addComp(gbl,messtemperatur ,  0,3,2,1,0,0,GridBagConstraints.HORIZONTAL, GridBagConstraints.NORTHWEST);
                                                     ///all the binding is done here in:
   bindProperties();
    @SuppressWarnings("unchecked")
        private void bindProperties() {
     Property textProperty = BeanProperty.create("text");
        bindinggroup=new BindingGroup();
     binding = Bindings.createAutoBinding(
       AutoBinding.UpdateStrategy.READ_WRITE, // two-way binding
       systemDaten,                 // bean
       BeanProperty.create("messtemperatur"),
       messtemperatur,        //field
       textProperty,        //name of property
       "messtemperatur" //name
        sbl1 = new SystemBindingListener(systemDaten.getMesstemperatur());
        binding.addBindingListener(sbl1);
        binding.setConverter(null);
     binding.setValidator(null);
         binding.bind();
         bindinggroup.addBinding(binding);
    bindinggroup.bind();
     public void addComp (   //Container cont,
                         GridBagLayout gbl, Component c, int x, int y, int width, int height, double weightx, double weighty, int cbc, int a)
    GridBagConstraints gbc = new GridBagConstraints();
    gbc.fill = cbc ; //GridBagConstraints.BOTH;
    gbc.gridx = x; gbc.gridy = y;
    gbc.gridwidth = width; gbc.gridheight = height;
    gbc.weightx = weightx; gbc.weighty= weighty;
    gbc.anchor = a; gbl.setConstraints(c, gbc);
    this.add(c);
     * in praxis the extra class would be especially interesting if there are more variables     *
class SystemBindingListener implements BindingListener {
    private double value = 0.0;
    SystemBindingListener(double value) {
     super();
     this.setValue(value);
    private final PropertyChangeSupport propertyChangeSupport =     new PropertyChangeSupport(this);
    void addPropertyChangeListener(PropertyChangeListener l) {
     propertyChangeSupport.addPropertyChangeListener(l);
    void removePropertyChangeListener(PropertyChangeListener l) {
     propertyChangeSupport.removePropertyChangeListener(l);
             @Override
                public void bindingBecameBound(Binding binding) {
                    System.out.println("bound ok " + binding.getName());  }
            @Override
                public void bindingBecameUnbound(Binding binding) {
                    System.out.println("unbound ok " + binding.getName());  }
            @Override
                public void syncFailed(Binding binding, SyncFailure failure) {
                    System.out.println("sync not ok " + binding.getName());  }
            @Override
                public void synced(Binding binding) {
                this.setValue(value);
                  System.out.println("sync ok " + binding.getName() + this.getValue()); }
            @Override
                public void sourceChanged(Binding binding, PropertyStateEvent event) {
                    System.out.println("source ok " + binding.getName());    }
            @Override
                public void targetChanged(Binding binding, PropertyStateEvent event) {
                    System.out.println("target ok " + binding.getName()); }
        double getValue(){
         return value;
       void setValue(double value){
        final double old = this.value;
     this.value = value;
     propertyChangeSupport.firePropertyChange(
                      "value", // the name of the property
                      old, // the old value
                      value // the new value
        this.value = value;
class Systemdaten {
static final long serialVersionUID = 1111111L;
    private double messtemperatur = 298.15;
    private final PropertyChangeSupport propertyChangeSupport =     new PropertyChangeSupport(this);
   void addPropertyChangeListener(PropertyChangeListener l) {
     propertyChangeSupport.addPropertyChangeListener(l);
   void removePropertyChangeListener(PropertyChangeListener l) {
     propertyChangeSupport.removePropertyChangeListener(l);
  double getMesstemperatur() {
        return messtemperatur;
   void setMesstemperatur(double messtemperatur) {
        final double old = this.messtemperatur;
     this.messtemperatur = messtemperatur;
     propertyChangeSupport.firePropertyChange(
                      "messtemperatur", // the name of the property
                      old, // the old value
                      messtemperatur // the new value
        this.messtemperatur = messtemperatur;
}Due to your questions I guess to know why it there is no binding between the Listener-Instance and the Swing-Compound but
I don't see how to get all three classes working together.
I mean: If I want to have a binding between the value variable in the BindingListener and the SwingCompound I need to create such a binding in the panel-Class.
But I only created a binding with the field in systemDaten because this is the bean I want to work with.
It seems that I didn't understand how it is managed that the value is changing in the bean and the swingcompound simultaneously - after creating and adding the
BindingListener-Instance.
In the two other cases there is still a communication between the Listener and the swingCompound but in the given case there is not.
I was not aware of this problem before and I am still not sure to fully understand why it works in the other cases.
Do I need to give the binding variable or swing compound to the BindingListener to keep communication ?
Thanks for your help
Thommy