Problems with variables in query

Question

I need add variable to my query, made in query generator. My query is long...doesn't work.
I read a possible solution for this: declare variable and then use it. For example:
Declare @FromDate as DateTime
Declare @ToDate as DateTime
set FromDate =  '[%0]'
set ToDate =  '[%1]'
and then implements it: select * from  [table] where Date between @FromDate and @ToDate
...but doesn't work.
Any suggestions?
Roberto.
PD: I left my query:
declare @fdesde as datetime
declare @fhasta as datetime
set @fdesde = '[%0]'
set @fhasta = '[%1]'
select * from (SELECT
A.DOCENTRY as NroDocumento,
max(A.DOCDATE) AS FECHA,
max(CASE WHEN A.U_TGV_FLETTER = 'A' AND A.U_TGV_ACC_ORD_FLAC <> 1 THEN '1'
WHEN A.U_TGV_FLETTER = 'B' AND A.U_TGV_ACC_ORD_FLAC <> 1 THEN '6'
WHEN A.U_TGV_FLETTER = 'C' AND A.U_TGV_ACC_ORD_FLAC <> 1 THEN '11'
WHEN A.U_TGV_FLETTER = 'E' AND A.U_TGV_ACC_ORD_FLAC <> 1 THEN '19'
WHEN A.U_TGV_FLETTER = 'M' AND A.U_TGV_ACC_ORD_FLAC <> 1 THEN '51'
WHEN A.U_TGV_FLETTER = 'A' AND A.U_TGV_ACC_ORD_FLAC = 1 THEN '60'
WHEN A.U_TGV_FLETTER = 'B' AND A.U_TGV_ACC_ORD_FLAC = 1 THEN '61'
WHEN A.U_TGV_FLETTER = 'C' AND A.U_TGV_ACC_ORD_FLAC = 1 THEN '62' ELSE 'NA'
END) AS TIPOCOMP,
max(isnull(Convert(varchar,isnull(A.U_TGV_FOLIO_PREFIX,'0')) + '-' + Convert(varchar,A.folionum),'')) AS NUMCOMP,
max(isnull(A.CARDNAME, '')) AS RAZONSOCIAL,
max(Replace(LICTRADNUM,'-','')) AS CUIT,
round(sum(case when a.U_TGV_TVAT_POS_BP = 'EX' then 0 else case when b.vatprcnt = 0 then b.linetotal else 0 end end), 4) as NOGRAVEXCENTO,
round(sum(case when b.vatprcnt <> 0 then b.linetotal else 0 end),4) as IMPGRAVADO,
max(b.vatprcnt) as ALICUOTA,
round(sum(b.vatsum),4) as IVA,
round(sum(case when a.U_TGV_TVAT_POS_BP = 'EX' then b.linetotal else 0 end),4) as OPEXENTA,
max(round(ISNULL(AA.TOTAL, 0),4)) AS PERCIVA,
max(round(ISNULL(BB.TOTAL, 0),4)) AS PERCIIBB,
'1' AS CONSULTA
FROM [dbo].[OPCH]  A
INNER JOIN [dbo].[PCH1]  B ON A.DOCENTRY = B.DOCENTRY
LEFT JOIN (SELECT A.DOCENTRY, SUM(A.LINETOTAL) AS TOTAL FROM [dbo].[PCH1] A
                                   INNER JOIN [dbo].[OITM] B ON A.ITEMCODE = B.ITEMCODE
                                   INNER JOIN [dbo].[OWHT] C ON B.ITEMCODE = C.U_TGV_CODE_ITEM
                                   WHERE U_TGV_PERCEP_FLAG = 1 AND U_TGV_PERC_TYPE = 1
                                   group by A.DOCENTRY) AA ON AA.DOCENTRY = A.DOCENTRY
LEFT JOIN (SELECT A.DOCENTRY, SUM(A.LINETOTAL) AS TOTAL FROM [dbo].[PCH1] A
                                   INNER JOIN [dbo].[OITM] B ON A.ITEMCODE = B.ITEMCODE
                                   INNER JOIN [dbo].[OWHT] C ON B.ITEMCODE = C.U_TGV_CODE_ITEM
                                   WHERE U_TGV_PERCEP_FLAG = 1 AND U_TGV_PERC_TYPE = 2
                                   group by A.DOCENTRY) BB ON BB.DOCENTRY = A.DOCENTRY
INNER JOIN [dbo].[OITM] I on  b.ItemCode = I.ItemCode
Where I.U_TGV_PERCEP_FLAG = 0
group by a.DOCENTRY,  b.taxcode
UNION ALL
SELECT
A.DOCENTRY as NroDocumento,
max(A.DOCDATE) AS FECHA,
max(CASE WHEN A.U_TGV_FLETTER = 'A' THEN '3'
WHEN A.U_TGV_FLETTER = 'B' THEN '8'
WHEN A.U_TGV_FLETTER = 'C' THEN '13'
WHEN A.U_TGV_FLETTER = 'M' THEN '53'
ELSE 'NA'
END) AS TIPOCOMP,
max(isnull(Convert(varchar,isnull(A.U_TGV_FOLIO_PREFIX,'0')) + '-' + Convert(varchar,A.folionum),'')) AS NUMCOMP,
max(isnull(A.CARDNAME, '')) AS RAZONSOCIAL,
max(Replace(LICTRADNUM,'-','')) AS CUIT,
round(sum(case when b.vatprcnt = 0 then b.linetotal else 0 end), 4) as NOGRAVEXCENTO,
round(sum(case when b.vatprcnt <> 0 then b.linetotal else 0 end),4) as IMPGRAVADO,
max(b.vatprcnt) as ALICUOTA,
round(sum(b.vatsum),4) as IVA,
round(sum(case when a.U_TGV_TVAT_POS_BP = 'EX' then b.linetotal else 0 end),4) as OPEXENTA,
max(round(ISNULL(AA.TOTAL, 0),4)) AS PERCIVA,
max(round(ISNULL(BB.TOTAL, 0),4)) AS PERCIIBB,
'1' AS CONSULTA
FROM [dbo].[ORPC] A
INNER JOIN [dbo].[RPC1] B ON A.DOCENTRY = B.DOCENTRY
LEFT JOIN (SELECT A.DOCENTRY, SUM(A.LINETOTAL) AS TOTAL FROM [dbo].[PCH1] A
                                   INNER JOIN [dbo].[OITM] B ON A.ITEMCODE = B.ITEMCODE
                                   INNER JOIN [dbo].[OWHT] C ON B.ITEMCODE = C.U_TGV_CODE_ITEM
                                   WHERE U_TGV_PERCEP_FLAG = 1 AND U_TGV_PERC_TYPE = 1
                                   group by A.DOCENTRY) AA ON AA.DOCENTRY = A.DOCENTRY
LEFT JOIN (SELECT A.DOCENTRY, SUM(A.LINETOTAL) AS TOTAL FROM [dbo].[PCH1] A
                                   INNER JOIN [dbo].[OITM] B ON A.ITEMCODE = B.ITEMCODE
                                   INNER JOIN [dbo].[OWHT] C ON B.ITEMCODE = C.U_TGV_CODE_ITEM
                                   WHERE U_TGV_PERCEP_FLAG = 1 AND U_TGV_PERC_TYPE = 2
                                   group by A.DOCENTRY) BB ON BB.DOCENTRY = A.DOCENTRY
INNER JOIN [dbo].[OITM] I on  b.ItemCode = I.ItemCode
Where I.U_TGV_PERCEP_FLAG = 0
group by a.DOCENTRY,  b.taxcode
UNION ALL
SELECT max(TOT.C1) as NroDocumento,max(TOT.C2) as Fecha, max(TOT.C3), max(TOT.C4), max(TOT.C5),max(TOT.C6),sum(TOT.NOGRAVEXCENTO),sum(TOT.IMPGRAVADO),max(TOT.ALICUOTA),sum(TOT.IVA),sum(TOT.OPEXENTA),max(TOT.PERCIVA),max(TOT.PERCIIBB),max(TOT.CONSULTA) FROM
SELECT
'' AS C1,
'' AS C2,
'' AS C3,
'' AS C4,
'' AS C5,
'' AS C6,
round(sum(case when b.vatprcnt = 0 then b.linetotal else 0 end), 4) as NOGRAVEXCENTO,
round(sum(case when b.vatprcnt <> 0 then b.linetotal else 0 end),4) as IMPGRAVADO,
max(b.vatprcnt) as ALICUOTA,
round(sum(b.vatsum),4) as IVA,
round(sum(case when a.U_TGV_TVAT_POS_BP = 'EX' then b.linetotal else 0 end),4) as OPEXENTA,
max(round(ISNULL(AA.TOTAL, 0),4)) AS PERCIVA,
max(round(ISNULL(BB.TOTAL, 0),4)) AS PERCIIBB,
'2' AS CONSULTA
FROM [dbo].[OPCH] A
INNER JOIN [dbo].[PCH1] B ON A.DOCENTRY = B.DOCENTRY
LEFT JOIN (SELECT A.DOCENTRY, SUM(A.LINETOTAL) AS TOTAL FROM [dbo].[PCH1] A
                                   INNER JOIN [dbo].[OITM] B ON A.ITEMCODE = B.ITEMCODE
                                   INNER JOIN [dbo].[OWHT] C ON B.ITEMCODE = C.U_TGV_CODE_ITEM
                                   WHERE U_TGV_PERCEP_FLAG = 1 AND U_TGV_PERC_TYPE = 1
                                   group by A.DOCENTRY) AA ON AA.DOCENTRY = A.DOCENTRY
LEFT JOIN (SELECT A.DOCENTRY, SUM(A.LINETOTAL) AS TOTAL FROM [dbo].[PCH1] A
                                   INNER JOIN [dbo].[OITM] B ON A.ITEMCODE = B.ITEMCODE
                                   INNER JOIN [dbo].[OWHT] C ON B.ITEMCODE = C.U_TGV_CODE_ITEM
                                   WHERE U_TGV_PERCEP_FLAG = 1 AND U_TGV_PERC_TYPE = 2
                                   group by A.DOCENTRY) BB ON BB.DOCENTRY = A.DOCENTRY
INNER JOIN [dbo].[OITM] I on  b.ItemCode = I.ItemCode
Where I.U_TGV_PERCEP_FLAG = 0
group by b.taxcode
UNION ALL
SELECT
'' AS C1,
'' AS C2,
'' AS C3,
'' AS C4,
'' AS C5,
'' AS C6,
round(sum(case when b.vatprcnt = 0 then b.linetotal else 0 end), 4) as NOGRAVEXCENTO,
round(sum(case when b.vatprcnt <> 0 then b.linetotal else 0 end),4) as IMPGRAVADO,
max(b.vatprcnt) as ALICUOTA,
round(sum(b.vatsum),4) as IVA,
round(sum(case when a.U_TGV_TVAT_POS_BP = 'EX' then b.linetotal else 0 end),4) as OPEXENTA,
max(round(ISNULL(AA.TOTAL, 0),4)) AS PERCIVA,
max(round(ISNULL(BB.TOTAL, 0),4)) AS PERCIIBB,
'2' AS CONSULTA
FROM [dbo].[ORPC] A
INNER JOIN RPC1 AS B ON A.DOCENTRY = B.DOCENTRY
LEFT JOIN (SELECT A.DOCENTRY, SUM(A.LINETOTAL) AS TOTAL FROM [dbo].[PCH1] A
                                   INNER JOIN [dbo].[OITM] B ON A.ITEMCODE = B.ITEMCODE
                                   INNER JOIN [dbo].[OWHT] C ON B.ITEMCODE = C.U_TGV_CODE_ITEM
                                   WHERE U_TGV_PERCEP_FLAG = 1 AND U_TGV_PERC_TYPE = 1
                                   group by A.DOCENTRY) AA ON AA.DOCENTRY = A.DOCENTRY
LEFT JOIN (SELECT A.DOCENTRY, SUM(A.LINETOTAL) AS TOTAL FROM [dbo].[PCH1] A
                                   INNER JOIN [dbo].[OITM] B ON A.ITEMCODE = B.ITEMCODE
                                   INNER JOIN [dbo].[OWHT] C ON B.ITEMCODE = C.U_TGV_CODE_ITEM
                                   WHERE U_TGV_PERCEP_FLAG = 1 AND U_TGV_PERC_TYPE = 2
                                   group by A.DOCENTRY) BB ON BB.DOCENTRY = A.DOCENTRY
INNER JOIN [dbo].[OITM] I on  b.ItemCode = I.ItemCode
Where I.U_TGV_PERCEP_FLAG = 0
group by b.taxcode
) TOT
group by TOT.ALICUOTA) TOTGEN
where TOTGEN.FECHA between @fdesde  and @fhasta
order by TOTGEN.fecha

Answer 1

Hi Roberto,
Try the following:
DECLARE @cnt AS SMALLINT, @DateFrom AS DATETIME , @DateTo AS DATETIME 
SELECT @cnt = count(*) FROM [dbo].[OINV] T0 WHERE T0.DocDate = '[%0]'
SELECT @cnt = count(*) FROM [dbo].[OINV] T1 WHERE T1.DocDate = '[%1]'
SET @DateFrom = '[%0]'
SET @DateTo = '[%1]'
IF @DateTo = '1900-01-01'
BEGIN
SET @DateTo = '2999-12-31'
END
SELECT DocNum, DocDate, CardCode, DocTotal 
FROM dbo.[OINV]
WHERE DocDate >= @DateFrom AND DocDate <= @DateTo
ORDER BY DocNum
FOR BROWSE
The @cnt variable is only used as a mechanism to get the user values into the SAP parameter variables, which are then assigned to @DateFrom and @DateTo.
If the user does not enter any parameter values then SAP automatically assigns a value of '1900-01-01', which is fine for DateFrom but not DateTo - so if @DateTo equals this then I assign some future date so all transactions should be returned.
Hope this helps.
Regards,
Andrew.