PROBLUM IN RESULT OF IF ELSE

Question

Hi all i have table and data like this
sale_order_id  QTY     item_type
12554          58     DYEING
12554          30     CUTTING
12554          58     PRINTINGAND MY CODE IS LIKE THIS
DECLARE
     a_qty NUMBER;
     a_sale_order_no VARCHAR2(100);
     a_item_type VARCHAR2(100);
  CURSOR gin_c IS SELECT gd1.sale_order_id,SUM(nvl(gd1.s,0)+nvl(gd1.xs,0)+nvl(gd1.m,0)
                                              +nvl(gd1.l,0)+nvl(gd1.xl,0)+nvl(gd1.pcs,0)) qty,gin.item_type
                FROM gin,gin_detail1 gd1
                WHERE gin.id=gd1.id and sale_order_id=:sale_order_no
                GROUP BY gd1.sale_order_id, gin.item_type;
BEGIN
     open gin_c;
     LOOP
     fetch gin_c INTO a_sale_order_no,a_qty,a_item_type;
     IF a_qty IS NULL THEN
          :item6:='NOT_PROCESSED';
     ELSIF a_qty<>:item and UPPER(a_item_type)=UPPER('dyeing') THEN
          :item6:='PROCESS In DYE';
     ELSIF a_qty<>:item and UPPER(a_item_type)=UPPER('CUTTING') THEN
          :item6:='PROCESS In CUTTING';
  ELSIF a_qty<>:item and a_item_type='PRINTING' THEN
          :item6:='PROCESS In PRI';
     ELSE
          :item6:='dddddd';
     END IF;
          EXIT when gin_c%NOTFOUND;
     END LOOP;
     CLOSE gin_c;
end;:item6 get the value dddddd but as per my table data the result must be 'PROCESS In CUTTING.
Please Guide
Thanks And Regards
Vikas

Answer 1

a_qty:item and UPPER(a_item_type)=UPPERWhat exactly is this condition testing for? I get the and UPPER(a_item_type)=UPPER..., but what does IF a_qty:item checking? Does this code compile? I'm not familiar with this notation. Your first check is to ensure a_qty is not null. Do you care what the quantity is if it is not null? I believe this might be where your bug is because you are simply checking that a_qty:item is TRUE (it has a value) and the item type matches a condition. If a_qty simply has to have a value, you could simplify your code. For example:
DECLARE
   CURSOR gin_c IS
      SELECT gd1.sale_order_id
             ,SUM(nvl(gd1.s,0)+nvl(gd1.xs,0)+nvl(gd1.m,0)
                 +nvl(gd1.l,0)+nvl(gd1.xl,0)+nvl(gd1.pcs,0)) qty
             ,gin.item_type
        FROM gin,gin_detail1 gd1
       WHERE gin.id=gd1.id and sale_order_id=:sale_order_no
       GROUP BY gd1.sale_order_id, gin.item_type;
BEGIN
   FOR rec IN gin_c LOOP
      IF ( rec.qty IS NULL ) THEN
         :item6:='NOT_PROCESSED';
      ELSIF ( rec.qty = 'something' AND UPPER(rec.item_type) = 'DYEING' ) THEN
         :item6:='PROCESS In DYE';
      ELSIF ( rec.qty = 'something' AND UPPER(rec.item_type) = 'CUTTING' ) THEN
         :item6:='PROCESS In CUTTING';
      ELSIF ( rec.qty = 'something' AND UPPER(rec.item_type) = 'PRINTING' ) THEN
         :item6:='PROCESS In PRI';
      ELSE
         :item6:='dddddd';
      END IF;
   END LOOP;
END;Craig...