Procedure not showing output

Question

Hi!
The following procedure does not show the output.
{create or replace procedure GET_USER
(username_in IN VARCHAR2, password_in IN VARCHAR2, first_name OUT VARCHAR2, last_name OUT VARCHAR2)
is
begin
  declare cursor c_user(i_username IN users.username%TYPE, i_password IN users.password%TYPE) is
  select first_name, last_name
  from users
  where username_in = i_username
  and password_in = i_password;
  i_username users.username%TYPE;
  i_password users.password%TYPE;
  l_first_name users.first_name%TYPE;
  l_last_name users.last_name%TYPE;
  begin
   if c_user%isopen then
     close c_user;
   end if;
   open c_user(i_username, i_password);
    fetch c_user into l_first_name, l_last_name;
   close c_user;
   first_name := l_first_name;
   last_name := l_last_name;
  end;
end GET_USER;}
Output showing only:
First_name =
Last_name =
Thanks for any help!

Answer 1

First of all, you've nested an anonymous block inside your procedure - there is no need to do this.
Second, you don't need to check if the cursor is already open before you open it; it will never be.
So, your code could be rewritten:
create or replace procedure GET_USER (username_in IN VARCHAR2,
                                      password_in IN VARCHAR2,
                                      first_name OUT VARCHAR2,
                                      last_name OUT VARCHAR2)
is
  cursor c_user(i_username IN users.username%TYPE,
                i_password IN users.password%TYPE)
  is
    select first_name, last_name
    from   users
    where  username_in = i_username
    and    password_in = i_password;
  l_first_name users.first_name%TYPE;
  l_last_name users.last_name%TYPE;
begin
  open c_user(username_in, password_in);
  fetch c_user into l_first_name, l_last_name;
  close c_user;
  first_name := l_first_name;
  last_name := l_last_name;
end GET_USER;
/My guess is that nothing is being returned by your cursor for the specified parameters. Test it out by doing:
create or replace procedure GET_USER (username_in IN VARCHAR2,
                                      password_in IN VARCHAR2,
                                      first_name OUT VARCHAR2,
                                      last_name OUT VARCHAR2)
is
  cursor c_user(i_username IN users.username%TYPE,
                i_password IN users.password%TYPE)
  is
    select first_name, last_name
    from   users
    where  username_in = i_username
    and    password_in = i_password;
  l_first_name users.first_name%TYPE;
  l_last_name users.last_name%TYPE;
begin
  open c_user(username_in, password_in);
  fetch c_user into l_first_name, l_last_name;
  if c_cursor%notfound then
    raise no_data_found;
  end if;
  close c_user;
  first_name := l_first_name;
  last_name := l_last_name;
end GET_USER;
/That way, if you get a No Data Found error, you'll know there were no matching rows.
Edited by: Boneist on 09-Jul-2009 12:26
Amended as the cursor wasn't being called with the procedure parameters and it should have been.
This is more likely to have been the cause of the error than no matching row in the cursor!