Procedure takes long time to execute...

Question

Hi all
i wrote the proxcedure but it takes long time to execute.
The INterdata table contains 300 records.
Here is the procedure:
create or replace procedure inter_filter
is
     /*v_sessionid interdata.sessionid%type;
     v_clientip interdata.clientip%type;
     v_userid interdata.userid%type;
     v_logindate interdata%type;
     v_createddate interdata%type;
     v_sourceurl interdata%type;
     v_destinationurl interdata%type;*/
     v_sessionid filter.sessionid%type;
     v_filterid filter.filterid%type;
     cursor c1 is
     select sessionid,clientip,browsertype,userid,logindate,createddate,sourceurl,destinationurl
     from interdata;
     cursor c2 is
     select sessionid,filterid
     from filter;
begin
     open c2;
     loop
          fetch c2 into v_sessionid,v_filterid;
          for i in c1 loop
               if i.sessionid = v_sessionid then
                    insert into filterdetail(filterdetailid,filterid,sourceurl,destinationurl,createddate)
                    values (filterdetail_seq.nextval,v_filterid,i.sourceurl,i.destinationurl,i.createddate);
               else
                    insert into filter (filterid,sessionid,clientip,browsertype,userid,logindate,createddate)
                    values (filter_seq.nextval,i.sessionid,i.clientip,i.browsertype,i.userid,i.logindate,i.createddate);
                    insert into filterdetail(filterdetailid,filterid,sourceurl,destinationurl,createddate)
                    values (filterdetail_seq.nextval,filter_seq.currval,i.sourceurl,i.destinationurl,i.createddate);
               end if;
          end loop;
     end loop;
     commit;
end
Please Help!
Prathamesh

Answer 1

i wrote the proxcedure but it takes long time to execute.Please define "long time". How long does it take? What are you expecting it to take?
The INterdata table contains 300 records.But how many records are there in the FILTER table? As this is the one you are driving off this is going to determine the length of time it takes to complete. Also, this solution inserts every row in the INTERDATA table for each row in the FILTER table - in other words, if the FILTER table has twenty rows to start with you are going to end up with 6000 rows in FILTERDETAIL. No wonder it takes a long time. Is that want you want?
Also of course, you are using PL/SQL cursors when you ought to be using set operations. Did you try the solution I posted in Re: Confusion in this  scenario>>>>>>> on this topic?
Cheers, APC