Procedure which inserted and returns value

Question

i don't know english very vell and sorry about it :(((
i want write a procedure which inserted or updated table and returns it's ID ...
it's my tabel :
DROP TABLE T_STUDENT CASCADE CONSTRAINTS;
CREATE TABLE T_STUDENT
ID NUMBER(10) NOT NULL,
NAME VARCHAR2(100) NOT NULL,
SURNAME VARCHAR2(100) NOT NULL,
AGE NUMBER(38) NOT NULL,
CNAUTHORID NUMBER(10) NULL
and i have procedure which inserted or updated this table and return's ID (if ID<=0 then inserted else updated):
CREATE OR REPLACE procedure sp_InsertUpdate_T_STUDENT
nResID in out NUMBER,
nID in NUMBER,
vchNAME in VARCHAR2,
vchSURNAME in VARCHAR2,
nAGE in NUMBER,
nCNAUTHORID in NUMBER
as
begin
if nID<=0 then
insert into T_STUDENT (NAME,SURNAME,AGE,CNAUTHORID) values (vchNAME,vchSURNAME,nAGE,nCNAUTHORID );
else
update T_STUDENT set NAME=vchNAME,SURNAME=vchSURNAME,AGE=nAGE,CNAUTHORID=nCNAUTHORID
where ID=nID;
end if;
select ID into nResID from T_STUDENT where NAME=vchNAME and
SURNAME=vchSURNAME and AGE=nAGE and CNAUTHORID=nCNAUTHORID;
end;
this procedure is correct but maybe returns more then one ID and i don't want it :( ....... how i can write this procedure otherwise ???

Answer 1

First of all does yout insert statement work??
insert into T_STUDENT (NAME,SURNAME,AGE,CNAUTHORID) values (vchNAME,vchSURNAME,nAGE,nCNAUTHORID )
Should you not insert also the value ID?
The way i would do this was first since u have only have one return value is a function like this:
function sp_InsertUpdate_T_STUDENT
nID in NUMBER,
vchNAME in VARCHAR2,
vchSURNAME in VARCHAR2,
nAGE in NUMBER,
nCNAUTHORID in NUMBER
) return number
is
ln_id number;
begin
if nID<=0 then
insert into T_STUDENT (ID,NAME,SURNAME,AGE,CNAUTHORID) values (SEQ_ID.NEXTVALUE,vchNAME,vchSURNAME,nAGE,nCNAUTHORID ) returning ID into ln_id;
else
update T_STUDENT set NAME=vchNAME,SURNAME=vchSURNAME,AGE=nAGE,CNAUTHORID=nCNAUTHORID
where ID=nID;
ln_id := nID;
end if;
return ln_id;
end;