Procedure with in procedure

Question

Hi,
i need to call a procedure with in another procedure and pass the main procedure values. when i am doing like this i am getting the error.
Can any one tell me where the error is:
the main procedure is xxxx( P_PHONE IN VARCHAR2,
P_CLIENT IN VARCHAR2,
P_MANAGER IN VARCHAR2,
P_ACCOUNTANT IN VARCHAR2
as
x:=P_PHONE;
y:= P_CLIENT;
z:= P_MANAGER;
n:= P_ACCOUNTANT;
exec tlm_ar_string_to_table(x,y,z,n);
end;
my inner procedure is
create or replace procedure tlm_ar_string_to_table(
P_PHONE IN VARCHAR2,
P_CLIENT IN VARCHAR2,
P_MANAGER IN VARCHAR2,
P_ACCOUNTANT IN VARCHAR2
as
p_string_c varchar2(500);
P_PROCESSING_GROUP_C varchar2(10);
P_client_C varchar2(10);
P_manager_C varchar2(10);
P_accountant_C varchar2(10);
p_search_result_c varchar2(10);
CURSOR psg_CURSOR IS
SELECT distinct phone FROM SSRFUND.bank where phone>' ' ;
cursor string_ex_cur is
select substr( p_string_c
, decode( level, 1, 1, instr(p_string_c,',',1,level-1)+1)
, decode( instr(p_string_c,',',1,level), 0, length(p_string_c),
instr(p_string_c,',',1,level) - decode( level, 1, 0, instr(p_string_c,',',1,level-1))-1)
) the_value
from ( select p_string_c
from dual)
connect by level <= length(p_string_c)-length(replace(p_string_c,','))+1;
cursor mgr_cursor is
select distinct fax from ssrfund.bank;
cursor client_cursor is
select distinct swift_address from ssrfund.bank;
cursor accountant_cursor is
select distinct telex from ssrfund.bank;
begin
execute immediate 'Truncate table temp_processing_group';
execute immediate 'Truncate table temp_accountant';
execute immediate 'Truncate table temp_client';
execute immediate 'Truncate table temp_manager';
if (P_PHONE is null) then
open psg_cursor;
loop
FETCH psg_cursor INTO P_PROCESSING_GROUP_C;
EXIT WHEN (psg_cursor%NOTFOUND);
insert into temp_PROCESSING_GROUP values(P_PROCESSING_GROUP_C);
commit;
end loop;
close psg_cursor;
else
p_search_result_c:=instr(p_phone,',');
if (p_search_result_c='TRUE') then
p_string_c:=p_phone;
open string_ex_cur;
loop
fetch string_ex_cur into P_PROCESSING_GROUP_C;
insert into temp_PROCESSING_GROUP values(P_PROCESSING_GROUP_C);
commit;
end loop;
close string_ex_cur;
else
insert into temp_PROCESSING_GROUP values(P_PROCESSING_GROUP_C);
commit;
end if;
end if;
if (P_client is null) then
open client_cursor;
loop
FETCH client_CURSOR INTO P_client_C;
EXIT WHEN (client_CURSOR%NOTFOUND);
insert into temp_client values(P_client_C);
commit;
end loop;
close client_cursor;
else
p_search_result_c:=instr(p_client,',');
if (p_search_result_c='TRUE') then
p_string_c:=p_client;
open string_ex_cur;
loop
fetch string_ex_cur into P_client_C;
insert into temp_client values(P_client_C);
commit;
end loop;
close string_ex_cur;
else
insert into temp_client values(P_client_C);
commit;
end if;
end if;
if (P_manager is null) then
open mgr_cursor;
loop
FETCH mgr_CURSOR INTO P_manager_C;
EXIT WHEN (mgr_CURSOR%NOTFOUND);
insert into temp_manager values(P_manger_C);
commit;
end loop;
close mgr_cursor;
else
p_search_result_c:=instr(P_manager,',');
if (p_search_result_c='TRUE') then
p_string_c:=p_manager;
open string_ex_cur;
loop
fetch string_ex_cur into P_manager_C;
insert into temp_manager values(P_manager_C);
commit;
end loop;
close string_ex_cur;
else
insert into temp_manager values(P_manager_C);
commit;
end if;
end if;
if (P_accountant is null) then
open accountant_cursor;
loop
FETCH accountant_cursor INTO P_accountant_C;
EXIT WHEN (accountant_cursor%NOTFOUND);
insert into temp_accountant values(P_accountant_C);
commit;
end loop;
close accountant_cursor;
else
p_search_result_c:=instr(P_accountant,',');
if (p_search_result_c='TRUE') then
p_string_c:=p_accountant;
open string_ex_cur;
loop
fetch string_ex_cur into P_accountant_C;
insert into temp_accountant values(P_accountant_C);
commit;
end loop;
close string_ex_cur;
else
insert into temp_accountant values(P_accountant_C);
commit;
end if;
end if;
EXCEPTION
WHEN OTHERS THEN
RAISE_APPLICATION_ERROR (-20001, SQLERRM);
end;
/

Answer 1

user12852882 wrote:
i need to call a procedure with in another procedure and pass the main procedure values. when i am doing like this i am getting the error.Ugly code. There's seldom the need to use PL logic when the source and destination data both resides in Oracle tables. SQL should be used.
Also, why the the "+temp+" tables? I/O is single most expensive thing you can on a database platform. Why would one then want to create more I/O by creating temp tables? This approach may be needed in SQL-Server for example, but in Oracle it is usually just plain and horribly wrong.
I suggest that you scrap this code, forget about coding procedures-in-procedures (use packages instead), forget about trying to process row-by-row in a slow-by-slow fashion in the PL language.
SQL is not a mere I/O language to be used for reading and writing data (for PL code to process the row). SQL is a data processing language. Extremely capable. Extremely powerful. And can process Oracle data faster than any other language, including using the PL language component in the server.
The basic rule for effective and scalable Oracle code is Maximize SQL. Minimize PL/Java/etc.
Use the SQL language for its intended purpose and do not process rows needlessly in another language layer.