Qestion for implementing Runnable

Question

HI,
I have a function which executes multiple methods and store the result from those methods in List<Stirng> before the last methods executes I need to insert these List<String> values in a database with my dao object.
I was wondering if I do the following:
new Thread(new myInsertWorker()).start();
executeMyFunction();
Would I improve the performance on my program since it is very important for this last function to be fast.
My question is if I insert the strings as a separate thread how do I need to write the thread to be as simple as possible and not cause any performance issues?

Answer 1

Here is my code, I am new to concurrent programming, therefore I move slowly :) and check my code with someone else to prevent issues I am not aware of.
Can I improve this simple piece of code to make sure if it does fail or hangs my application will not be affected?
Thank you
public class LogMessageWorker implements Runnable {
    List<LogMessage>_messages = new LinkedList();
    LogMessageDAO _logMessageDAO=null;
    public LogMessageWorker(LogMessageDAO logMessageDAO, List<LogMessage> messages){
        this._messages = messages;
        this._logMessageDAO = logMessageDAO;
    public LogMessageWorker(LogMessageDAO logMessageDAO, LogMessage message){
        this._messages.add(message);
        this._logMessageDAO = logMessageDAO;
    public void run() {
        try{
            _logMessageDAO.add(_messages);
        }catch(Exception e){
            e.printStackTrace();
}This is how I call it:
try {
            Thread logMsgThread = new Thread(new LogMessageWorker(logMessageDAO, logMessages));
            //logMsgThread.setPriority(Thread.MIN_PRIORITY);
            logMsgThread.start();
        } catch (Exception e) {
            e.printStackTrace();
        }Edited by: kminev on Dec 3, 2009 2:06 PM