Query on for all and delete

Question

Hi all,
I have developed a procedure. It is deleing records from a table.
Create or Replace PROCEDURE sidoc_delete(period date)
   IS
      /*CURSOR c5 IS
      SELECT *
        FROM ibsoifc.ibs_s_i_doc_receipt a
       WHERE EXISTS (
                SELECT 1
                  FROM ibsoifc.ibs_x_t_bill b
                 WHERE a.app_to_doc_no = b.doc_no
                   AND b.bill_month <= period
                   --AND b.bpref_no = :cons
                   AND b.balance_ser_amt = 0
                   AND b.balance_tax_amt = 0)
         --AND a.bpref_no = :cons
         AND a.app_to_doc_date <= period;*/
         Cursor C5 is
            SELECT a.rowid,a.*
              FROM ibsoifc.ibs_s_i_doc_receipt a,
                   ibsoifc.ibs_x_t_bill b
             WHERE a.app_to_doc_no = b.doc_no
               AND b.bill_month <= period
               AND b.balance_ser_amt = 0
               AND b.balance_tax_amt = 0
               AND a.app_to_doc_date <= period;
      TYPE tsch IS TABLE OF c5%ROWTYPE;
      vtsch      tsch;
      cnt        NUMBER := 0;
      stime      NUMBER;
      etime      NUMBER;
      DURATION   NUMBER;
      rcount     NUMBER;
      errorsd   PLS_INTEGER;
      ecode     NUMBER;
      val1   VARCHAR2 (100);
      val2   VARCHAR2 (100);
      val3   VARCHAR2 (100);
      val4   VARCHAR2 (100);
   BEGIN
      BEGIN
         stime := DBMS_UTILITY.get_time ();
         OPEN c5;
         LOOP
            FETCH c5
            BULK COLLECT INTO vtsch LIMIT 1000;
            IF vtsch.COUNT = 1000
            THEN
               cnt := cnt + 1;
            END IF;
            FORALL i IN vtsch.first .. vtsch.last SAVE EXCEPTIONS
               Delete from ibsoifc.ibs_s_i_doc_receipt where app_to_doc_date <= Period;
            commit;
            EXIT WHEN c5%NOTFOUND;
         END LOOP;
         etime := DBMS_UTILITY.get_time ();
         DURATION := ((etime - stime) / 100) / 60;
         rcount :=
             (cnt * 1000) + vtsch.COUNT - NVL (SQL%BULK_EXCEPTIONS.COUNT, 0);
         INSERT INTO process_stage_log
              VALUES (SYSDATE, 'IBS_S_I_DOC_RECEIPTS-D', DURATION, rcount);
         CLOSE c5;
         COMMIT;
      EXCEPTION
         WHEN OTHERS
         THEN
            Begin
            errorsd := SQL%BULK_EXCEPTIONS.COUNT;
            IF errorsd > 0
            THEN
               FOR j IN 1 .. errorsd
               LOOP
                  ecode := SQL%BULK_EXCEPTIONS (j).ERROR_CODE;
                  val1 :=
                     vtsch (SQL%BULK_EXCEPTIONS (j).ERROR_INDEX).biz_part_code;
                  val2 :=
                       vtsch (SQL%BULK_EXCEPTIONS (j).ERROR_INDEX).bpref_no;
                  val3 :=
                     vtsch (SQL%BULK_EXCEPTIONS (j).ERROR_INDEX).apply_date;
                  val4 :=
                     vtsch (SQL%BULK_EXCEPTIONS (j).ERROR_INDEX).service_code;
                  INSERT INTO process_error_log
                       VALUES (SYSDATE, ecode, 'IBS_S_I_DOC_RECEIPTS', 'biz_part_code',
                               val1, 'bpref_no', val2, 'apply_date', val3, 'service_code', val4,'DELETE');
                  etime := DBMS_UTILITY.get_time ();
                  DURATION := ((etime - stime) / 100) / 60;
                  rcount := (cnt * 1000) + vtsch.COUNT - NVL (SQL%BULK_EXCEPTIONS.COUNT, 0);
                  INSERT INTO process_stage_log VALUES (SYSDATE, 'IBS_S_I_DOC_RECEIPTS-D', DURATION, rcount);
               END LOOP;
            END IF;
            Exception
              When others then
                   etime := DBMS_UTILITY.get_time ();
                   DURATION := ((etime - stime) / 100) / 60;
                   INSERT INTO process_stage_log
                   VALUES (SYSDATE, 'IBS_S_I_DOC_RECEIPTS-D', DURATION, 0);
            End;
      END;
   END sidoc_delete;The table IBS_S_I_DOC_RECEIPTS is having 50 million records.
The table IBS_X_T_BILL is having is having 39 million records.
The procedure is open a cursor
Cursor C5 is
            SELECT a.rowid,a.*
              FROM ibsoifc.ibs_s_i_doc_receipt a,
                   ibsoifc.ibs_x_t_bill b
             WHERE a.app_to_doc_no = b.doc_no
               AND b.bill_month <= period
               AND b.balance_ser_amt = 0
               AND b.balance_tax_amt = 0
               AND a.app_to_doc_date <= period;and deleting by the following command
FORALL i IN vtsch.first .. vtsch.last SAVE EXCEPTIONS
               Delete from ibsoifc.ibs_s_i_doc_receipt where app_to_doc_date <= Period;question
1.The above delete, will delete all the record which below to date or from cursor active set record which below to the date?.
I run the above procedure for 5 years
and my procedure is running sill now and it is started wednesday morning. so for just 15 laks only deleted.
How to improve the procedure performance.
please guide me
kanish

Answer 1

This is my actual coding which running now
Create or Replace PROCEDURE sidoc_delete(period date)
   IS
      /*CURSOR c5 IS
      SELECT *
        FROM ibsoifc.ibs_s_i_doc_receipt a
       WHERE EXISTS (
                SELECT 1
                  FROM ibsoifc.ibs_x_t_bill b
                 WHERE a.app_to_doc_no = b.doc_no
                   AND b.bill_month <= period
                   --AND b.bpref_no = :cons
                   AND b.balance_ser_amt = 0
                   AND b.balance_tax_amt = 0)
         --AND a.bpref_no = :cons
         AND a.app_to_doc_date <= period;*/
         Cursor C5 is
            SELECT a.rowid,a.*
              FROM ibsoifc.ibs_s_i_doc_receipt a,
                   ibsoifc.ibs_x_t_bill b
             WHERE a.app_to_doc_no = b.doc_no
               AND b.bill_month <= period
               AND b.balance_ser_amt = 0
               AND b.balance_tax_amt = 0
               AND a.app_to_doc_date <= period;
      TYPE tsch IS TABLE OF c5%ROWTYPE;
      vtsch      tsch;
      cnt        NUMBER := 0;
      stime      NUMBER;
      etime      NUMBER;
      DURATION   NUMBER;
      rcount     NUMBER;
      errorsd   PLS_INTEGER;
      ecode     NUMBER;
      val1   VARCHAR2 (100);
      val2   VARCHAR2 (100);
      val3   VARCHAR2 (100);
      val4   VARCHAR2 (100);
   BEGIN
      BEGIN
         stime := DBMS_UTILITY.get_time ();
         OPEN c5;
         LOOP
            FETCH c5
            BULK COLLECT INTO vtsch LIMIT 1000;
            IF vtsch.COUNT = 1000
            THEN
               cnt := cnt + 1;
            END IF;
            FORALL i IN vtsch.first .. vtsch.last SAVE EXCEPTIONS
               Delete from ibsoifc.ibs_s_i_doc_receipt where rowid= vtsch(i).rowid;
               --app_to_doc_no = vtsch(i).app_to_doc_no;
            commit;
            EXIT WHEN c5%NOTFOUND;
         END LOOP;
         etime := DBMS_UTILITY.get_time ();
         DURATION := ((etime - stime) / 100) / 60;
         rcount :=
             (cnt * 1000) + vtsch.COUNT - NVL (SQL%BULK_EXCEPTIONS.COUNT, 0);
         INSERT INTO process_stage_log
              VALUES (SYSDATE, 'IBS_S_I_DOC_RECEIPTS-D', DURATION, rcount);
         CLOSE c5;
         COMMIT;
      EXCEPTION
         WHEN OTHERS
         THEN
            Begin
            errorsd := SQL%BULK_EXCEPTIONS.COUNT;
            IF errorsd > 0
            THEN
               FOR j IN 1 .. errorsd
               LOOP
                  ecode := SQL%BULK_EXCEPTIONS (j).ERROR_CODE;
                  val1 :=
                     vtsch (SQL%BULK_EXCEPTIONS (j).ERROR_INDEX).biz_part_code;
                  val2 :=
                       vtsch (SQL%BULK_EXCEPTIONS (j).ERROR_INDEX).bpref_no;
                  val3 :=
                     vtsch (SQL%BULK_EXCEPTIONS (j).ERROR_INDEX).apply_date;
                  val4 :=
                     vtsch (SQL%BULK_EXCEPTIONS (j).ERROR_INDEX).service_code;
                  INSERT INTO process_error_log
                       VALUES (SYSDATE, ecode, 'IBS_S_I_DOC_RECEIPTS', 'biz_part_code',
                               val1, 'bpref_no', val2, 'apply_date', val3, 'service_code', val4,'DELETE');
                  etime := DBMS_UTILITY.get_time ();
                  DURATION := ((etime - stime) / 100) / 60;
                  rcount := (cnt * 1000) + vtsch.COUNT - NVL (SQL%BULK_EXCEPTIONS.COUNT, 0);
                  INSERT INTO process_stage_log VALUES (SYSDATE, 'IBS_S_I_DOC_RECEIPTS-D', DURATION, rcount);
               END LOOP;
            END IF;
            Exception
              When others then
                   etime := DBMS_UTILITY.get_time ();
                   DURATION := ((etime - stime) / 100) / 60;
                   INSERT INTO process_stage_log
                   VALUES (SYSDATE, 'IBS_S_I_DOC_RECEIPTS-D', DURATION, 0);
            End;
      END;
   END sidoc_delete;kanish