Question - Passing date to a function from a Query

Question

Hello,
I have a function which looks like this
CREATE OR REPLACE FUNCTION CAL_DATES_FNC
(fp_fddate IN VARCHAR2,
fp_task IN VARCHAR2
RETURN VARCHAR2
IS
BEGIN
IF TO_CHAR(TO_DATE(fp_fddate,'YYYYMMDD'),'DD-MON-YYYY') <= TO_CHAR(ADD_MONTHS(TO_DATE(fp_fddate,'YYYYMMDD'),60),'DD-MON-YYYY')
THEN
RETURN TO_CHAR(ADD_MONTHS(TO_DATE(fp_fddate,'YYYYMMDD') +21,6 * SUBSTR(fp_task,-2)) ,'DD-MON-YYYY');
ELSIF TO_CHAR(TO_DATE(fp_fddate,'YYYYMMDD'),'DD-MON-YYYY') >= TO_CHAR(ADD_MONTHS(TO_DATE(fp_fddate,'YYYYMMDD'),72),'DD-MON-YYYY')
THEN
RETURN TO_CHAR(ADD_MONTHS(TO_DATE(fp_fddate,'YYYYMMDD') +21,12 * SUBSTR(fp_task,-2)) ,'DD-MON-YYYY');
END IF;
END;
I am using this function in a query as given below to pass a date fp_fddate
The problem I am having is that the function is executing only the first part of the IF construct it is not going into the second IF condition.
Can some one please let me know where I could be going wrong.
SELECT ABC.PT,
ABC.INV,
ABC.INVSITE,
ABC.TASK TASK_NAME,MAX(XYZ.FPDATE) fpdate ,
CAL_DATES_FNC(MAX(XYZ.FPDATE),ABC.CPTASK) "DATE1",
TO_CHAR(TO_DATE(ABC.D_YR||ABC.D_MON||ABC.D_DAY,'YYYYMMDD'),'DD-MON-YYYY') "DATE2"
FROM ABC,
XYZ
WHERE ABC.PT = XYZ.PT
AND PATSTAT.PT = '61090'
GROUP BY ABC.PT,ABC.INV,ABC.INVSITE,ABC.D_YR,ABC.D_MON,ABC.D_DAY,ABC.CPTASK
Regards
Fm

Answer 1

Hi,
IQ wrote:
Thanks for your messages. I am sending the scripts for the tables and insert statements in this message. Hope this will help to recreate the scenario.Don't forget to post the output you want from that data, and an explanation of how you get that output from the given data.
Some of my answers are as follows,
1) I know that the function is not in a proper syntax and thats the reason I need to fix it to be able to perform well. All I want is to compare the dates for a 5 year period(60 months) and then return something . For a period greater than 6 years (72 months) it should return something else.What dates do you want to compare? I assume fp_fddate is one of them, but what about the other(s)?
When does the 5-year period begin or end?
When does the 6-year period begin or end?
I understand the fucntion may return either of two values. Do you care what those two values are? If so, give examples.
What if the date is in neither the 5-year nor the 6-year period? (A fucntion has to return something in all cases. It can return NULL, if that's what you want.)
What if the argument can't be interpreted as a date?
2) Regarding the string datatype for date columns I cannot change the database design as this is done by another team, I can however explain them the points mentioned here.
Please find below the scripts When you say TEST_DATES, do you mean TEST_DATES1. or is there another table? Test before you post.
CREATE TABLE TEST_DATES
pt VARCHAR2(10 BYTE),
inv VARCHAR2(10 BYTE),
invsite VARCHAR2(10 BYTE),
task_name VARCHAR2(20 BYTE),
fpddate VARCHAR2(8 BYTE),
DATE1 VARCHAR2(4000 BYTE),
DATE2 VARCHAR2(17 BYTE)
insert into test_dates1(pt,inv,invsite,task_name,fpddate,date1,date2)
values (61090,'XDUMMY1'     ,'R1111','UP01'     ,'19990714','04-FEB-2000',     '17-JAN-2000');
insert into test_dates1(pt,inv,invsite,task_name,fpddate,date1,date2)
values (
61090,     'XDUMMY1','R1111','UP02','19990714','04-AUG-2000','20-JUL-2000');
insert into test_dates1(pt,inv,invsite,task_name,fpddate,date1,date2)
values (
61090,     'XDUMMY1','R1111','UP03','19990714','04-FEB-2001','19-JAN-2001');
insert into test_dates1(pt,inv,invsite,task_name,fpddate,date1,date2)
values (
61090,'XDUMMY1','R1111','UP04','19990714','04-AUG-2001','21-JUL-2001');
insert into test_dates1(pt,inv,invsite,task_name,fpddate,date1,date2)
values (
61090,'XDUMMY1','R1111','UP05','19990714','04-FEB-2002','20-JAN-2002');
insert into test_dates1(pt,inv,invsite,task_name,fpddate,date1,date2)
values (
61090,'XDUMMY1','R1111','UP06','19990714','04-AUG-2002','19-JUL-2002');
insert into test_dates1(pt,inv,invsite,task_name,fpddate,date1,date2)
values (
61090,'XDUMMY1','R1111','UP07','19990714','04-FEB-2003','17-JAN-2003');
insert into test_dates1(pt,inv,invsite,task_name,fpddate,date1,date2)
values (
61090,'XDUMMY1','R1111','UP08','19990714','04-AUG-2003','15-JUL-2003');
insert into test_dates1(pt,inv,invsite,task_name,fpddate,date1,date2)
values (
61090,'XDUMMY1','R1111','UP09','19990714','04-FEB-2004','20-JAN-2004');
insert into test_dates1(pt,inv,invsite,task_name,fpddate,date1,date2)
values (
61090,'XDUMMY1','R1111','UP10','19990714','04-AUG-2004','25-JUL-2004');
insert into test_dates1(pt,inv,invsite,task_name,fpddate,date1,date2)
values (
61090,'XDUMMY1','R1111','UP11','19990714','04-FEB-2005','27-JAN-2005');
insert into test_dates1(pt,inv,invsite,task_name,fpddate,date1,date2)
values (
61090,'XDUMMY1','R1111','UP12','19990714','04-AUG-2005','25-JUL-2005');
insert into test_dates1(pt,inv,invsite,task_name,fpddate,date1,date2)
values (
61090,'XDUMMY1','R1111','UP13','19990714','04-FEB-2006','28-JAN-2006');
insert into test_dates1(pt,inv,invsite,task_name,fpddate,date1,date2)
values (
61090,'XDUMMY1','R1111','UP14','19990714','04-AUG-2006','30-JUL-2006');
insert into test_dates1(pt,inv,invsite,task_name,fpddate,date1,date2)
values (
61090,'XDUMMY1','R1111','UP15','19990714','04-FEB-2007','31-JAN-2007');
/You said that sometimes the data contains values like 'NA'. Shouldn;t the sample data have an example or two of that?
Once the data is populated in the table , use the following query
select TASK_NAME,RCM_CAL_THEORETIC_DATES_FNC(MAX(fpddate),task_name) "DATE1"
from test_dates1
group by task_name When you say
RCM_CAL_THEORETIC_DATES_FNC, do you mean the function you posted in your first message, which was called
CAL_DATES_FNC, or is there another funciton?
When I make those changes and run the query, I get 15 rows:
TASK_NAME            DATE1
UP06                 04-AUG-2002
UP07                 04-FEB-2003
UP14                 04-AUG-2006
UP08                 04-AUG-2003
UP10                 04-AUG-2004
UP12                 04-AUG-2005
UP15                 04-FEB-2007
UP01                 04-FEB-2000
UP02                 04-AUG-2000
UP03                 04-FEB-2001
UP05                 04-FEB-2002
UP13                 04-FEB-2006
UP04                 04-AUG-2001
UP09                 04-FEB-2004
UP11                 04-FEB-2005Is that correct?
If so, what is the problem?
If not, what results should I get?
What is the function supposed to do?
Edited by: Frank Kulash on Nov 9, 2010 4:45 PM