REPOST: JSP problems!!!

Question

Sorry about the repost,
I have been trying to get my JSP to work all night but with no success. At the moment it outputs the total set of data which I presume means that my queries aren't being executed properly. They work fine when typed directly into MySQL. Can anyone see the problem?
The methods that I am using and the jsp code are displayed below,
     public void roomsBooked(String arrivalDate, String departureDate) throws SQLException, Exception
          if (con != null)
            try
              Statement checkBookings = con.createStatement();
              String query = ("CREATE TEMPORARY TABLE roomsoccupied "
                    + "SELECT roombooked.room_id FROM roombooked, booking "
                    + "WHERE "
                    + "roombooked.booking_id = booking.booking_id "
                    + "AND "
                    + "booking.arrival_date <  '" + departureDate +"'"
                    + "AND "
                    + "booking.departure_date >  '" + arrivalDate +"'"
             checkBookings.executeUpdate(query);
            catch (SQLException sqle)
              error = ""+sqle;
              throw new SQLException(error);
            catch (Exception e)
                          error = ""+e;
                          throw new Exception(error);
          else
            error = "Exception: Connection to database was lost.";
            throw new Exception(error);
public ResultSet roomsAvailable() throws SQLException, Exception
          if (con != null)
            try
              Statement checkAvailability = con.createStatement();
              String query = ("SELECT rooms.room_no FROM rooms "
                    + "LEFT JOIN roomsoccupied ON rooms.room_no=roomsoccupied.room_id "
                    + "WHERE roomsoccupied.room_id IS NULL;"
             rs = checkAvailability.executeQuery(query);
            catch (SQLException sqle) {
              error = ""+sqle;
              throw new SQLException(error);
            catch (Exception e) {
                          error = ""+e;
                          throw new Exception(error);
          else {
            error = "Exception: Connection to database was lost.";
            throw new Exception(error);
       return rs;
  }JSP PAGE
<%
      javaBean.connect();
      String arrivalDate =  request.getParameter("ArrivalDate");
      String departureDate =  request.getParameter("DepartureDate");
      javaBean.roomsBooked(arrivalDate, departureDate);
      ResultSet rs = javaBean.roomsAvailable();
      while(rs.next())
      {  %> Room number <%= rs.getString(1) %>
       <P><% }
      javaBean.disconnect();
%>

Answer 1

Well here is the original code with the PreparedStatements,Looking at this code, I'd say you have to learn what PreparedStatements are for:
try
    String sql = "CREATE TEMPORARY TABLE roomsoccupied "
                      + "SELECT roombooked.room_id FROM roombooked, booked, booking "
                      + "WHERE "
                      + "roombooked.booking_id = booking.booking_id "
                      + "AND "
                      + "booking.arrival_date <  ? "                           
                      + "AND "
                      + "booking.departure_date > ?";
    PreparedStatement roomsBooked = con.prepareStatement(sql);
    roomsBooked.setDate(1, arrivalDate);   // This is what I mean by letting PS escape the dates for you
    roomsBooked.setDate(2, departureDate);
    roomsBooked.execute();
    roomsBooked.close();
} catch (SQLException sqle)
    sqle.printStackTrace();
    System.err.println("SQL state: " + sqle.getSQLState());
    System.err.println("SQL error: " + sqle.getErrorCode());
I'm assuming that you're passing java.sql.Dates to the method.  That's what PreparedStatement will require.  I'm also assuming that the columns in that table are of type date.
>
The queries work fine when run directly on the command
line into MySQL and I have used System.out.println
statements which tell me that both methods execute.
Which leads me to believe that the MySQL code in my
methods just isn't being entered into MySQL properly
which is why it is returning NULL.
Maybe.  It's good that the queries run in the MySQL command shell, but your problem is the JDBC code.
As far as the temporary table is concerned, one is
created for each connection to the database and it's
results depend on each users query, which is why it is
a temporary table rather then a permanent one. The
results of each users temporary table are then used by
the second method to obtain the needed results which
should then be output by the JSP.
I'll bet this could be done with a JOIN or a VIEW instead of a temporary table.  Sounds like the sign of a bad design, IMO. - MOD